)]}'
{"oslo_versionedobjects/base.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9fdbedf677c14383f6fa92e88b9b815772303053","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_utils import encodeutils"},{"line_number":25,"context_line":"from oslo_utils import excutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_versionedobjects._i18n import _, _LE"},{"line_number":30,"context_line":"from oslo_versionedobjects import _utils as utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a73c3a94","line":27,"updated":"2015-11-09 09:13:31.000000000","message":"PEP 8 doesn\u0027t complain because they are too many empty lines?","commit_id":"e8aef08492df4dcea87687b03dc2c08cb78ba689"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"8e2de79631e141f1ca8d8e626d7293719a0d848f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_utils import encodeutils"},{"line_number":25,"context_line":"from oslo_utils import excutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_versionedobjects._i18n import _, _LE"},{"line_number":30,"context_line":"from oslo_versionedobjects import _utils as utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b61a2d6d","line":27,"in_reply_to":"da85f559_a73c3a94","updated":"2015-11-09 09:45:12.000000000","message":"Thanks for spotting this!","commit_id":"e8aef08492df4dcea87687b03dc2c08cb78ba689"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9fdbedf677c14383f6fa92e88b9b815772303053","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                  \u0027\u003c?\u003e\u0027))"},{"line_number":313,"context_line":"                      for name, field in sorted(self.fields.items())]))"},{"line_number":314,"context_line":"        if not six.PY3:"},{"line_number":315,"context_line":"            repr_str \u003d encodeutils.safe_encode(repr_str)"},{"line_number":316,"context_line":"        return repr_str"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def __contains__(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_27704a72","line":315,"updated":"2015-11-09 09:13:31.000000000","message":"It\u0027s better to explicitly specify the incoming encoding:\n\nrepr_str \u003d safe_encode(repr_str, incoming\u003d\u0027utf-8\u0027)\n\nOtherwise, you depend on the local encoding which can be ASCII!\n\nSee: https://wiki.openstack.org/wiki/Python3#safe_encode","commit_id":"e8aef08492df4dcea87687b03dc2c08cb78ba689"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"8e2de79631e141f1ca8d8e626d7293719a0d848f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                  \u0027\u003c?\u003e\u0027))"},{"line_number":313,"context_line":"                      for name, field in sorted(self.fields.items())]))"},{"line_number":314,"context_line":"        if not six.PY3:"},{"line_number":315,"context_line":"            repr_str \u003d encodeutils.safe_encode(repr_str)"},{"line_number":316,"context_line":"        return repr_str"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def __contains__(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_27f60a90","line":315,"in_reply_to":"da85f559_27704a72","updated":"2015-11-09 09:45:12.000000000","message":"From the source code, it looks like incoming is meaningful only if using py3 and a bytes object is passed in as text param. In that case, the incoming param will be used as the encoding scheme to decode the bytes object (text). As this line is guarded by \"if not six.PY3\", it might be ok to leave it as is. But anyway, I will supply the incoming param just to be safe :)","commit_id":"e8aef08492df4dcea87687b03dc2c08cb78ba689"}]}