)]}'
{"oslo_versionedobjects/fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8195482909e29c510370d7952f34a21465ab6498","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            debtcollector.deprecate(\"%s is an invalid UUID. Using UUIDFields \""},{"line_number":315,"context_line":"                                    \"with invalid UUIDs is no longer \""},{"line_number":316,"context_line":"                                    \"supported, please update your\""},{"line_number":317,"context_line":"                                    \"code to input valid UUIDs or except \""},{"line_number":318,"context_line":"                                    \"ValueErrors for invalid UUIDs\" % value,"},{"line_number":319,"context_line":"                                    version\u003d\"1.5.0\", removal_version\u003d\"?\")"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_ec03e9b6","line":317,"range":{"start_line":317,"start_character":66,"end_line":317,"end_character":72},"updated":"2016-02-03 20:50:53.000000000","message":"Did you mean \"expect\" here?","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8f0dc6739d156ef546fbfad5894f2bcab13327f9","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            debtcollector.deprecate(\"%s is an invalid UUID. Using UUIDFields \""},{"line_number":315,"context_line":"                                    \"with invalid UUIDs is no longer \""},{"line_number":316,"context_line":"                                    \"supported, please update your\""},{"line_number":317,"context_line":"                                    \"code to input valid UUIDs or except \""},{"line_number":318,"context_line":"                                    \"ValueErrors for invalid UUIDs\" % value,"},{"line_number":319,"context_line":"                                    version\u003d\"1.5.0\", removal_version\u003d\"?\")"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6cd139cd","line":317,"updated":"2016-02-03 20:58:03.000000000","message":"No - I meant except - but I can change it if needed be.","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"de82eccd2a374e1197aace1c02407fe79d8854d9","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        This class does not actually validate UUIDs. This will happen in a"},{"line_number":781,"context_line":"        future major version of oslo.versionedobjects"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    To validate that that you have valid UUIDs you need to do the following in"},{"line_number":784,"context_line":"    your own objects/fields.py"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    :Example:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8a181086","line":783,"updated":"2016-02-03 23:49:59.000000000","message":"Ack","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b6576be5f95f42b2afdce0936f9fa88860fbc389","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        This class does not actually validate UUIDs. This will happen in a"},{"line_number":781,"context_line":"        future major version of oslo.versionedobjects"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    To validate that that you have valid UUIDs you need to do the following in"},{"line_number":784,"context_line":"    your own objects/fields.py"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    :Example:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_d46233d8","line":783,"range":{"start_line":783,"start_character":16,"end_line":783,"end_character":25},"updated":"2016-02-03 22:31:33.000000000","message":"I think you only want one that here","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b6576be5f95f42b2afdce0936f9fa88860fbc389","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            class UUID(ovo_fields.UUID):"},{"line_number":792,"context_line":"                 def coerce(self, obj, attr, value):"},{"line_number":793,"context_line":"                    try:"},{"line_number":794,"context_line":"                        uuid.UUID(value)"},{"line_number":795,"context_line":"                    return str(value)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_54cac3a2","line":794,"updated":"2016-02-03 22:31:33.000000000","message":"Maybe I\u0027m missing something here, but you shouldn\u0027t have this within a try right? You want to fail coerce on a bad uuid.","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"de82eccd2a374e1197aace1c02407fe79d8854d9","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            class UUID(ovo_fields.UUID):"},{"line_number":792,"context_line":"                 def coerce(self, obj, attr, value):"},{"line_number":793,"context_line":"                    try:"},{"line_number":794,"context_line":"                        uuid.UUID(value)"},{"line_number":795,"context_line":"                    return str(value)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_aa1dcc74","line":794,"updated":"2016-02-03 23:49:59.000000000","message":"Yes - I ws trying to cut down the example, and this got munged.","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"8f0dc6739d156ef546fbfad5894f2bcab13327f9","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                                postfix\u003d\". Please see \""},{"line_number":814,"context_line":"                                \"http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField \"  # noqa"},{"line_number":815,"context_line":"                                \"for further details\","},{"line_number":816,"context_line":"                                version\u003d\"1.5.0\", removal_version\u003d\"?\")"},{"line_number":817,"context_line":"        super(UUIDField, self).__init__(*args, **kwargs)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8cd6f5c3","line":816,"updated":"2016-02-03 20:58:03.000000000","message":"They shouldn\u0027t - it uses DeprecationWarning, which is ignored by default.\n\nThey may not be fine at run times - people may be relying on this for user input, and that could definitly cause an issue.\n\nI can pull it if it is a big deal though. I am just worried as we are just doing a big swap of non-validating -\u003e validating that there could be projects that do not get the memo, and in P we will have to revert the fix, as some project will have left it in their Newton code base.","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8195482909e29c510370d7952f34a21465ab6498","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                                postfix\u003d\". Please see \""},{"line_number":814,"context_line":"                                \"http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField \"  # noqa"},{"line_number":815,"context_line":"                                \"for further details\","},{"line_number":816,"context_line":"                                version\u003d\"1.5.0\", removal_version\u003d\"?\")"},{"line_number":817,"context_line":"        super(UUIDField, self).__init__(*args, **kwargs)"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_2c96e14c","line":816,"updated":"2016-02-03 20:50:53.000000000","message":"This seems excessive to me. This means anyone that uses o.vo will get this warning, even if they\u0027re not doing anything wrong. Like, every user of nova, cinder, ironic, etc will get this on startup even though those projects are fine _at_runtime_.\n\nI think the first one in coerce is fine, right?","commit_id":"8b2da6cf550354c133de189a5fd91698d0cd888c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"20fb7e8752d3f6b2e37d3a4f0e726cbb04a04eee","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                uuid.UUID(str(value))"},{"line_number":315,"context_line":"            except Exception:  # This is to ensure no breaking behaviour for"},{"line_number":316,"context_line":"                # current users"},{"line_number":317,"context_line":"                warnings.warn(\"%s is an invalid UUID. Using UUIDFields \""},{"line_number":318,"context_line":"                              \"with invalid UUIDs is no longer \""},{"line_number":319,"context_line":"                              \"supported, and will be removed in a future \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_dd91ca9a","line":316,"updated":"2016-02-04 16:01:21.000000000","message":"This split comment drives me nuts, but I will fix it.","commit_id":"c136101231b8912481bbcfdf28afa2e4002231f3"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"ab379161d8ba1cb35f702c07aa8b535f26666ad6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"class UUID(FieldType):"},{"line_number":308,"context_line":"    @staticmethod"},{"line_number":309,"context_line":"    def coerce(obj, attr, value):"},{"line_number":310,"context_line":"        # FIXME(danms): We should actually verify the UUIDness here"},{"line_number":311,"context_line":"        with warnings.catch_warnings():"},{"line_number":312,"context_line":"            warnings.simplefilter(\"once\")"},{"line_number":313,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_dd1b0a1a","line":310,"updated":"2016-02-04 16:02:32.000000000","message":"Remove FIXME? :)","commit_id":"c6adc63632905c05abdee45b4644b7154f21a270"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"6e3f9e2c23b1ea4897d0585ade5a324532353f4c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"class UUID(FieldType):"},{"line_number":308,"context_line":"    @staticmethod"},{"line_number":309,"context_line":"    def coerce(obj, attr, value):"},{"line_number":310,"context_line":"        # FIXME(danms): We should actually verify the UUIDness here"},{"line_number":311,"context_line":"        with warnings.catch_warnings():"},{"line_number":312,"context_line":"            warnings.simplefilter(\"once\")"},{"line_number":313,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_5d0dda8e","line":310,"in_reply_to":"5a5ae5dd_dd1b0a1a","updated":"2016-02-04 16:06:50.000000000","message":"Well, we still don\u0027t actually verify it yet - just emit a warning :)","commit_id":"c6adc63632905c05abdee45b4644b7154f21a270"}]}