)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"27df86d692e9b9779cc0388da2c358ddd9115d4f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add BaseEnumField valid_values introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new class property allows instrospection of the valid values,"},{"line_number":10,"context_line":"used to ease testing by random field generation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I749bc0acea4947450b4c02dca932a05a7a4ad534"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1af94dfe_f42d1ea9","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":36},"updated":"2016-03-17 12:31:57.000000000","message":"intro","commit_id":"b6552b7e0c1b9f5568238d32e42510d031c3d1cb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3e26fa414552204e72b72904f557d9a1e4953f33","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add BaseEnumField valid_values introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new class property allows instrospection of the valid values,"},{"line_number":10,"context_line":"used to ease testing by random field generation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I749bc0acea4947450b4c02dca932a05a7a4ad534"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1af94dfe_ad01843a","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":36},"in_reply_to":"1af94dfe_f42d1ea9","updated":"2016-03-17 14:30:24.000000000","message":"Done","commit_id":"b6552b7e0c1b9f5568238d32e42510d031c3d1cb"}],"oslo_versionedobjects/fields.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"aa1853e265cc9caacc166b4db937cc84386e535c","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                super(Enum, self).coerce(None, \u0027init\u0027, value)"},{"line_number":289,"context_line":"        except (TypeError, ValueError):"},{"line_number":290,"context_line":"            raise exception.EnumValidValuesInvalidError()"},{"line_number":291,"context_line":"        self.valid_values \u003d valid_values"},{"line_number":292,"context_line":"        super(Enum, self).__init__(**kwargs)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def coerce(self, obj, attr, value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_448a94c0","line":291,"updated":"2016-03-02 10:56:56.000000000","message":"this is probably not necessary, but I found more natural to make that field public, since it\u0027s being addressed by other objects.","commit_id":"a0617a7b399da55f7d8e0635890d7b9d5a27b979"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c4baccc112e761eacc6d128e78257f0b0e6bc586","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                super(Enum, self).coerce(None, \u0027init\u0027, value)"},{"line_number":289,"context_line":"        except (TypeError, ValueError):"},{"line_number":290,"context_line":"            raise exception.EnumValidValuesInvalidError()"},{"line_number":291,"context_line":"        self.valid_values \u003d valid_values"},{"line_number":292,"context_line":"        super(Enum, self).__init__(**kwargs)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def coerce(self, obj, attr, value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_590df9e6","line":291,"in_reply_to":"5aef4532_a5ba6b21","updated":"2016-03-09 22:29:27.000000000","message":"Makes sense, so done.\n\nI just exposed it as a property, but since the list is a mutable, may be we\u0027d want to return a copy of it. What do you think?","commit_id":"a0617a7b399da55f7d8e0635890d7b9d5a27b979"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"927cdc265e13b3d4f34b34a1fec776ebe210c4bf","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                super(Enum, self).coerce(None, \u0027init\u0027, value)"},{"line_number":289,"context_line":"        except (TypeError, ValueError):"},{"line_number":290,"context_line":"            raise exception.EnumValidValuesInvalidError()"},{"line_number":291,"context_line":"        self.valid_values \u003d valid_values"},{"line_number":292,"context_line":"        super(Enum, self).__init__(**kwargs)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def coerce(self, obj, attr, value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a5ba6b21","line":291,"in_reply_to":"7af24918_448a94c0","updated":"2016-03-08 16:43:54.000000000","message":"So I think I\u0027d rather you expose this as an @property instead of just making the attribute itself public. If you do this, we\u0027re opening ourselves up for people changing this definition after loading, which would be bad.\n\nI think the rest of your code can remain if you just revert this and add an @property for it. Is that okay?","commit_id":"a0617a7b399da55f7d8e0635890d7b9d5a27b979"}]}