)]}'
{"oslo_versionedobjects/fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7fd4f3fda04a47fbe7da0939ebd41a9341593377","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        except AttributeError:"},{"line_number":601,"context_line":"            # If we\u0027re not dealing with an object, it\u0027s probably a primitive"},{"line_number":602,"context_line":"            # so get it\u0027s type for the message below."},{"line_number":603,"context_line":"            obj_name \u003d type(value).__name__"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if self._subclasses:"},{"line_number":606,"context_line":"            obj_names \u003d self._get_all_obj_names(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_425a7d51","line":603,"updated":"2016-03-08 16:40:32.000000000","message":"So my problem with this is that it does not not ensure that we won\u0027t do the wrong thing. If the type name for whatever we\u0027re setting happens to be an object name then we\u0027ll do the wrong thing below. I think you need to set this to None or set a flag and handle that separately in the error message.","commit_id":"139e5aa6c538da9cf3d360feda45d66b53391435"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7cb71f5e5798811d473c38f0f45e9f6f271549cb","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        except AttributeError:"},{"line_number":601,"context_line":"            # If we\u0027re not dealing with an object, it\u0027s probably a primitive"},{"line_number":602,"context_line":"            # so get it\u0027s type for the message below."},{"line_number":603,"context_line":"            obj_name \u003d type(value).__name__"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if self._subclasses:"},{"line_number":606,"context_line":"            obj_names \u003d self._get_all_obj_names(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6d832199","line":603,"in_reply_to":"5aef4532_425a7d51","updated":"2016-03-08 19:43:03.000000000","message":"OK.","commit_id":"139e5aa6c538da9cf3d360feda45d66b53391435"}]}