)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41891b1fb78f78dc0f7ad0f329cece88263b4ce2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"First this causes equality comparisons to nondeterministically"},{"line_number":17,"context_line":"failed because the choice of python hash seed causes the order"},{"line_number":18,"context_line":"of elements in the list of changed fields to be unstable."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"More seriously though the list of changed fields does not have"},{"line_number":21,"context_line":"any bearing on whether the two objects are identical. The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_f0529ddc","line":18,"updated":"2016-04-04 21:33:28.000000000","message":"Well, we could fix this.","commit_id":"fe3155f0f92841928e3c3d41f96d3230f90965b6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41891b1fb78f78dc0f7ad0f329cece88263b4ce2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"of elements in the list of changed fields to be unstable."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"More seriously though the list of changed fields does not have"},{"line_number":21,"context_line":"any bearing on whether the two objects are identical. The"},{"line_number":22,"context_line":"equality should only be considering whether the actual field"},{"line_number":23,"context_line":"values are identical, and not be affected by the way in which"},{"line_number":24,"context_line":"the code chose to populate those field valyues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_b0a02592","line":21,"updated":"2016-04-04 21:33:28.000000000","message":"Why not? If you want to see if an object has been saved to the database or any new fields have been dirtied since you clone()\u0027d it and passed it to a subroutine, then I would think it does matter.\n\nSince we\u0027re now bound to very right controls over interfaces that have to support all active stable releases and master, I\u0027m not sure we can get away with this change as it definitely changes behavior that people could be depending on.\n\nWe could add another mixin that doesn\u0027t consider changes, or you could just add one in your own base class wherever you need it.","commit_id":"fe3155f0f92841928e3c3d41f96d3230f90965b6"}],"oslo_versionedobjects/base.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41891b1fb78f78dc0f7ad0f329cece88263b4ce2","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        finally:"},{"line_number":522,"context_line":"            delattr(self, \u0027_obj_version_manifest\u0027)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def obj_to_primitive(self, target_version\u003dNone, version_manifest\u003dNone,"},{"line_number":525,"context_line":"                         changes\u003dTrue):"},{"line_number":526,"context_line":"        \"\"\"Simple base-case dehydration."},{"line_number":527,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_503709b0","line":524,"updated":"2016-04-04 21:33:28.000000000","message":"I think I would rather we not modify this interface for this purpose, since it\u0027s woven very deeply into other places. It took some nasty work to be able to land the version_manifest\u003d change when I did it.","commit_id":"fe3155f0f92841928e3c3d41f96d3230f90965b6"}]}