)]}'
{"oslo_versionedobjects/fixture.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"39af8d366d7c1aaccfd3f25946cfa20e31a01e53","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # If the value isn\u0027t set on the object, and also isn\u0027t set on the"},{"line_number":70,"context_line":"        # db_obj, we\u0027ll skip the value check, unset in both is equal"},{"line_number":71,"context_line":"        if not obj.obj_attr_is_set(key) and db_key not in db_obj:"},{"line_number":72,"context_line":"            continue"},{"line_number":73,"context_line":"        # If it\u0027s set on the object and not on the db_obj, they aren\u0027t equal"},{"line_number":74,"context_line":"        elif obj.obj_attr_is_set(key) and db_key not in db_obj:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f0cff17c","line":71,"updated":"2016-05-19 16:57:00.000000000","message":"Since the base VersionedObject.__contains__ method just calls obj.obj_attr_is_set(), you could just use:\n\n if key not in obj and db_key not in db_obj:\n\nabove. That would make things consistent with the code on line 66.","commit_id":"52545273d99c408623890dc2d57351575b4c8e0c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"39af8d366d7c1aaccfd3f25946cfa20e31a01e53","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not obj.obj_attr_is_set(key) and db_key not in db_obj:"},{"line_number":72,"context_line":"            continue"},{"line_number":73,"context_line":"        # If it\u0027s set on the object and not on the db_obj, they aren\u0027t equal"},{"line_number":74,"context_line":"        elif obj.obj_attr_is_set(key) and db_key not in db_obj:"},{"line_number":75,"context_line":"            raise AssertionError((\"%s (db_key: %s) is set on the object, but \""},{"line_number":76,"context_line":"                                  \"not on the db_obj, so the objects are not \""},{"line_number":77,"context_line":"                                  \"equal\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d0caad6d","line":74,"updated":"2016-05-19 16:57:00.000000000","message":"ditto.","commit_id":"52545273d99c408623890dc2d57351575b4c8e0c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"39af8d366d7c1aaccfd3f25946cfa20e31a01e53","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                  \"equal\")"},{"line_number":78,"context_line":"                                 % (key, db_key))"},{"line_number":79,"context_line":"        # If it\u0027s set on the db_obj and not the object, they aren\u0027t equal"},{"line_number":80,"context_line":"        elif not obj.obj_attr_is_set(key) and db_key in db_obj:"},{"line_number":81,"context_line":"            raise AssertionError((\"%s (db_key: %s) is set on the db_obj, but \""},{"line_number":82,"context_line":"                                  \"not on the object, so the objects are not \""},{"line_number":83,"context_line":"                                  \"equal\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_30ca196e","line":80,"updated":"2016-05-19 16:57:00.000000000","message":"ditto.","commit_id":"52545273d99c408623890dc2d57351575b4c8e0c"}]}
