)]}'
{"oslo_versionedobjects/base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"71bf65e89118fd13109d368128318f9f89aed1a4","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # of issues by copying only our field data."},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        nobj \u003d self.__class__()"},{"line_number":461,"context_line":"        memo[id(self)] \u003d nobj"},{"line_number":462,"context_line":"        nobj._context \u003d self._context"},{"line_number":463,"context_line":"        for name in self.fields:"},{"line_number":464,"context_line":"            if self.obj_attr_is_set(name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8f82de92","line":461,"updated":"2016-08-09 18:27:32.000000000","message":"@serhii: Wow, that code in copy module is, well, a little obscure :) If you wouldn\u0027t mind, please add a note above that includes the link to the copy module and explains why the above line was added :) Otherwise it\u0027s extremely weird to read...","commit_id":"b0f44f287a501d5b539311d8903e91c371e88b53"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f99eed9406c9829ec5c7c7928917b293f504c30c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # of issues by copying only our field data."},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        nobj \u003d self.__class__()"},{"line_number":461,"context_line":"        memo[id(self)] \u003d nobj"},{"line_number":462,"context_line":"        nobj._context \u003d self._context"},{"line_number":463,"context_line":"        for name in self.fields:"},{"line_number":464,"context_line":"            if self.obj_attr_is_set(name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ea471575","line":461,"updated":"2016-08-09 15:06:47.000000000","message":"Serhii, can you show an example of what bits are being copied unnecessarily? How are you determining this?","commit_id":"b0f44f287a501d5b539311d8903e91c371e88b53"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"80efb211314a91d196e90ccc7fd52e7f157cbed9","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # of issues by copying only our field data."},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        nobj \u003d self.__class__()"},{"line_number":461,"context_line":"        memo[id(self)] \u003d nobj"},{"line_number":462,"context_line":"        nobj._context \u003d self._context"},{"line_number":463,"context_line":"        for name in self.fields:"},{"line_number":464,"context_line":"            if self.obj_attr_is_set(name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_91832056","line":461,"in_reply_to":"9ad45d7e_8f82de92","updated":"2016-08-09 19:25:18.000000000","message":"We just use memo for its intended purpose. U\u0027ve updated a bug report.","commit_id":"b0f44f287a501d5b539311d8903e91c371e88b53"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"943b59a54bf7f1e12f8f164af168c30a53997320","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # of issues by copying only our field data."},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        nobj \u003d self.__class__()"},{"line_number":461,"context_line":"        memo[id(self)] \u003d nobj"},{"line_number":462,"context_line":"        nobj._context \u003d self._context"},{"line_number":463,"context_line":"        for name in self.fields:"},{"line_number":464,"context_line":"            if self.obj_attr_is_set(name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_fee06efc","line":461,"in_reply_to":"9ad45d7e_ea471575","updated":"2016-08-09 17:14:02.000000000","message":"I\u0027ve added some extra debug logging here, and saw a lot of (re)creatings of the same object.\n\nPlease take a look how dict is deepcopied by python stdlib: https://github.com/python/cpython/blob/2d264235f6e066611b412f7c2e1603866e0f7f1b/Lib/copy.py#L236-L241","commit_id":"b0f44f287a501d5b539311d8903e91c371e88b53"}]}