)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f0226eb8d4a381e5de99fbd5958143d066d059ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nakul Dahiwade \u003cnakul.dahiwade@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 17:36:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_99731780","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"updated":"2016-12-09 22:31:35.000000000","message":"This exceeds the maximum number of characters for the title","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e85f1e0d7549db14d06369824bbf1f0d0528c9e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nakul Dahiwade \u003cnakul.dahiwade@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 17:36:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_a82b9f32","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"in_reply_to":"3a71b18c_14140542","updated":"2016-12-12 17:02:13.000000000","message":"Done","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"4e2ed4285ea5e34f02f608a0ad668daeea860874","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nakul Dahiwade \u003cnakul.dahiwade@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 17:36:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_14140542","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"in_reply_to":"3a71b18c_99731780","updated":"2016-12-12 11:16:41.000000000","message":"Adding to this comment - Titles shouldn\u0027t end in \u0027.\u0027 either.","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e85f1e0d7549db14d06369824bbf1f0d0528c9e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nakul Dahiwade \u003cnakul.dahiwade@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 17:36:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_8800a3ac","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"in_reply_to":"3a71b18c_99731780","updated":"2016-12-12 17:02:13.000000000","message":"Done","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f0226eb8d4a381e5de99fbd5958143d066d059ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"},{"line_number":11,"context_line":"Oslo-Versioned-Object."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia7d726b438f0ec9deeb797bf0dd1e438e05881ef"},{"line_number":14,"context_line":"Closes-Bug: 1648560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_d952efdd","line":11,"range":{"start_line":10,"start_character":64,"end_line":11,"end_character":22},"updated":"2016-12-09 22:31:35.000000000","message":"nit: This can be omitted","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e85f1e0d7549db14d06369824bbf1f0d0528c9e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding Dict and List as valid value types in String() Field."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch overrides the String() field in order to accept list and"},{"line_number":10,"context_line":"dict as valid value types for any DictOfStringsField type field in any"},{"line_number":11,"context_line":"Oslo-Versioned-Object."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia7d726b438f0ec9deeb797bf0dd1e438e05881ef"},{"line_number":14,"context_line":"Closes-Bug: 1648560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_082bb331","line":11,"range":{"start_line":10,"start_character":64,"end_line":11,"end_character":22},"in_reply_to":"3a71b18c_d952efdd","updated":"2016-12-12 17:02:13.000000000","message":"Done","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"}],"oslo_versionedobjects/fields.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f0226eb8d4a381e5de99fbd5958143d066d059ff","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    @staticmethod"},{"line_number":256,"context_line":"    def coerce(obj, attr, value):"},{"line_number":257,"context_line":"        # FIXME(danms): We should really try to avoid the need to do this"},{"line_number":258,"context_line":"        accepted_types \u003d six.integer_types + (float, six.string_types,"},{"line_number":259,"context_line":"                                              datetime.datetime)"},{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_59c7bf97","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":22},"updated":"2016-12-09 22:31:35.000000000","message":"What about adding dict and list in the accepted_types collection?\n\n    accepted_types \u003d six.integer_types + (float, six.string_types,\n                                          datetime.datetime, list, dict)","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"4e2ed4285ea5e34f02f608a0ad668daeea860874","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    @staticmethod"},{"line_number":256,"context_line":"    def coerce(obj, attr, value):"},{"line_number":257,"context_line":"        # FIXME(danms): We should really try to avoid the need to do this"},{"line_number":258,"context_line":"        accepted_types \u003d six.integer_types + (float, six.string_types,"},{"line_number":259,"context_line":"                                              datetime.datetime)"},{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_7499b978","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":22},"in_reply_to":"3a71b18c_59c7bf97","updated":"2016-12-12 11:16:41.000000000","message":"Agreed, this is a neater way of doing this.","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e85f1e0d7549db14d06369824bbf1f0d0528c9e8","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    @staticmethod"},{"line_number":256,"context_line":"    def coerce(obj, attr, value):"},{"line_number":257,"context_line":"        # FIXME(danms): We should really try to avoid the need to do this"},{"line_number":258,"context_line":"        accepted_types \u003d six.integer_types + (float, six.string_types,"},{"line_number":259,"context_line":"                                              datetime.datetime)"},{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_a8d2bf32","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":22},"in_reply_to":"3a71b18c_59c7bf97","updated":"2016-12-12 17:02:13.000000000","message":"Done","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e85f1e0d7549db14d06369824bbf1f0d0528c9e8","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    @staticmethod"},{"line_number":256,"context_line":"    def coerce(obj, attr, value):"},{"line_number":257,"context_line":"        # FIXME(danms): We should really try to avoid the need to do this"},{"line_number":258,"context_line":"        accepted_types \u003d six.integer_types + (float, six.string_types,"},{"line_number":259,"context_line":"                                              datetime.datetime)"},{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c8d7fb21","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":22},"in_reply_to":"3a71b18c_7499b978","updated":"2016-12-12 17:02:13.000000000","message":"Done","commit_id":"7772a81f6e1a0695da2bc5c480be4af97ebe6521"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"529467e06c647eb3ed8b167c5898c6ba88aac2bd","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027A string is required in field %(attr)s, \u0027"},{"line_number":264,"context_line":"                               \u0027not a %(type)s\u0027) %"},{"line_number":265,"context_line":"                             {\u0027attr\u0027: attr, \u0027type\u0027: type(value).__name__})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_90e7e53f","line":263,"range":{"start_line":263,"start_character":33,"end_line":263,"end_character":46},"updated":"2016-12-12 18:57:56.000000000","message":"The accepted type is more than string now, so shouldn\u0027t the message reflect that?","commit_id":"e7cbdadcd5709bc61fa8b7a06a259beca34604ba"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"30e972defa9b72c51f9fa8dc55458c794e36dead","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027A string is required in field %(attr)s, \u0027"},{"line_number":264,"context_line":"                               \u0027not a %(type)s\u0027) %"},{"line_number":265,"context_line":"                             {\u0027attr\u0027: attr, \u0027type\u0027: type(value).__name__})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_9b4a73c4","line":263,"range":{"start_line":263,"start_character":33,"end_line":263,"end_character":46},"in_reply_to":"1a6eadb0_90e7e53f","updated":"2016-12-13 17:24:36.000000000","message":"Done","commit_id":"e7cbdadcd5709bc61fa8b7a06a259beca34604ba"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b65b884769eccccf624973568ea543d04a63a128","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if isinstance(value, accepted_types):"},{"line_number":261,"context_line":"            return six.text_type(value)"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027One of %(accepted_type)s is required in field\u0027"},{"line_number":264,"context_line":"                               \u0027%(attr)s, not a %(type)s\u0027) %"},{"line_number":265,"context_line":"                             {\u0027accepted_type\u0027: accepted_types, \u0027attr\u0027: attr,"},{"line_number":266,"context_line":"                             \u0027type\u0027: type(value).__name__})"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @staticmethod"},{"line_number":269,"context_line":"    def stringify(value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_e9f8f44b","line":266,"range":{"start_line":263,"start_character":12,"end_line":266,"end_character":58},"updated":"2016-12-14 00:06:49.000000000","message":"This will display the following message:\n\n\"One of (\u003ctype \u0027int\u0027\u003e, \u003ctype \u0027long\u0027\u003e, \u003ctype \u0027float\u0027\u003e, (\u003ctype \u0027basestring\u0027\u003e,), \u003ctype \u0027datetime.datetime\u0027\u003e, \u003ctype \u0027list\u0027\u003e, \u003ctype \u0027dict\u0027\u003e) is required in field...\"\n\nI just noticed that six.string_types are added instead of extended to the list  Ideally the accepted_types should be declared like this:\n\naccepted_types \u003d six.integer_types + six.string_types + (float, datetime.datetime, list, dict)","commit_id":"7c5a3d7e13188f6e62f557e7e3227ba4c9dba85e"}]}
