)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d2b8c5acdbb6b8628f8db51477b47127c95e60a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julian Sy \u003cjulian.sy@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-11 19:57:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed JSONSchema Enum and IPV4AndV6Address"},{"line_number":8,"context_line":"Changed the schema from oneOf ipv4 and ipv6 pattern to ipv6 only because"},{"line_number":9,"context_line":"of validation issues. (ipv4 format is valid ipv6)"},{"line_number":10,"context_line":"Added None to the Enum values if it\u0027s nullable to be valid JSON Schema"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_2312a80a","line":7,"updated":"2017-05-31 15:06:48.000000000","message":"Please put a newline between the summary and the details of the commit message (otherwise git log concatenates the entire thing into a long line...)","commit_id":"63e32d6ff82d204aab7838121cdbf7bb2237794d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"feb104236c6b5a96a54df3ae33103ef6b442fbbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julian Sy \u003cjulian.sy@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-11 19:57:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed JSONSchema Enum and IPV4AndV6Address"},{"line_number":8,"context_line":"Changed the schema from oneOf ipv4 and ipv6 pattern to ipv6 only because"},{"line_number":9,"context_line":"of validation issues. (ipv4 format is valid ipv6)"},{"line_number":10,"context_line":"Added None to the Enum values if it\u0027s nullable to be valid JSON Schema"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_533385ab","line":7,"in_reply_to":"df140735_2312a80a","updated":"2017-06-06 15:40:18.000000000","message":"Done","commit_id":"63e32d6ff82d204aab7838121cdbf7bb2237794d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"400df987fe43a15bec974e14aee4b6deab3b56c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Added None to the Enum values if it\u0027s nullable to be valid JSON Schema"},{"line_number":12,"context_line":"Converted Enum values from tuple to list with unique items for JSON"},{"line_number":13,"context_line":"Schema generation."},{"line_number":14,"context_line":"Also moved the Enum JSONSchema tests to the Enum base class."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"implements bp json-schema-for-versioned-object"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f201791_2fd4ab1f","line":14,"updated":"2017-06-23 13:48:30.000000000","message":"This looks like four changes to me, none of which seem related AFAICT. Also, none of these say _why_ the changes should be made. Since these ultimately affect what goes over the wire, we have to be exceedingly careful not to change schema in incompatible ways.\n\nCan you please split these up and explain why each change is being made?","commit_id":"76aa602a9b76887a6ceac6017653118c79465bf6"}],"oslo_versionedobjects/fields.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4555a73e36c17c6b565dd7c518dd7464994a3e68","unresolved":false,"context_lines":[{"line_number":930,"context_line":"    def get_schema(self):"},{"line_number":931,"context_line":"        schema \u003d super(BaseEnumField, self).get_schema()"},{"line_number":932,"context_line":"        if self.nullable:"},{"line_number":933,"context_line":"            schema[\u0027enum\u0027].append(None)"},{"line_number":934,"context_line":"        return schema"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_5e62d9d9","line":933,"updated":"2017-01-12 09:53:20.000000000","message":"This looks strange but the commit message answered my concern.","commit_id":"63e32d6ff82d204aab7838121cdbf7bb2237794d"}]}
