)]}'
{"oslo_versionedobjects/fields.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a635d0629158b8a75f6c17bcef97022bec0ab9a3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# TODO(gyee): make sure to default timezone_aware to False in S release"},{"line_number":36,"context_line":"fields_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027timezone_aware\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027If True, any datetime objects returned will not contain \u0027"},{"line_number":39,"context_line":"                     \u0027meaningful timezone information. It is assumed that \u0027"},{"line_number":40,"context_line":"                     \u0027timezone is UTC and the application is responsible for \u0027"},{"line_number":41,"context_line":"                     \u0027canonicalizing the datetime objects before storing them \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_41291988","line":38,"updated":"2017-09-13 18:17:30.000000000","message":"this might be too long of a help message?   not sure what context this message is used.","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b59faa1a19622c3b107d9ff02396bb6ad2101037","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# TODO(gyee): make sure to default timezone_aware to False in S release"},{"line_number":36,"context_line":"fields_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027timezone_aware\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027If True, any datetime objects returned will not contain \u0027"},{"line_number":39,"context_line":"                     \u0027meaningful timezone information. It is assumed that \u0027"},{"line_number":40,"context_line":"                     \u0027timezone is UTC and the application is responsible for \u0027"},{"line_number":41,"context_line":"                     \u0027canonicalizing the datetime objects before storing them \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_7cf15ccd","line":38,"in_reply_to":"5f2577a7_41291988","updated":"2017-09-13 19:30:45.000000000","message":"For sure genconfig is making use of it. But there could be others like CLI perhaps? Here\u0027s what the [oslo_versionedobjects] section looks like in the generated nova.conf.sample if I include the olso.versionedobjects namespace in nova-config-generator.conf.\n\nhttp://paste.openstack.org/show/621069/","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b66fe74944cce82a3287fafa57b339dc7370b848","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# TODO(gyee): make sure to default timezone_aware to False in S release"},{"line_number":36,"context_line":"fields_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027timezone_aware\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027If True, any datetime objects returned will not contain \u0027"},{"line_number":39,"context_line":"                     \u0027meaningful timezone information. It is assumed that \u0027"},{"line_number":40,"context_line":"                     \u0027timezone is UTC and the application is responsible for \u0027"},{"line_number":41,"context_line":"                     \u0027canonicalizing the datetime objects before storing them \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_dfc89d56","line":38,"in_reply_to":"5f2577a7_41291988","updated":"2018-04-17 15:35:39.000000000","message":"I think this is fine.  Mostly the help message is for documentation and the sample config and there are much longer descriptions for other options.","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b66fe74944cce82a3287fafa57b339dc7370b848","unresolved":false,"context_lines":[{"line_number":36,"context_line":"fields_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027timezone_aware\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027If True, any datetime objects returned will not contain \u0027"},{"line_number":39,"context_line":"                     \u0027meaningful timezone information. It is assumed that \u0027"},{"line_number":40,"context_line":"                     \u0027timezone is UTC and the application is responsible for \u0027"},{"line_number":41,"context_line":"                     \u0027canonicalizing the datetime objects before storing them \u0027"},{"line_number":42,"context_line":"                     \u0027into the database. We strongly recommend application to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_7f07111e","line":39,"updated":"2018-04-17 15:35:39.000000000","message":"However, this description seems backwards.  If timezone_aware is set to True, then the objects will _not_ contain timezone information?","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b66fe74944cce82a3287fafa57b339dc7370b848","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    def __init__(self, tzinfo_aware\u003dTrue, *args, **kwargs):"},{"line_number":477,"context_line":"        # if timezone_aware is configured, it will have precedent over"},{"line_number":478,"context_line":"        # tzinfo_aware parameter."},{"line_number":479,"context_line":"        # FIXME(gyee): need a sane way to deprecate tzinfo_aware. Do we need"},{"line_number":480,"context_line":"        # to just doc it for now?"},{"line_number":481,"context_line":"        if CONF.oslo_versionedobjects.timezone_aware is not None:"},{"line_number":482,"context_line":"            self.tzinfo_aware \u003d CONF.oslo_versionedobjects.timezone_aware"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_dfd97d83","line":479,"updated":"2018-04-17 15:35:39.000000000","message":"debtcollector is our library for deprecating things like this.  See the removed_kwarg decorator in https://docs.openstack.org/debtcollector/queens/reference/index.html#module-debtcollector.removals","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b66fe74944cce82a3287fafa57b339dc7370b848","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        # tzinfo_aware parameter."},{"line_number":479,"context_line":"        # FIXME(gyee): need a sane way to deprecate tzinfo_aware. Do we need"},{"line_number":480,"context_line":"        # to just doc it for now?"},{"line_number":481,"context_line":"        if CONF.oslo_versionedobjects.timezone_aware is not None:"},{"line_number":482,"context_line":"            self.tzinfo_aware \u003d CONF.oslo_versionedobjects.timezone_aware"},{"line_number":483,"context_line":"        else:"},{"line_number":484,"context_line":"            self.tzinfo_aware \u003d tzinfo_aware"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_7f02b1b6","line":481,"range":{"start_line":481,"start_character":60,"end_line":481,"end_character":64},"updated":"2018-04-17 15:35:39.000000000","message":"I don\u0027t like this logic for a BoolOpt.  The Boolean type technically only allows True or False, although it appears to default to None, which seems wrong to me[1].  \n\nI think the correct thing to do here is to set the default to True explicitly and check for that instead.\n\n1: https://bugs.launchpad.net/oslo.config/+bug/1764782","commit_id":"e91948da689094b5073f7067ea632d4d1ae033cb"}]}
