)]}'
{"oslo_versionedobjects/fields.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"cf0dc7458b2596c9a7faa57384cb70be68625535","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"class List(CompoundFieldType):"},{"line_number":644,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":645,"context_line":"        if (not (isinstance(value, list) or hasattr(value, \u0027__iter__\u0027)) or"},{"line_number":646,"context_line":"           isinstance(value, six.string_types)):"},{"line_number":647,"context_line":"            raise ValueError(_(\u0027A list is required in field %(attr)s, \u0027"},{"line_number":648,"context_line":"                               \u0027not a %(type)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_df6e952a","line":645,"range":{"start_line":645,"start_character":44,"end_line":645,"end_character":70},"updated":"2019-02-18 07:08:41.000000000","message":"Would isinstance(value, collections.Iterable) not work?\n\nThis will allow dicts as well... that seems undesirable?\n\nI\u0027d suggest:\n\n  not isinstance(value, collections.Iterable) or isinstance(value, six.string_types + (collections.Mapping,))","commit_id":"48a9263640b32532b623b3a75c764420d773d880"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0cfc01ed79b66309a4167d0b0a480fa1e90ee515","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"class List(CompoundFieldType):"},{"line_number":644,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":645,"context_line":"        if (not (isinstance(value, list) or hasattr(value, \u0027__iter__\u0027)) or"},{"line_number":646,"context_line":"           isinstance(value, six.string_types)):"},{"line_number":647,"context_line":"            raise ValueError(_(\u0027A list is required in field %(attr)s, \u0027"},{"line_number":648,"context_line":"                               \u0027not a %(type)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_35ba586e","line":645,"range":{"start_line":645,"start_character":44,"end_line":645,"end_character":70},"in_reply_to":"9fdfeff1_df6e952a","updated":"2019-02-18 16:51:54.000000000","message":"Good idea, done.","commit_id":"48a9263640b32532b623b3a75c764420d773d880"}]}
