)]}'
{"id":"openstack%2Foslo.versionedobjects~979071","triplet_id":"openstack%2Foslo.versionedobjects~master~I3375b875bd1a14c5ea06d9d752de7397ed30fb40","project":"openstack/oslo.versionedobjects","branch":"master","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2026-03-19 11:46:20.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2026-03-19 06:53:10.000000000","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change","reason_account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}}},"hashtags":[],"change_id":"I3375b875bd1a14c5ea06d9d752de7397ed30fb40","subject":"fields: Remove use of staticmethod","status":"MERGED","created":"2026-03-05 20:24:49.000000000","updated":"2026-03-19 13:47:51.000000000","submitted":"2026-03-19 13:46:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"979071-typing","meta_rev_id":"51032e2c42f93f8b1ec68c6dc4ead394a5a37ce3","_number":979071,"virtual_id_number":979071,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-03-19 13:46:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2026-03-19 06:53:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-03-19 11:46:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-05 22:07:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-07 07:30:49.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"}],"messages":[{"id":"7c1338e61775a9730538cfb94a6c83e4dd998f5f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-05 20:24:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e226f0313806148cbe9a2076727d802551ef041","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-05 22:07:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/274f32591eff44cc8b707a6f3d7f41f2\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5bea58a18b804b81a9156f4a60c1bd95 : SUCCESS in 1h 39m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/02a1c65e31f24fed8bc71ce66a2ea2ec : SUCCESS in 3m 20s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/99f20c1e762c4da2b8804b2caa89ddc8 : SUCCESS in 3m 38s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0c3be37080fa49e3942c74b13cc9c4fd : SUCCESS in 3m 55s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/e1d3e841465b484cadff6afaba81d1a3 : SUCCESS in 6m 20s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b0fbc99a02e4b588a6dfa0cc5b42056 : SUCCESS in 3m 42s\n- oslo.versionedobjects-src-grenade-multinode https://zuul.opendev.org/t/openstack/build/a2c334baec1b410c8e075b89e5d951e7 : SUCCESS in 1h 04m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cc435d75b0be6ea30e672ecc6ec276df41452976","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-06 13:41:43.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"d3f12ecb6311d8d33b3832afbca8c3fd963e7f1d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-06 15:22:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/15984de3322b4e9590dd727d84236323\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/57b8726992334de69d70a28234271ead : SUCCESS in 1h 32m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4bd2e3472f294e21ae4d9876dff42e9c : SUCCESS in 2m 49s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/0949088f6eae40fea172d99521c0a7c8 : SUCCESS in 3m 19s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/e6bef96f7d194fdda97ce87535f06093 : SUCCESS in 3m 02s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/88082ee400c74c9c80f10019efbfefa4 : SUCCESS in 6m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/99ce3f551c10406aab2af4c19a78cf0f : SUCCESS in 3m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c5d153063f5b428387d08e6490d2315b : SUCCESS in 4m 16s\n- oslo.versionedobjects-src-grenade-multinode https://zuul.opendev.org/t/openstack/build/fad17d0e3e214a71914934fe70cd5b6f : SUCCESS in 1h 13m 22s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9df364b6a18795b15a8684e5047859a99f2631a3","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2026-03-07 07:30:49.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6d01f344879d5190356d8e99d857e4ba9130376f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-09 14:02:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"da3fc0c4b3f75e842c7c34386a2c98ad9b471860","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-09 14:04:46.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"c409e3e0c3d7131bed6e18681ba6d052a84206f1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-09 15:26:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/09f5419d19284bf6a0301417baace6dc\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f349de4067ab40c79cd24d0650c293e4 : SUCCESS in 1h 20m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef85db5e12c5472b97da3044b6fb0552 : SUCCESS in 2m 52s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4f234390997a4ca3b86a49635e43f4cc : SUCCESS in 3m 47s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/22f213e10c3c47b7945f91284e443e74 : SUCCESS in 3m 35s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/c9395dd94f72416e9835104c047d538f : SUCCESS in 8m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a7b1d2a5fe049cea3329212dfcaf9f3 : SUCCESS in 3m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/45e61d9a22594461bbf7b0a2f42405f1 : SUCCESS in 2m 16s\n- oslo.versionedobjects-src-grenade-multinode https://zuul.opendev.org/t/openstack/build/a15c77e304814cd08f867bfc677155b1 : SUCCESS in 35m 09s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5935471d68cb9a326f9ef974de80dfc43955d50a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2026-03-19 06:53:10.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"09734a5bc217130679fbf248be1ed4f622721926","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-19 11:46:20.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"1ca8ebcaf2cfa8ed890aed0eeae89d2b45db10fb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-19 11:46:43.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"227d94cb64febfd3f641b07779bc247481a826a5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-19 13:46:43.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fb250a607c6d4cbda88cf6e4fb3aa48d\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/021d26195d7d4fe684639932635479bb : SUCCESS in 1h 54m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf52d2a94bad45bb98df83cafcb155f6 : SUCCESS in 3m 08s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b9cb36aa99124b008a5342593b7ab017 : SUCCESS in 3m 14s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/ccc1a25b637344f283f6f90113817eb3 : SUCCESS in 3m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5e3f48f119ef4881a90e580dfc202ec6 : SUCCESS in 4m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9770099bee7844c7ad106b867a40fd6b : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":3},{"id":"0875d79c67881104b9127ceca91b3cd0af50e2aa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-19 13:46:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"51032e2c42f93f8b1ec68c6dc4ead394a5a37ce3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-19 13:47:51.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4799b56119c64f7d8bb127d33f774023\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca9adc2e9e4d4d88a3b280d3239654ad : SUCCESS in 54s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/25e2672e669f4e2f9f292d4860c9e553 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ca43e8134cb4ce6d9c5a90917203bc56924405d5","revisions":{"bca09d63e25c8a9e3f1039393fad21cf9b57b74a":{"kind":"REWORK","_number":1,"created":"2026-03-05 20:24:49.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/71/979071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/71/979071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/1"}}},"commit":{"parents":[{"commit":"832daf095d5e9b7ea5389961ec532bab173e41f0","subject":"tests: Fix tz-naive test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/832daf095d5e9b7ea5389961ec532bab173e41f0"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-02-18 12:47:36.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-05 20:03:27.000000000","tz":0},"subject":"fields: Remove use of staticmethod","message":"fields: Remove use of staticmethod\n\nWhile the affected methods are clearly not reliant on instance\nattributes, mypy does not like us marking subclass methods as static\nwhen the superclass method is not. Additionally, the container methods\n(whether that\u0027s a CompoundField subclass or an Object subclass) all\nexpect to work with instances of the Field. We can therefore remove the\nuse of staticmethod.\n\nNote that we had tests that were testing behavior of the affected\nfunctions. This wouldn\u0027t happen at runtime (since parent Object\ninstances will always create instances of fields) but we add a runtime\ncheck just in case someone had hacked around this or was otherwise\ndepending on the staticmethod behavior.\n\nChange-Id: I3375b875bd1a14c5ea06d9d752de7397ed30fb40\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/bca09d63e25c8a9e3f1039393fad21cf9b57b74a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/bca09d63e25c8a9e3f1039393fad21cf9b57b74a"}]},"branch":"refs/heads/master"},"c4a6a84bce3e98adaa987c1dd7021e2e0f9f2b19":{"kind":"REWORK","_number":2,"created":"2026-03-06 13:41:43.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/71/979071/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/71/979071/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/2"}}},"commit":{"parents":[{"commit":"832daf095d5e9b7ea5389961ec532bab173e41f0","subject":"tests: Fix tz-naive test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/832daf095d5e9b7ea5389961ec532bab173e41f0"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-02-18 12:47:36.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-06 13:40:48.000000000","tz":0},"subject":"fields: Remove use of staticmethod","message":"fields: Remove use of staticmethod\n\nWhile the affected methods are clearly not reliant on instance\nattributes, mypy does not like us marking subclass methods as static\nwhen the superclass method is not. Additionally, the container methods\n(whether that\u0027s a CompoundField subclass or an Object subclass) all\nexpect to work with instances of the Field. We can therefore remove the\nuse of staticmethod.\n\nNote that we had tests that were testing behavior of the affected\nfunctions. This wouldn\u0027t happen at runtime (since parent Object\ninstances will always create instances of fields) but we add a runtime\ncheck just in case someone had hacked around this or was otherwise\ndepending on the staticmethod behavior.\n\nChange-Id: I3375b875bd1a14c5ea06d9d752de7397ed30fb40\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/c4a6a84bce3e98adaa987c1dd7021e2e0f9f2b19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/c4a6a84bce3e98adaa987c1dd7021e2e0f9f2b19"}]},"branch":"refs/heads/master"},"ca43e8134cb4ce6d9c5a90917203bc56924405d5":{"kind":"REWORK","_number":3,"created":"2026-03-09 14:04:46.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/71/979071/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/71/979071/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/71/979071/3"}}},"commit":{"parents":[{"commit":"832daf095d5e9b7ea5389961ec532bab173e41f0","subject":"tests: Fix tz-naive test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/832daf095d5e9b7ea5389961ec532bab173e41f0"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-02-18 12:47:36.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-09 14:01:44.000000000","tz":0},"subject":"fields: Remove use of staticmethod","message":"fields: Remove use of staticmethod\n\nWhile the affected methods are clearly not reliant on instance\nattributes, mypy does not like us marking subclass methods as static\nwhen the superclass method is not. Additionally, the container methods\n(whether that\u0027s a CompoundField subclass or an Object subclass) all\nexpect to work with instances of the Field. We can therefore remove the\nuse of staticmethod.\n\nNote that we had tests that were testing behavior of the affected\nfunctions. This wouldn\u0027t happen at runtime (since parent Object\ninstances will always create instances of fields) but we add a runtime\ncheck just in case someone had hacked around this or was otherwise\ndepending on the staticmethod behavior.\n\nChange-Id: I3375b875bd1a14c5ea06d9d752de7397ed30fb40\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/ca43e8134cb4ce6d9c5a90917203bc56924405d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/ca43e8134cb4ce6d9c5a90917203bc56924405d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}