)]}'
{"oslo/vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4c5c7254f01a31d40295a7d62c4b8172264570c8","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # the username parameter to be exactly same as that in the session"},{"line_number":215,"context_line":"        # object. We can\u0027t use the username used for login since the Login"},{"line_number":216,"context_line":"        # method ignores the case."},{"line_number":217,"context_line":"        self._session_username \u003d session.userName"},{"line_number":218,"context_line":"        LOG.info(_(\"Successfully established new session; session ID is %s.\"),"},{"line_number":219,"context_line":"                 self._session_id)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1747a378","line":217,"updated":"2014-06-24 05:55:21.000000000","message":"What about LOG.info?","commit_id":"b1c1f4b6edd446f143ad742cb4f338cd1b48ef9e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ef992eb381a5288c5f56637bdc3b2d04f4a6b736","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # the username parameter to be exactly same as that in the session"},{"line_number":215,"context_line":"        # object. We can\u0027t use the username used for login since the Login"},{"line_number":216,"context_line":"        # method ignores the case."},{"line_number":217,"context_line":"        self._session_username \u003d session.userName"},{"line_number":218,"context_line":"        LOG.info(_(\"Successfully established new session; session ID is %s.\"),"},{"line_number":219,"context_line":"                 self._session_id)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ba340fe0","line":217,"in_reply_to":"1ae5cdf2_1747a378","updated":"2014-06-24 08:39:35.000000000","message":"Done","commit_id":"b1c1f4b6edd446f143ad742cb4f338cd1b48ef9e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cffd6469c9912f19c93fbbc3b1499cb8eab53794","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    else:"},{"line_number":307,"context_line":"                        # empty response is due to an inactive session"},{"line_number":308,"context_line":"                        excep_msg \u003d ("},{"line_number":309,"context_line":"                            _LW(\"Current session: %(session)s is inactive; \""},{"line_number":310,"context_line":"                                \"re-creating the session while invoking \""},{"line_number":311,"context_line":"                                \"method %(module)s.%(method)s.\") %"},{"line_number":312,"context_line":"                            {\u0027session\u0027: self._session_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_96beccd2","line":309,"updated":"2014-06-27 06:40:48.000000000","message":"Please undo this change as this message is user facing and should be translated.\n\nPlease follow this for messages which are logged and going to appear in an exception.\n\n\nmsg \u003d _(\"error message\")\n\nLOG.error(msg)\n\nraise Exception(msg)","commit_id":"74716d60897154d4819f542c44ad4a448bc48700"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b1058447351414ecaaa1481119214f654c793dc5","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                             \u0027method\u0027: method})"},{"line_number":315,"context_line":"                        LOG.warn(excep_msg, exc_info\u003dTrue)"},{"line_number":316,"context_line":"                        self._create_session()"},{"line_number":317,"context_line":"                        excep_msg \u003d ("},{"line_number":318,"context_line":"                            _(\"Current session: %(session)s is inactive; \""},{"line_number":319,"context_line":"                              \"re-creating the session while invoking \""},{"line_number":320,"context_line":"                              \"method %(module)s.%(method)s.\") %"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_42869d17","line":317,"updated":"2014-06-25 05:43:47.000000000","message":"Duplicate message?","commit_id":"74716d60897154d4819f542c44ad4a448bc48700"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b19a54edba715856cb7513bbedd7bdd73ac6c036","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                             \u0027method\u0027: method})"},{"line_number":315,"context_line":"                        LOG.warn(excep_msg, exc_info\u003dTrue)"},{"line_number":316,"context_line":"                        self._create_session()"},{"line_number":317,"context_line":"                        excep_msg \u003d ("},{"line_number":318,"context_line":"                            _(\"Current session: %(session)s is inactive; \""},{"line_number":319,"context_line":"                              \"re-creating the session while invoking \""},{"line_number":320,"context_line":"                              \"method %(module)s.%(method)s.\") %"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f1192cd2","line":317,"in_reply_to":"1ae5cdf2_42869d17","updated":"2014-06-25 11:14:26.000000000","message":"fir the one we use log message we need to use _LW() and for the exception we need to use _()\nI am not sure of any other way of doing this.","commit_id":"74716d60897154d4819f542c44ad4a448bc48700"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b1058447351414ecaaa1481119214f654c793dc5","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                                \"%(error_msg)s.\") % {\u0027lease\u0027: lease,"},{"line_number":475,"context_line":"                                                     \u0027error_msg\u0027: error_msg}"},{"line_number":476,"context_line":"                LOG.error(excep_msg)"},{"line_number":477,"context_line":"                excep_msg \u003d _(\"Lease: %(lease)s is in error state. Details: \""},{"line_number":478,"context_line":"                              \"%(error_msg)s.\") % {\u0027lease\u0027: lease,"},{"line_number":479,"context_line":"                                                   \u0027error_msg\u0027: error_msg}"},{"line_number":480,"context_line":"                raise exceptions.VimException(excep_msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_22a6f1ab","line":477,"updated":"2014-06-25 05:43:47.000000000","message":"Duplicate?","commit_id":"74716d60897154d4819f542c44ad4a448bc48700"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b19a54edba715856cb7513bbedd7bdd73ac6c036","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                                \"%(error_msg)s.\") % {\u0027lease\u0027: lease,"},{"line_number":475,"context_line":"                                                     \u0027error_msg\u0027: error_msg}"},{"line_number":476,"context_line":"                LOG.error(excep_msg)"},{"line_number":477,"context_line":"                excep_msg \u003d _(\"Lease: %(lease)s is in error state. Details: \""},{"line_number":478,"context_line":"                              \"%(error_msg)s.\") % {\u0027lease\u0027: lease,"},{"line_number":479,"context_line":"                                                   \u0027error_msg\u0027: error_msg}"},{"line_number":480,"context_line":"                raise exceptions.VimException(excep_msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_117858f7","line":477,"in_reply_to":"1ae5cdf2_22a6f1ab","updated":"2014-06-25 11:14:26.000000000","message":"same as above","commit_id":"74716d60897154d4819f542c44ad4a448bc48700"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"cc68ff263edc8385075a2acefa131f39ad419b52","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_27ff2f36","line":32,"updated":"2014-07-01 06:36:14.000000000","message":"we might prefer importing modules:\n\nfrom glance.openstack.common import gettextutils\n\n_LE \u003d gettextutils._LE\netc.","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0e68da68974aadec1626e3e6bcaaecc169d2513e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_2a9376a4","line":32,"in_reply_to":"baada198_27ff2f36","updated":"2014-07-01 06:51:24.000000000","message":"that is a good idea. i would prefer to do it in a patch above this one as we should have the same handling for _, _LE, _LI etc.\nwhat do you think?","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a75fe3f52a5f0f27c884a2aca613d777fc1af5f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_804aa181","line":32,"in_reply_to":"baada198_2a9376a4","updated":"2014-07-01 08:04:14.000000000","message":"I don\u0027t think we have to do this.\nThis module is one of the exceptions listed under Import Guidelines.","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"bb275b2401d866baa24e3c2ede07ee6c2de8b92f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_6abbae0e","line":32,"in_reply_to":"baada198_2a9376a4","updated":"2014-07-01 06:53:29.000000000","message":"deal","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"682c0884c55aceaaeec745ec846a5b483c2abb9f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_dbaacad3","line":32,"in_reply_to":"baada198_804aa181","updated":"2014-07-01 08:07:58.000000000","message":"in this case, I would say \n\nfrom oslo.vmware.openstack.common.gettextutils  import _LE, _LI, _LW","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f118d7898f6011ff3a451b80dfcdd37d78550844","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo.vmware import exceptions"},{"line_number":30,"context_line":"from oslo.vmware.openstack.common import excutils"},{"line_number":31,"context_line":"from oslo.vmware.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LE"},{"line_number":33,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LI"},{"line_number":34,"context_line":"from oslo.vmware.openstack.common.gettextutils import _LW"},{"line_number":35,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b66e0bc8","line":32,"in_reply_to":"baada198_dbaacad3","updated":"2014-07-01 08:29:51.000000000","message":"Done","commit_id":"5e083183c5789b54f2dfa609ebcac958c66d90fe"}],"oslo/vmware/openstack/common/__init__.py":[{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"ecc2e7ffb70a3bf65859f544c9d70b8f99588eab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import six"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_21b7fb87","line":17,"updated":"2014-07-01 20:52:52.000000000","message":"why do we need this?","commit_id":"5ef9f2918c6590cc64bc9464b6e40deff8a9f867"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c91d1754df2ede536e586df870c861f973f30b6b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import six"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_9afa7ebb","line":17,"in_reply_to":"baada198_21b7fb87","updated":"2014-07-04 09:49:21.000000000","message":"this is code that was imported by the openstack comment. that is,it was pulled in when we updated the oslo/vmware/openstack/common/gettextutils.py","commit_id":"5ef9f2918c6590cc64bc9464b6e40deff8a9f867"}],"oslo/vmware/rw_handles.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"96a59c24ff5394fecebde2dc921b4ffe377af63a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not url:"},{"line_number":145,"context_line":"            excep_msg \u003d _LE(\"Could not retrieve VMDK URL from lease info.\")"},{"line_number":146,"context_line":"            LOG.error(excep_msg)"},{"line_number":147,"context_line":"            excep_msg \u003d _(\"Could not retrieve VMDK URL from lease info.\")"},{"line_number":148,"context_line":"            raise exceptions.VimException(excep_msg)"},{"line_number":149,"context_line":"        LOG.debug(\"Found VMDK URL: %s from lease info.\", url)"},{"line_number":150,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_5ea99f7a","line":147,"updated":"2014-06-27 21:04:19.000000000","message":"This approach places the same message in both catalogs, which doesn\u0027t really buy us much in translator effort. You can just use _() in this case, since the message is logged and used in an exception. That applies to other cases in this file where the same message is repeated, as well.","commit_id":"adc50529401d64618f612bf2aa2d17c98fc2d2fd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c6f3a471af5b005b8cb736ed08faf0469d2c6d2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not url:"},{"line_number":145,"context_line":"            excep_msg \u003d _LE(\"Could not retrieve VMDK URL from lease info.\")"},{"line_number":146,"context_line":"            LOG.error(excep_msg)"},{"line_number":147,"context_line":"            excep_msg \u003d _(\"Could not retrieve VMDK URL from lease info.\")"},{"line_number":148,"context_line":"            raise exceptions.VimException(excep_msg)"},{"line_number":149,"context_line":"        LOG.debug(\"Found VMDK URL: %s from lease info.\", url)"},{"line_number":150,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_327cff1f","line":147,"in_reply_to":"1ae5cdf2_5ea99f7a","updated":"2014-06-28 07:32:14.000000000","message":"Good catch. my bad.","commit_id":"adc50529401d64618f612bf2aa2d17c98fc2d2fd"}]}