)]}'
{"oslo/vmware/api.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"58821760e48750d49861930485a8ab499a1556f0","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._vim \u003d vim.Vim(protocol\u003dself._scheme,"},{"line_number":181,"context_line":"                                host\u003dself._host,"},{"line_number":182,"context_line":"                                port\u003dself._port,"},{"line_number":183,"context_line":"                                wsdl_url\u003dself._vim_wsdl_loc)"},{"line_number":184,"context_line":"        return self._vim"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b9b78620","line":183,"updated":"2014-06-25 13:42:24.000000000","message":"Incompatible change to Vim.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"}],"oslo/vmware/pbm.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cb529ee6078a4c48695017130aae47b9c6c984e1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2a4d41c5","line":49,"updated":"2014-07-08 17:17:40.000000000","message":"I think we are prefixing _ for instance variables.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4d9275e8ad03ba382cea55bf2c8242dfc7f6402b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a5c6c514","line":49,"in_reply_to":"baada198_2a4d41c5","updated":"2014-07-09 12:57:59.000000000","message":"This is a public property and I prefer using this instead of having a property method which simply does \"return self._wsdl_url\"","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8be7c18c07c66645c900d90c1a816e7995006d2c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_9c3c89c1","line":49,"in_reply_to":"baada198_69b007f5","updated":"2014-07-10 14:46:15.000000000","message":"OK, I have deleted line 49","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3cb97c5a075beb84101e8e4c485387bc23ffac1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_69b007f5","line":49,"in_reply_to":"baada198_a5c6c514","updated":"2014-07-09 14:12:39.000000000","message":"Then why can\u0027t we use the one in Service? You are passing this in the constructor.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cb529ee6078a4c48695017130aae47b9c6c984e1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2a92a1f6","line":51,"updated":"2014-07-08 17:17:40.000000000","message":"What about logging the WSDL URL?","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4d9275e8ad03ba382cea55bf2c8242dfc7f6402b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a5624514","line":51,"in_reply_to":"baada198_2a92a1f6","updated":"2014-07-09 12:57:59.000000000","message":"I think this should be done by the caller","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3cb97c5a075beb84101e8e4c485387bc23ffac1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a9cdbf5f","line":51,"in_reply_to":"baada198_a5624514","updated":"2014-07-09 14:12:39.000000000","message":"Sorry I meant SOAP URL which is constructed here and client may not be able to log it if SOAP client creation fails.\nAlso for Vim, the WSDL may not be passed in the constructor.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8be7c18c07c66645c900d90c1a816e7995006d2c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":49,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":50,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_dcb44137","line":51,"in_reply_to":"baada198_a9cdbf5f","updated":"2014-07-10 14:46:15.000000000","message":"I have added a log statement in the constructor of Service","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cb529ee6078a4c48695017130aae47b9c6c984e1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param cookie: cookie to set"},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2aa9c124","line":54,"updated":"2014-07-08 17:17:40.000000000","message":"vCenter session?","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4d9275e8ad03ba382cea55bf2c8242dfc7f6402b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(Pbm, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_soap_cookie(self, cookie):"},{"line_number":54,"context_line":"        \"\"\"Set the specified vCenter cookie in the SOAP header"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param cookie: cookie to set"},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_e56c3d0b","line":54,"in_reply_to":"baada198_2aa9c124","updated":"2014-07-09 12:57:59.000000000","message":"Done","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1cdb6157cc0f9977b617083f372b270907b5e6e5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":48,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":49,"context_line":"        super(Pbm, self).__init__(wsdl_url, self.soap_url)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def set_soap_cookie(self, cookie):"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5683a803","line":48,"updated":"2014-07-10 16:46:43.000000000","message":"we have soap_url in Service.","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e7a11cb2fcc4e9ee935076d5c9ab62a8fc94b87d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        :param wsdl_url: PBM WSDL url"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":48,"context_line":"        self.soap_url \u003d base_url + \u0027/pbm\u0027"},{"line_number":49,"context_line":"        super(Pbm, self).__init__(wsdl_url, self.soap_url)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def set_soap_cookie(self, cookie):"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_a8e3abd7","line":48,"in_reply_to":"baada198_5683a803","updated":"2014-07-11 07:25:27.000000000","message":"Done","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"}],"oslo/vmware/service.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"58821760e48750d49861930485a8ab499a1556f0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return proto_str + host_str + port_str"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @staticmethod"},{"line_number":90,"context_line":"    def _retrieve_properties_ex_fault_checker(response):"},{"line_number":91,"context_line":"        \"\"\"Checks the RetrievePropertiesEx API response for errors."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Certain faults are sent in the SOAP body as a property of missingSet."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_96561929","line":90,"updated":"2014-06-25 13:42:24.000000000","message":"This should be in Vim, not Service. It has nothing to do with PBM, for eg.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"a15ea5379c1b38750014865e0bc8fc50f684851b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return proto_str + host_str + port_str"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @staticmethod"},{"line_number":90,"context_line":"    def _retrieve_properties_ex_fault_checker(response):"},{"line_number":91,"context_line":"        \"\"\"Checks the RetrievePropertiesEx API response for errors."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Certain faults are sent in the SOAP body as a property of missingSet."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ef24e0b3","line":90,"in_reply_to":"1ae5cdf2_96561929","updated":"2014-06-25 14:29:10.000000000","message":"I will put a TODO and will address this in a subsequent patch if you don\u0027t mind","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"9a63bd0f0219cfa63d54781df426ff599416c609","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            LOG.error(_(\"Faults %s found in RetrievePropertiesEx API \""},{"line_number":122,"context_line":"                        \"response.\"),"},{"line_number":123,"context_line":"                      fault_list)"},{"line_number":124,"context_line":"            raise exceptions.VimFaultException(fault_list,"},{"line_number":125,"context_line":"                                               _(\"Error occurred while calling\""},{"line_number":126,"context_line":"                                                 \" RetrievePropertiesEx.\"))"},{"line_number":127,"context_line":"        LOG.debug(\"No faults found in RetrievePropertiesEx API response.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_038acd19","line":124,"updated":"2014-06-25 12:30:43.000000000","message":"What about Vim* exceptions? PBM throws instances of PbmFault sub-types.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e6492b32802c55781cf7d33a649d39e055ec4622","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            LOG.error(_(\"Faults %s found in RetrievePropertiesEx API \""},{"line_number":122,"context_line":"                        \"response.\"),"},{"line_number":123,"context_line":"                      fault_list)"},{"line_number":124,"context_line":"            raise exceptions.VimFaultException(fault_list,"},{"line_number":125,"context_line":"                                               _(\"Error occurred while calling\""},{"line_number":126,"context_line":"                                                 \" RetrievePropertiesEx.\"))"},{"line_number":127,"context_line":"        LOG.debug(\"No faults found in RetrievePropertiesEx API response.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e3ec0195","line":124,"in_reply_to":"1ae5cdf2_038acd19","updated":"2014-06-25 12:38:16.000000000","message":"That is correct but I suggest to fix this in another patch. That would be too much changes for one patch.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8692223b46847a768ae6c3b2fc9d4059d7a2419d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        fault_type \u003d missing_elem.fault.fault.__class__"},{"line_number":124,"context_line":"                        fault_list.append(fault_type.__name__)"},{"line_number":125,"context_line":"        if fault_list:"},{"line_number":126,"context_line":"            LOG.error(_(\"Faults %s found in RetrievePropertiesEx API \""},{"line_number":127,"context_line":"                        \"response.\"),"},{"line_number":128,"context_line":"                      fault_list)"},{"line_number":129,"context_line":"            raise exceptions.VimFaultException(fault_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c82cbb4d","line":126,"updated":"2014-07-01 10:34:56.000000000","message":"can you please use the hint _LE here","commit_id":"971c7dc1c0ebdb588c447052f8c50178104ed2b1"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"b4590d336828e808eee3a66e162c31f2b4971ec4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        fault_type \u003d missing_elem.fault.fault.__class__"},{"line_number":124,"context_line":"                        fault_list.append(fault_type.__name__)"},{"line_number":125,"context_line":"        if fault_list:"},{"line_number":126,"context_line":"            LOG.error(_(\"Faults %s found in RetrievePropertiesEx API \""},{"line_number":127,"context_line":"                        \"response.\"),"},{"line_number":128,"context_line":"                      fault_list)"},{"line_number":129,"context_line":"            raise exceptions.VimFaultException(fault_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_db9a9c62","line":126,"in_reply_to":"baada198_c82cbb4d","updated":"2014-07-02 08:18:32.000000000","message":"Done","commit_id":"971c7dc1c0ebdb588c447052f8c50178104ed2b1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7d4fd92e2d1da66d842aafdc196c877b8595283","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import httplib"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"import urllib2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b6c2e850","line":22,"updated":"2014-07-06 05:07:31.000000000","message":"netaddr is a third party import","commit_id":"8a87ab9f0b87910beaa7cce8ea0115448e55aabf"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"6e0c97a61f2340409b5a0c5a40b8267235b64173","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import httplib"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"import urllib2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_994a7753","line":22,"in_reply_to":"baada198_b6c2e850","updated":"2014-07-06 08:15:35.000000000","message":"Done","commit_id":"8a87ab9f0b87910beaa7cce8ea0115448e55aabf"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cb529ee6078a4c48695017130aae47b9c6c984e1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_cd5bff2c","line":241,"updated":"2014-07-08 17:17:40.000000000","message":"May be we should have this in specific services as well. It can also print the relevant URLs.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"de27594c8c26599d87fb8beab6bd7122601ead56","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_62eb8eb0","line":241,"in_reply_to":"baada198_1f64eb47","updated":"2014-07-10 15:30:46.000000000","message":"Done","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8be7c18c07c66645c900d90c1a816e7995006d2c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_dc8b6166","line":241,"in_reply_to":"baada198_c94833cf","updated":"2014-07-10 14:46:15.000000000","message":"Because it is not correct to return \"VIM Object\" for Pbm","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4d9275e8ad03ba382cea55bf2c8242dfc7f6402b","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_e5119d5e","line":241,"in_reply_to":"baada198_cd5bff2c","updated":"2014-07-09 12:57:59.000000000","message":"Sure, but let\u0027s do that in a subsequent patch. I prefer not adding features as part of the refactoring.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5a614b5dac079427a58d369df9f803742face9f1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_1f64eb47","line":241,"in_reply_to":"baada198_dc8b6166","updated":"2014-07-10 15:14:07.000000000","message":"I think I was not clear enough.\nMy point is, vim objects should print \"VIM Object\" after refactoring which is not the case now. That is why I suggested to override this in specific services in my first comment.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3cb97c5a075beb84101e8e4c485387bc23ffac1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def __repr__(self):"},{"line_number":239,"context_line":"        return \"vSphere Service\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __str__(self):"},{"line_number":242,"context_line":"        return \"vSphere Service\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_c94833cf","line":241,"in_reply_to":"baada198_e5119d5e","updated":"2014-07-09 14:12:39.000000000","message":"Earlier vim objects had a string representation \"VIM Object\" and why do you want to change that as part of refactoring?","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"e8b0d5bf2711f30286ef2b683b875620fc930420","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._service_content \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @staticmethod"},{"line_number":88,"context_line":"    def build_url(protocol, host, port):"},{"line_number":89,"context_line":"        proto_str \u003d \u0027%s://\u0027 % protocol"},{"line_number":90,"context_line":"        host_str \u003d \u0027[%s]\u0027 % host if netaddr.valid_ipv6(host) else host"},{"line_number":91,"context_line":"        port_str \u003d \u0027\u0027 if port is None else \u0027:%d\u0027 % port"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_48969995","line":88,"updated":"2014-07-10 23:37:35.000000000","message":"Nit: (feel free to ignore) should you need to respin, consider renaming this build_base_url or get_base_url or build_url_prefix, since the current name gives a wrong impression that we are building the full url","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e7a11cb2fcc4e9ee935076d5c9ab62a8fc94b87d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._service_content \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @staticmethod"},{"line_number":88,"context_line":"    def build_url(protocol, host, port):"},{"line_number":89,"context_line":"        proto_str \u003d \u0027%s://\u0027 % protocol"},{"line_number":90,"context_line":"        host_str \u003d \u0027[%s]\u0027 % host if netaddr.valid_ipv6(host) else host"},{"line_number":91,"context_line":"        port_str \u003d \u0027\u0027 if port is None else \u0027:%d\u0027 % port"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_88dee70f","line":88,"in_reply_to":"baada198_48969995","updated":"2014-07-11 07:25:27.000000000","message":"Done","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"}],"oslo/vmware/vim.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"58821760e48750d49861930485a8ab499a1556f0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return self._service_content"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def client(self):"},{"line_number":116,"context_line":"        return self._client"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_79d41ebb","side":"PARENT","line":115,"updated":"2014-06-25 13:42:24.000000000","message":"This property is used by glance, and isn\u0027t in Service.","commit_id":"df06729fdb01520b58bded87630aa891c9d16d80"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"58821760e48750d49861930485a8ab499a1556f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Service class that provides access to the VIM API.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __init__(self, protocol\u003d\u0027https\u0027, host\u003d\u0027localhost\u0027, port\u003dNone,"},{"line_number":23,"context_line":"                 wsdl_url\u003dNone):"},{"line_number":24,"context_line":"        \"\"\"Constructs a VIM service client object."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param protocol: http or https"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3928d632","line":23,"updated":"2014-06-25 13:42:24.000000000","message":"This is an incompatible change to Vim which will break glance.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"58821760e48750d49861930485a8ab499a1556f0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":38,"context_line":"        super(Vim, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def retrieve_service_content(self):"},{"line_number":41,"context_line":"        return self.RetrieveServiceContent(\u0027ServiceInstance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d961b212","line":40,"updated":"2014-06-25 13:42:24.000000000","message":"Need session retry.","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"a15ea5379c1b38750014865e0bc8fc50f684851b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.wsdl_url \u003d wsdl_url"},{"line_number":38,"context_line":"        super(Vim, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def retrieve_service_content(self):"},{"line_number":41,"context_line":"        return self.RetrieveServiceContent(\u0027ServiceInstance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0abc9ada","line":40,"in_reply_to":"1ae5cdf2_d961b212","updated":"2014-06-25 14:29:10.000000000","message":"this is just to specialize the retrieval of ServiceContent because it is different for Vim and Pbm","commit_id":"5efbd821d74fe08db709e44abaa97b269817f737"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cb529ee6078a4c48695017130aae47b9c6c984e1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(Vim, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def retrieve_service_content(self):"},{"line_number":41,"context_line":"        return self.RetrieveServiceContent(\u0027ServiceInstance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0a087d2c","line":41,"updated":"2014-07-08 17:17:40.000000000","message":"In Pbm we have a named constant for this literal.","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"4d9275e8ad03ba382cea55bf2c8242dfc7f6402b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(Vim, self).__init__(self.wsdl_url, self.soap_url)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def retrieve_service_content(self):"},{"line_number":41,"context_line":"        return self.RetrieveServiceContent(\u0027ServiceInstance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_c003a70b","line":41,"in_reply_to":"baada198_0a087d2c","updated":"2014-07-09 12:57:59.000000000","message":"Done","commit_id":"4ae91e9e0a51d5d0919b7b2ac22bc387b0d0e9c8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1cdb6157cc0f9977b617083f372b270907b5e6e5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":34,"context_line":"        self.soap_url \u003d base_url + \u0027/sdk\u0027"},{"line_number":35,"context_line":"        if wsdl_url is None:"},{"line_number":36,"context_line":"            wsdl_url \u003d self.soap_url + \u0027/vimService.wsdl\u0027"},{"line_number":37,"context_line":"        self.wsdl_url \u003d wsdl_url"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_96d1c0fd","line":34,"updated":"2014-07-10 16:46:43.000000000","message":"Similar changes as in Pbm?","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e7a11cb2fcc4e9ee935076d5c9ab62a8fc94b87d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        base_url \u003d service.Service.build_url(protocol, host, port)"},{"line_number":34,"context_line":"        self.soap_url \u003d base_url + \u0027/sdk\u0027"},{"line_number":35,"context_line":"        if wsdl_url is None:"},{"line_number":36,"context_line":"            wsdl_url \u003d self.soap_url + \u0027/vimService.wsdl\u0027"},{"line_number":37,"context_line":"        self.wsdl_url \u003d wsdl_url"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_08d2d7ff","line":34,"in_reply_to":"baada198_96d1c0fd","updated":"2014-07-11 07:25:27.000000000","message":"Done","commit_id":"373ba888b3237b61de80f5464f9de9015ec9f481"}],"tox.ini":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7d4fd92e2d1da66d842aafdc196c877b8595283","unresolved":false,"context_lines":[{"line_number":25,"context_line":"builtins \u003d _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[hacking]"},{"line_number":28,"context_line":"import_exceptions \u003d oslo.vmware.openstack.common.gettextutils"}],"source_content_type":"text/x-properties","patch_set":3,"id":"baada198_f6a700bb","line":28,"updated":"2014-07-06 05:07:31.000000000","message":"why the change here?","commit_id":"8a87ab9f0b87910beaa7cce8ea0115448e55aabf"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"6e0c97a61f2340409b5a0c5a40b8267235b64173","unresolved":false,"context_lines":[{"line_number":25,"context_line":"builtins \u003d _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[hacking]"},{"line_number":28,"context_line":"import_exceptions \u003d oslo.vmware.openstack.common.gettextutils"}],"source_content_type":"text/x-properties","patch_set":3,"id":"baada198_b9457b44","line":28,"in_reply_to":"baada198_f6a700bb","updated":"2014-07-06 08:15:35.000000000","message":"because we need _LE in service.py","commit_id":"8a87ab9f0b87910beaa7cce8ea0115448e55aabf"}]}