)]}'
{"oslo/vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c78b7082c319b0568101a9a957442169b2272d98","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                          \"after %(retry_count)d retries.\","},{"line_number":89,"context_line":"                          {\u0027func_name\u0027: func_name,"},{"line_number":90,"context_line":"                           \u0027retry_count\u0027: self._retry_count})"},{"line_number":91,"context_line":"                raise loopingcall.LoopingCallDone(result)"},{"line_number":92,"context_line":"            except self._exceptions:"},{"line_number":93,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":94,"context_line":"                    LOG.warn(_LW(\"Exception which is in the suggested list of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_82b3e598","line":91,"updated":"2014-07-14 09:20:27.000000000","message":"Will this be logged unnecessarily?\n\nWhen will result be undefined?\nIf it is during the invocation of \u0027f\u0027 then this line will never be reached in the original code.","commit_id":"86bda573533e3d7044535c90e6538b01152c74d3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d0e0c2d8c5ec28daf76cccd35a3d118dde63fa9e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                          \"after %(retry_count)d retries.\","},{"line_number":89,"context_line":"                          {\u0027func_name\u0027: func_name,"},{"line_number":90,"context_line":"                           \u0027retry_count\u0027: self._retry_count})"},{"line_number":91,"context_line":"                raise loopingcall.LoopingCallDone(result)"},{"line_number":92,"context_line":"            except self._exceptions:"},{"line_number":93,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":94,"context_line":"                    LOG.warn(_LW(\"Exception which is in the suggested list of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_56b26c94","line":91,"in_reply_to":"baada198_33ad0a9c","updated":"2014-07-14 10:40:28.000000000","message":"OK, got it. I\u0027ll change it to initialize the result before the try block.","commit_id":"86bda573533e3d7044535c90e6538b01152c74d3"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"9c91fb9a91dc00aa01ed30a6cb675f454cab689e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                          \"after %(retry_count)d retries.\","},{"line_number":89,"context_line":"                          {\u0027func_name\u0027: func_name,"},{"line_number":90,"context_line":"                           \u0027retry_count\u0027: self._retry_count})"},{"line_number":91,"context_line":"                raise loopingcall.LoopingCallDone(result)"},{"line_number":92,"context_line":"            except self._exceptions:"},{"line_number":93,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":94,"context_line":"                    LOG.warn(_LW(\"Exception which is in the suggested list of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d0a3e4af","line":91,"in_reply_to":"baada198_82b3e598","updated":"2014-07-14 09:38:17.000000000","message":"I don\u0027t understand the 1st question - do you mean the log on line 87?\n\nThe result will be undefined when f throws an exception. We catch all exceptions on line 111 and reraise them, so line 117 is not reached. However, this is still bad code which is detected by the IDE. The \u0027result\u0027 variable should be used in the try block, not outside of it.","commit_id":"86bda573533e3d7044535c90e6538b01152c74d3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dedc89373c42a5841c9ebbc4f9aba8b9c6456538","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                          \"after %(retry_count)d retries.\","},{"line_number":89,"context_line":"                          {\u0027func_name\u0027: func_name,"},{"line_number":90,"context_line":"                           \u0027retry_count\u0027: self._retry_count})"},{"line_number":91,"context_line":"                raise loopingcall.LoopingCallDone(result)"},{"line_number":92,"context_line":"            except self._exceptions:"},{"line_number":93,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":94,"context_line":"                    LOG.warn(_LW(\"Exception which is in the suggested list of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_33ad0a9c","line":91,"in_reply_to":"baada198_d0a3e4af","updated":"2014-07-14 09:58:57.000000000","message":"I\u0027m talking about the log on line 113. I\u0027m fine with this change if it doesn\u0027t print confusing log line about an exception when there is none.","commit_id":"86bda573533e3d7044535c90e6538b01152c74d3"}]}