)]}'
{"oslo/vmware/exceptions.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"af664fb8b55d3f220b5de2b675769101c90e1341","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return descr"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":93,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":94,"context_line":"    pass"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_cbedab8d","line":92,"updated":"2014-08-18 09:01:08.000000000","message":"this exception indicates a connection problem and I think it should be clearly separated from errors that are thrown from vCenter, i.e. it must not inherit from VimException","commit_id":"db95fed7da1b6a4f7fa19379e3eb442929fc1a84"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f0537de1aedfa614167d2078c22285ebf1922eb8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return descr"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":93,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":94,"context_line":"    pass"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_94e927e8","line":92,"in_reply_to":"1abeadc6_cbedab8d","updated":"2014-08-24 18:10:33.000000000","message":"Right, I know that. As I mentioned in the commit message, since this is thrown by the service module, it should be a service exception. The vim faults should inherit VimException and VimException should be a child of ServiceException. But I think this will result in client side changes-- all the existing code which expect VimException should be changed to ServiceException.","commit_id":"db95fed7da1b6a4f7fa19379e3eb442929fc1a84"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"af664fb8b55d3f220b5de2b675769101c90e1341","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    pass"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class VimConnectionException(VimException):"},{"line_number":98,"context_line":"    \"\"\"Thrown when there is a connection problem.\"\"\""},{"line_number":99,"context_line":"    pass"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_2b58df55","line":97,"updated":"2014-08-18 09:01:08.000000000","message":"same comment","commit_id":"db95fed7da1b6a4f7fa19379e3eb442929fc1a84"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"af664fb8b55d3f220b5de2b675769101c90e1341","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    pass"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class VimFaultException(VimException):"},{"line_number":108,"context_line":"    \"\"\"Exception thrown when there are faults during VIM API calls.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self, fault_list, message\u003dNone, cause\u003dNone, details\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_cba4cb59","line":107,"updated":"2014-08-18 09:01:08.000000000","message":"what is the difference between VimFaultException and VimException? it is confusing to have both","commit_id":"db95fed7da1b6a4f7fa19379e3eb442929fc1a84"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f0537de1aedfa614167d2078c22285ebf1922eb8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    pass"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class VimFaultException(VimException):"},{"line_number":108,"context_line":"    \"\"\"Exception thrown when there are faults during VIM API calls.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self, fault_list, message\u003dNone, cause\u003dNone, details\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_54b30f09","line":107,"in_reply_to":"1abeadc6_cba4cb59","updated":"2014-08-24 18:10:33.000000000","message":"Since we are not mapping all faults to specific exceptions, I think we should retain it as a generic fault class. However, if we decide to introduce ServiceException, then we can replace VimFaultException with VimException.","commit_id":"db95fed7da1b6a4f7fa19379e3eb442929fc1a84"}],"oslo_vmware/exceptions.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4bb7025b3fc88526f42735d2ee061f04f750ca49","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":264,"context_line":"    if not fault_class:"},{"line_number":265,"context_line":"        LOG.debug(\u0027Fault %s not matched.\u0027, name)"},{"line_number":266,"context_line":"        fault_class \u003d VMwareDriverException"},{"line_number":267,"context_line":"    return fault_class"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_10af3082","line":266,"updated":"2015-06-16 12:17:02.000000000","message":"Should this not be: VimException?","commit_id":"1d872ad664117740ccaf6f2c712280596387e965"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"99dfaa9950da974aaf6924a322afc78aefe80e36","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":264,"context_line":"    if not fault_class:"},{"line_number":265,"context_line":"        LOG.debug(\u0027Fault %s not matched.\u0027, name)"},{"line_number":266,"context_line":"        fault_class \u003d VMwareDriverException"},{"line_number":267,"context_line":"    return fault_class"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_70747cce","line":266,"in_reply_to":"fa32b979_10af3082","updated":"2015-06-16 12:29:39.000000000","message":"This should be None. This change is made in https://review.openstack.org/#/c/192139/1/oslo_vmware/exceptions.py","commit_id":"1d872ad664117740ccaf6f2c712280596387e965"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4bb7025b3fc88526f42735d2ee061f04f750ca49","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def register_fault_class(name, exception):"},{"line_number":271,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":272,"context_line":"    if not issubclass(exception, VMwareDriverException):"},{"line_number":273,"context_line":"        raise TypeError(_(\"exception should be a subclass of \""},{"line_number":274,"context_line":"                          \"VMwareDriverException\"))"},{"line_number":275,"context_line":"    if fault_class:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_d005487a","line":272,"updated":"2015-06-16 12:17:02.000000000","message":"VMwareDriverException \u003d\u003e VimException","commit_id":"1d872ad664117740ccaf6f2c712280596387e965"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e19b41372d9dcbdfcbd2efd9d7cb3a502bdbc4f9","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def register_fault_class(name, exception):"},{"line_number":271,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":272,"context_line":"    if not issubclass(exception, VMwareDriverException):"},{"line_number":273,"context_line":"        raise TypeError(_(\"exception should be a subclass of \""},{"line_number":274,"context_line":"                          \"VMwareDriverException\"))"},{"line_number":275,"context_line":"    if fault_class:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_cbbb59e4","line":272,"in_reply_to":"fa32b979_d005487a","updated":"2015-06-16 12:30:11.000000000","message":"Done","commit_id":"1d872ad664117740ccaf6f2c712280596387e965"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e1b19ac7cefb71e5c1ff132a5706b44c41293a2e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        __str__ \u003d lambda self: self.description"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __init__(self, message, cause\u003dNone, details\u003dNone, **kwargs):"},{"line_number":89,"context_line":"        if isinstance(message, list):"},{"line_number":90,"context_line":"            # we need this to protect against developers using"},{"line_number":91,"context_line":"            # this method like VimFaultException"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3f3983d7","line":88,"updated":"2015-06-18 06:21:29.000000000","message":"please set message\u003dNone - this will enable us to not have any changes in nova :)","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"af138ad7c802e21ebd7020396146bbb79fb9c4a1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        __str__ \u003d lambda self: self.description"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __init__(self, message, cause\u003dNone, details\u003dNone, **kwargs):"},{"line_number":89,"context_line":"        if isinstance(message, list):"},{"line_number":90,"context_line":"            # we need this to protect against developers using"},{"line_number":91,"context_line":"            # this method like VimFaultException"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_7fdf0b3a","line":88,"in_reply_to":"fa32b979_3f3983d7","updated":"2015-06-18 06:35:05.000000000","message":"Done","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"dfc432755fa949af2907e621efb7e5b794131197","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            descr +\u003d \u0027\\nCause: \u0027 + six.text_type(self.cause)"},{"line_number":109,"context_line":"        return descr"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":113,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":114,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f86912fa","line":111,"updated":"2015-06-17 15:50:32.000000000","message":"This really bothers me. This and the following two exceptions have nothing to do with the VIM API. I know that we are doing this only to avoid changing Nova but I think it\u0027s worth to consider a breaking change and making this the right way. What do others think?","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"63c17e3ecfeed88c373a744dff5b089559fb2f96","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            descr +\u003d \u0027\\nCause: \u0027 + six.text_type(self.cause)"},{"line_number":109,"context_line":"        return descr"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":113,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":114,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_a19eca60","line":111,"in_reply_to":"fa32b979_4eb15446","updated":"2015-06-18 11:34:13.000000000","message":"Your suggestion for having ServiceException sounds good to me. We don\u0027t use VimException in Nova so I think it is doable. I also think that it\u0027d be nice to do this before declaring version 1.0.0 which is supposed to be a stable API.","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5fb0baca9d02d2790a2ae87f0ce35bbbf948bfd1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            descr +\u003d \u0027\\nCause: \u0027 + six.text_type(self.cause)"},{"line_number":109,"context_line":"        return descr"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":113,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":114,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_827b4f29","line":111,"in_reply_to":"fa32b979_a19eca60","updated":"2015-06-19 12:30:55.000000000","message":"Done\n\nPlease see the updated commit message for details.","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e6406e6e7aeeb94a01410f825f317d3b5440d853","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            descr +\u003d \u0027\\nCause: \u0027 + six.text_type(self.cause)"},{"line_number":109,"context_line":"        return descr"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class VimSessionOverLoadException(VimException):"},{"line_number":113,"context_line":"    \"\"\"Thrown when there is an API call overload at the VMware server.\"\"\""},{"line_number":114,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_4eb15446","line":111,"in_reply_to":"fa32b979_f86912fa","updated":"2015-06-17 16:23:18.000000000","message":"Rado,\n\nYou had the same concern in the one of the previous patch sets and please see my reply there.\n\nWe may also raise PBM faults as VIM exceptions. So we have to introduce ServiceException with two children: VimException and PBMException. The refactoring to separate PBM faults may not be trivial.\n\nThe following three exceptions can inherit ServiceException. What do you think about this suggestion (minus PBMException)? What will be its impact on Nova? Do we have to change the call sites which expect VimException to ServiceException?","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"dfc432755fa949af2907e621efb7e5b794131197","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class VMwareDriverConfigurationException(VMwareDriverException):"},{"line_number":161,"context_line":"    \"\"\"Base class for all configuration exceptions."},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    msg_fmt \u003d _(\"VMware Driver configuration fault.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_58dd9ede","line":160,"updated":"2015-06-17 15:50:32.000000000","message":"Driver specific exceptions should be part of the corresponding driver. Let\u0027s deprecate this.","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"63c17e3ecfeed88c373a744dff5b089559fb2f96","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class VMwareDriverConfigurationException(VMwareDriverException):"},{"line_number":161,"context_line":"    \"\"\"Base class for all configuration exceptions."},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    msg_fmt \u003d _(\"VMware Driver configuration fault.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_017bf628","line":160,"in_reply_to":"fa32b979_4e9874c0","updated":"2015-06-18 11:34:13.000000000","message":"Thanks","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e6406e6e7aeeb94a01410f825f317d3b5440d853","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class VMwareDriverConfigurationException(VMwareDriverException):"},{"line_number":161,"context_line":"    \"\"\"Base class for all configuration exceptions."},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    msg_fmt \u003d _(\"VMware Driver configuration fault.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_4e9874c0","line":160,"in_reply_to":"fa32b979_58dd9ede","updated":"2015-06-17 16:23:18.000000000","message":"Please see the dependent review (the last one).","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"dfc432755fa949af2907e621efb7e5b794131197","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    msg_fmt \u003d _(\"VMware Driver configuration fault.\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"class UseLinkedCloneConfigurationFault(VMwareDriverConfigurationException):"},{"line_number":167,"context_line":"    msg_fmt \u003d _(\"No default value for use_linked_clone found.\")"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f831125b","line":166,"updated":"2015-06-17 15:50:32.000000000","message":"Could you please mark this as deprecated, so we can remove it in a next release? I have a patch which remove using this in Nova: https://review.openstack.org/191787","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"dfc432755fa949af2907e621efb7e5b794131197","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    msg_fmt \u003d _(\"No default value for use_linked_clone found.\")"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class MissingParameter(VMwareDriverException):"},{"line_number":171,"context_line":"    msg_fmt \u003d _(\"Missing parameter : %(param)s\")"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_181e36bb","line":170,"updated":"2015-06-17 15:50:32.000000000","message":"AFAIK this is not used anywhere so we should deprecate it","commit_id":"d889550921c770800d6ef0362c23d86458236fb9"}]}
