)]}'
{"oslo/vmware/selector.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"133a0550a9865abf84c9bc9c81b7d3ebc5b95923","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from stevedore import driver"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.vmware import exceptions"},{"line_number":23,"context_line":"from oslo.vmware.objects import datastore"},{"line_number":24,"context_line":"from oslo.vmware.openstack.common.gettextutils import _, _LE"},{"line_number":25,"context_line":"from oslo.vmware import vim_util"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_89a2a0ac","line":23,"updated":"2014-08-19 13:16:18.000000000","message":"What about \u0027import datastore as datastore_object\u0027? \nThen we don\u0027t have to use identifiers such data_store which is sort of inconsistent with VIM naming.","commit_id":"b23562dfced87a30685b142f7267940098fa00b2"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"00eac553f094dacc4e3ff40eea66bab7006ef327","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from stevedore import driver"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.vmware import exceptions"},{"line_number":23,"context_line":"from oslo.vmware.objects import datastore"},{"line_number":24,"context_line":"from oslo.vmware.openstack.common.gettextutils import _, _LE"},{"line_number":25,"context_line":"from oslo.vmware import vim_util"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_307accf1","line":23,"in_reply_to":"1abeadc6_89a2a0ac","updated":"2014-08-19 13:54:28.000000000","message":"Done","commit_id":"b23562dfced87a30685b142f7267940098fa00b2"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"133a0550a9865abf84c9bc9c81b7d3ebc5b95923","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    return dict([(prop.name, prop.val) for prop in propset])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def _is_datastore_valid(propdict, datastore_regex):"},{"line_number":90,"context_line":"    \"\"\"Checks if a datastore is valid based on the following criteria."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Criteria:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_e91074aa","line":89,"updated":"2014-08-19 13:16:18.000000000","message":"what about having this method in objects.datastore?\n\nThen _select_datastore can get a list of datastore objects and filter out datastores which are not valid using datastore_obj.is_datastore_valid.","commit_id":"b23562dfced87a30685b142f7267940098fa00b2"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"00eac553f094dacc4e3ff40eea66bab7006ef327","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    return dict([(prop.name, prop.val) for prop in propset])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def _is_datastore_valid(propdict, datastore_regex):"},{"line_number":90,"context_line":"    \"\"\"Checks if a datastore is valid based on the following criteria."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Criteria:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_101cf0c0","line":89,"in_reply_to":"1abeadc6_e91074aa","updated":"2014-08-19 13:54:28.000000000","message":"Done","commit_id":"b23562dfced87a30685b142f7267940098fa00b2"}]}