)]}'
{"oslo/vmware/exceptions.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"bcc8228036f3626a029246600ec57197901228ba","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":236,"context_line":"    if fault_class:"},{"line_number":237,"context_line":"        LOG.warning(_LW(\u0027Overriding exception for %s\u0027), name)"},{"line_number":238,"context_line":"    _fault_classes_registry[name] \u003d exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_7d0b202a","line":238,"updated":"2014-09-03 07:11:43.000000000","message":"we need to at least check if the given exception is subclass of VMwareDriverException","commit_id":"3ef0ab6901d9d26ec2154f798b8b9170cd3a48c8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c59602bf1cc1197f5f1248b85cbf75af331f26d5","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    return fault_class"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"def extend_fault_class(name, exception):"},{"line_number":235,"context_line":"    fault_class \u003d _fault_classes_registry.get(name)"},{"line_number":236,"context_line":"    if not issubclass(exception, VMwareDriverException):"},{"line_number":237,"context_line":"        raise TypeError(_(\"exception should be a subclass of \""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_7e636141","line":234,"updated":"2014-09-09 11:27:08.000000000","message":"register_fault_class seems more appropriate but i don\u0027t feel strongly about it.","commit_id":"9aec75ccb0efbc3a7a78b5b91c12b8198a6eebe7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c59602bf1cc1197f5f1248b85cbf75af331f26d5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        raise TypeError(_(\"exception should be a subclass of \""},{"line_number":238,"context_line":"                          \"VMwareDriverException\"))"},{"line_number":239,"context_line":"    if fault_class:"},{"line_number":240,"context_line":"        LOG.warning(_LW(\u0027Overriding exception for %s\u0027), name)"},{"line_number":241,"context_line":"    _fault_classes_registry[name] \u003d exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_de6c4d39","line":240,"updated":"2014-09-09 11:27:08.000000000","message":"Should this be LOG.debug? we are not trying to warn operators right?","commit_id":"9aec75ccb0efbc3a7a78b5b91c12b8198a6eebe7"}],"tests/test_api.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"dfa8922e449f301fc4249c3e48a9c2e10e04a552","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        self.assertEqual(exc,"},{"line_number":505,"context_line":"                         exceptions.get_fault_class(exceptions.ALREADY_EXISTS))"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def test_register_fault_classi_invalid(self):"},{"line_number":508,"context_line":"        self.assertRaises(TypeError,"},{"line_number":509,"context_line":"                          exceptions.register_fault_class,"},{"line_number":510,"context_line":"                          \u0027ValueError\u0027, ValueError)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_6e0a8427","line":507,"updated":"2014-09-11 13:16:40.000000000","message":"typo: classi","commit_id":"6c2495335c10744b1c583cad116bfe694c84f9d8"}]}