)]}'
{"oslo/vmware/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a870dae271435953c959299685cb2bba5821597","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                    if excep.fault_list:"},{"line_number":322,"context_line":"                        LOG.debug(\"Fault list: %s\", excep.fault_list)"},{"line_number":323,"context_line":"                        fault \u003d excep.fault_list[0]"},{"line_number":324,"context_line":"                        clazz \u003d exceptions.get_fault_class(fault)"},{"line_number":325,"context_line":"                        raise clazz(unicode(excep), excep.details)"},{"line_number":326,"context_line":"                    raise"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_53400ba5","line":324,"updated":"2014-09-11 12:26:40.000000000","message":"i have seen klass used. but i guess this is good too","commit_id":"81ef9d49c887c623b531064bd8fb32ab57e517f0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dc3b2d6876f3f63b8f09c69b7cedaf8efa8e5b6f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                        LOG.debug(\"Fault list: %s\", excep.fault_list)"},{"line_number":323,"context_line":"                        fault \u003d excep.fault_list[0]"},{"line_number":324,"context_line":"                        clazz \u003d exceptions.get_fault_class(fault)"},{"line_number":325,"context_line":"                        raise clazz(unicode(excep), excep.details)"},{"line_number":326,"context_line":"                    raise"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            except exceptions.VimConnectionException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_563e36db","line":325,"updated":"2014-09-11 14:37:59.000000000","message":"We are not losing the details as you mentioned in the commit message. The exception message contains the details. Now we have redundant info.\n\nThe resolved exception has its own message. It is better to construct the string representation using details within VMwareDriverException.","commit_id":"81ef9d49c887c623b531064bd8fb32ab57e517f0"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"28d14a6dcd824232bac9e28965580eb455618667","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                        LOG.debug(\"Fault list: %s\", excep.fault_list)"},{"line_number":323,"context_line":"                        fault \u003d excep.fault_list[0]"},{"line_number":324,"context_line":"                        clazz \u003d exceptions.get_fault_class(fault)"},{"line_number":325,"context_line":"                        raise clazz(unicode(excep), excep.details)"},{"line_number":326,"context_line":"                    raise"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            except exceptions.VimConnectionException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_65c53a8d","line":325,"in_reply_to":"fa98f980_563e36db","updated":"2014-09-11 16:32:18.000000000","message":"I strongly disagree with this. I need the information from the details as key/values in order to use it, not string. The string representation is only for logging purposes and cannot be used in the application logic. Let me give you a concrete example: when vCenter throws DuplicateName, the details contain the mo-ref of the already existing object. This information should be a property of the exception.","commit_id":"81ef9d49c887c623b531064bd8fb32ab57e517f0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"de5815286be9f3d4ae8f5dfc08e8fcc7b5cb35e3","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                        LOG.debug(\"Fault list: %s\", excep.fault_list)"},{"line_number":323,"context_line":"                        fault \u003d excep.fault_list[0]"},{"line_number":324,"context_line":"                        clazz \u003d exceptions.get_fault_class(fault)"},{"line_number":325,"context_line":"                        raise clazz(unicode(excep), excep.details)"},{"line_number":326,"context_line":"                    raise"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            except exceptions.VimConnectionException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_e5bbeae2","line":325,"in_reply_to":"fa98f980_65c53a8d","updated":"2014-09-11 16:38:27.000000000","message":"Then it makes sense to clarify this in the commit message with an example like this.","commit_id":"81ef9d49c887c623b531064bd8fb32ab57e517f0"}]}
