)]}'
{"oslo/vmware/vim_util.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"889de18c5498e97cf4fe1d1ebc3e82cc51e03690","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    prop_filter_spec \u003d build_property_filter_spec(client_factory,"},{"line_number":451,"context_line":"                                                  [prop_spec], [obj_spec])"},{"line_number":452,"context_line":"    options \u003d client_factory.create(\u0027ns0:RetrieveOptions\u0027)"},{"line_number":453,"context_line":"    options.maxObjects \u003d max_objects"},{"line_number":454,"context_line":"    object_contents \u003d vim.RetrievePropertiesEx("},{"line_number":455,"context_line":"        property_collector,"},{"line_number":456,"context_line":"        specSet\u003d[prop_filter_spec],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_a3f4cef2","line":453,"updated":"2014-09-23 14:45:32.000000000","message":"if the length of the result set is bigger than max_objects then a token is returned; I think that you need to check for the token and use it appropriately below","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"05b2cdfd6872987e041e801ca9a27d2783630bbc","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    prop_filter_spec \u003d build_property_filter_spec(client_factory,"},{"line_number":451,"context_line":"                                                  [prop_spec], [obj_spec])"},{"line_number":452,"context_line":"    options \u003d client_factory.create(\u0027ns0:RetrieveOptions\u0027)"},{"line_number":453,"context_line":"    options.maxObjects \u003d max_objects"},{"line_number":454,"context_line":"    object_contents \u003d vim.RetrievePropertiesEx("},{"line_number":455,"context_line":"        property_collector,"},{"line_number":456,"context_line":"        specSet\u003d[prop_filter_spec],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_71716643","line":453,"in_reply_to":"da9df570_a3f4cef2","updated":"2014-09-26 19:42:19.000000000","message":"Done","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"889de18c5498e97cf4fe1d1ebc3e82cc51e03690","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    entity_name \u003d None"},{"line_number":460,"context_line":"    path \u003d \"\""},{"line_number":461,"context_line":"    for object_content in object_contents:"},{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_980d7993","line":461,"updated":"2014-09-23 14:45:32.000000000","message":"in which cases multiple results are returned and we need to iterate over them?","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"05b2cdfd6872987e041e801ca9a27d2783630bbc","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    entity_name \u003d None"},{"line_number":460,"context_line":"    path \u003d \"\""},{"line_number":461,"context_line":"    for object_content in object_contents:"},{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_2e7699d7","line":461,"in_reply_to":"da9df570_980d7993","updated":"2014-09-26 19:42:19.000000000","message":"Done","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"889de18c5498e97cf4fe1d1ebc3e82cc51e03690","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    path \u003d \"\""},{"line_number":461,"context_line":"    for object_content in object_contents:"},{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for obj in props[:-1]:"},{"line_number":466,"context_line":"                if hasattr(obj, \u0027propSet\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_98457972","line":463,"updated":"2014-09-23 14:45:32.000000000","message":"this is pretty ugly hack :)\n\nobject_contents is always (\u0027objects\u0027, [(ObjectContent), (ObjectContent), ...])\n\nwhy not simply unpack the result and iterate over the second element?","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"05b2cdfd6872987e041e801ca9a27d2783630bbc","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    path \u003d \"\""},{"line_number":461,"context_line":"    for object_content in object_contents:"},{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for obj in props[:-1]:"},{"line_number":466,"context_line":"                if hasattr(obj, \u0027propSet\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_6b725312","line":463,"in_reply_to":"da9df570_98457972","updated":"2014-09-26 19:42:19.000000000","message":"Done","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"889de18c5498e97cf4fe1d1ebc3e82cc51e03690","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for obj in props[:-1]:"},{"line_number":466,"context_line":"                if hasattr(obj, \u0027propSet\u0027):"},{"line_number":467,"context_line":"                    propSet \u003d obj.propSet"},{"line_number":468,"context_line":"                    if len(propSet) \u003e\u003d 1 and not entity_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_a36f6ec4","line":465,"updated":"2014-09-23 14:45:32.000000000","message":"this is another hack to truncate the root folder from the path; please put a comment to explain why we do that","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"05b2cdfd6872987e041e801ca9a27d2783630bbc","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        for props in object_content:"},{"line_number":463,"context_line":"            if type(props) \u003d\u003d str:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for obj in props[:-1]:"},{"line_number":466,"context_line":"                if hasattr(obj, \u0027propSet\u0027):"},{"line_number":467,"context_line":"                    propSet \u003d obj.propSet"},{"line_number":468,"context_line":"                    if len(propSet) \u003e\u003d 1 and not entity_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_8ed2255a","line":465,"in_reply_to":"da9df570_a36f6ec4","updated":"2014-09-26 19:42:19.000000000","message":"Done","commit_id":"a8e6c13a0fd96c8344a8fb990366d36124a83db9"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"2f69309761643a512468e8bc4470d585a602fa87","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    # NOTE(arnaud): slice to exclude the root folder from the result."},{"line_number":468,"context_line":"    if propSet is not None and len(propSet) \u003e 0:"},{"line_number":469,"context_line":"        path \u003d path[len(propSet[0].val):]"},{"line_number":470,"context_line":"    if entity_name is None:"},{"line_number":471,"context_line":"        entity_name \u003d \"\""},{"line_number":472,"context_line":"    return \u0027%s%s\u0027 % (path, entity_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_053cf62e","line":470,"updated":"2014-09-29 15:41:15.000000000","message":"I think you can remove this check if you initialize entity_name with an empty string","commit_id":"264e428b4f2d1a987b884742228d3e78a61cca05"}]}
