)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d2d83a9716a0ef20657da8ede7a879e8dfb81126","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     root \u003cguoyongxhzhf@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-22 11:28:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"oslo.vmware: getattr throw exception insteading returning none"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if we do not thrown exception in __getattr__, we will get exception in following calling. It is hard to find problem according to hint."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_a6d08c54","line":7,"updated":"2015-03-04 19:17:36.000000000","message":"\"getattr raises exception instead of returning None\"","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d2d83a9716a0ef20657da8ede7a879e8dfb81126","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"oslo.vmware: getattr throw exception insteading returning none"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if we do not thrown exception in __getattr__, we will get exception in following calling. It is hard to find problem according to hint."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie8ed87d4869ea2feab668361c121af956818cc43"},{"line_number":12,"context_line":"Closes-Bug: 1410160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_e6f36408","line":9,"updated":"2015-03-04 19:17:36.000000000","message":"Limit commit messages to 72 chars","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"}],"oslo_vmware/exceptions.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"682279315b596a989dcec1e00e0d9ae2532e60f4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class VimInvalidInput(VimException)"},{"line_number":89,"context_line":"    \"\"\"Thrown when an input parameter is invalid.\"\"\""},{"line_number":90,"context_line":"    pass"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_27471b21","line":88,"updated":"2015-02-22 06:27:35.000000000","message":"Should be:\nclass VimInvalidInput(VimException):","commit_id":"56819ad317b07cd3b29ec31b11bcc86ae3ce9754"}],"oslo_vmware/service.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bccd0b487969e5a6d24383996438482d75ecce19","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    managed_object \u003d vim_util.get_moref(managed_object,"},{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise ValueError(_(\u0027managed object is None\u0027))"},{"line_number":287,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":288,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":289,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_d5b535ce","line":286,"updated":"2015-01-21 14:55:22.000000000","message":"We should throw a more specific exception","commit_id":"3b43145aab7e7b17378159583454683931b9df9a"},{"author":{"_account_id":11672,"name":"xhzhf","email":"guoyongxhzhf@163.com","username":"xhzhf"},"change_message_id":"dd5d53d5ed8f153e91a4652a7209fdd55514b14e","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    managed_object \u003d vim_util.get_moref(managed_object,"},{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise ValueError(_(\u0027managed object is None\u0027))"},{"line_number":287,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":288,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":289,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_23836357","line":286,"in_reply_to":"1a930d6b_d5b535ce","updated":"2015-01-23 01:36:56.000000000","message":"if your have recommended one, please tell me. In fact, the exception doesn\u0027t throw to upper function. It is cathed in the function","commit_id":"3b43145aab7e7b17378159583454683931b9df9a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7169c27800af79cbd9d0f7e566109f37057af3be","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    managed_object \u003d vim_util.get_moref(managed_object,"},{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise ValueError(_(\u0027managed object is None\u0027))"},{"line_number":287,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":288,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":289,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_f075b1cc","line":286,"updated":"2015-02-16 13:57:36.000000000","message":"why do we not raise a more specific exception here \nconsider adding exceptions.VimInvalidInput","commit_id":"1ef0fdb4a2351af1cb3fa47f888531fe8c15fd2b"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"0a93d4478179905810d1b5cb0214425e9ad75de5","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                if isinstance(managed_object, str):"},{"line_number":281,"context_line":"                    # For strings, use string value for value and type"},{"line_number":282,"context_line":"                    # of the managed object."},{"line_number":283,"context_line":"                    managed_object \u003d vim_util.get_moref(managed_object,"},{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b614d1a0","line":283,"updated":"2015-03-06 13:49:59.000000000","message":"this doesn\u0027t make any sense :)","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"76934c3f39b53879cf4489e7575c852f0b8a5da2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_d327b7b4","line":287,"updated":"2015-02-23 22:15:29.000000000","message":"Is this error message meant to be seen and used by an application developer, or is it going to end up in a log file somewhere? Is \"managed object is None\" a meaningful enough message?","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"25190e0e62508797b3f563c21864fab6ca5b201f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_3697eaed","line":287,"in_reply_to":"9a80dd14_f6972938","updated":"2015-03-06 22:26:58.000000000","message":"I am ok with raising exception. But I still feel it should bump the major version.","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":11672,"name":"xhzhf","email":"guoyongxhzhf@163.com","username":"xhzhf"},"change_message_id":"6be8aba3702edf994bef4a050d9d197c890dc58d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_b13e57b6","line":287,"in_reply_to":"ba7be1f8_7a6f612b","updated":"2015-03-04 03:46:35.000000000","message":"1.In vmware driver, caller of __getattr__ will always not  check return value. In havana, the function throw exception, then In the latest version, it return none. \n2.After my modification, the exception will be catched in the next sentence in fact. It will not influence current code. \n3.from my opilion, openstack prefer exception than returning value.\nPlease consider it, thanks.","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"0a93d4478179905810d1b5cb0214425e9ad75de5","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_f6972938","line":287,"in_reply_to":"ba7be1f8_b13e57b6","updated":"2015-03-06 13:49:59.000000000","message":"If managed_object is None this means incorrect input for this method and raising exception is the most proper thing to do. Any code that relies on getting None should be fixed prior to this patch.","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"69cad205646feccdefdf33c5d95876880dc93f78","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_7a6f612b","line":287,"in_reply_to":"ba7be1f8_b2664bb9","updated":"2015-03-04 00:04:16.000000000","message":"IMO, we should not raise an exception. The user of the library should check the return value before using it elsewhere. \n\nIt will be cumbersome to handle these exceptions, if implemented. Not to mention, this will break backwards compatibility.","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"},{"author":{"_account_id":11672,"name":"xhzhf","email":"guoyongxhzhf@163.com","username":"xhzhf"},"change_message_id":"b83029f46b6c26c659fb62e98f94f8bbe42a8461","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                                        managed_object)"},{"line_number":285,"context_line":"                if managed_object is None:"},{"line_number":286,"context_line":"                    raise exceptions.VimInvalidInput("},{"line_number":287,"context_line":"                        _(\u0027managed object is None\u0027))"},{"line_number":288,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":289,"context_line":"                response \u003d request(managed_object, **kwargs)"},{"line_number":290,"context_line":"                if (attr_name.lower() \u003d\u003d \u0027retrievepropertiesex\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_b2664bb9","line":287,"in_reply_to":"ba7be1f8_d327b7b4","updated":"2015-02-26 02:45:19.000000000","message":"1.It is going to end up in a log file.\n2.The message \"managed object is None\" is full. When we fix problem, we regard context.","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"}],"oslo_vmware/tests/test_service.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c03b111d80de1959bff5fc2d6e592f66b2fee79d","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def test_request_handler_no_value(self, mock_moref):"},{"line_number":292,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":293,"context_line":"        svc_obj \u003d service.Service()"},{"line_number":294,"context_line":"        self.assertRaises(exceptions.VimException,"},{"line_number":295,"context_line":"                          svc_obj.UnregisterVM,"},{"line_number":296,"context_line":"                          managed_object)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_15f5fd82","line":294,"updated":"2015-01-21 14:56:19.000000000","message":"In the code you raise ValueError. So this is a little odd","commit_id":"3b43145aab7e7b17378159583454683931b9df9a"},{"author":{"_account_id":11672,"name":"xhzhf","email":"guoyongxhzhf@163.com","username":"xhzhf"},"change_message_id":"dd5d53d5ed8f153e91a4652a7209fdd55514b14e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def test_request_handler_no_value(self, mock_moref):"},{"line_number":292,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":293,"context_line":"        svc_obj \u003d service.Service()"},{"line_number":294,"context_line":"        self.assertRaises(exceptions.VimException,"},{"line_number":295,"context_line":"                          svc_obj.UnregisterVM,"},{"line_number":296,"context_line":"                          managed_object)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_239c43c0","line":294,"in_reply_to":"1a930d6b_15f5fd82","updated":"2015-01-23 01:36:56.000000000","message":"__get__attr catche the exception and throw VimException. so wo should catch VimException","commit_id":"3b43145aab7e7b17378159583454683931b9df9a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d2d83a9716a0ef20657da8ede7a879e8dfb81126","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    def test_request_handler_no_value(self, mock_moref):"},{"line_number":324,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":325,"context_line":"        svc_obj \u003d service.Service()"},{"line_number":326,"context_line":"        self.assertRaises(exceptions.VimException,"},{"line_number":327,"context_line":"                          svc_obj.UnregisterVM,"},{"line_number":328,"context_line":"                          managed_object)"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_8669c88d","line":326,"updated":"2015-03-04 19:17:36.000000000","message":"Shouldn\u0027t this be exceptions.VimInvalidInput?","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"}],"tests/test_service.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d2d83a9716a0ef20657da8ede7a879e8dfb81126","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def test_request_handler_no_value(self, mock_moref):"},{"line_number":291,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":292,"context_line":"        svc_obj \u003d service.Service()"},{"line_number":293,"context_line":"        self.assertRaises(exceptions.VimException,"},{"line_number":294,"context_line":"                          svc_obj.UnregisterVM,"},{"line_number":295,"context_line":"                          managed_object)"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_a605ecc3","line":293,"updated":"2015-03-04 19:17:36.000000000","message":"Shouldn\u0027t this be exceptions.VimInvalidInput?","commit_id":"e1cefbdd5e9109dde6cd0964ca6f24f4f10461fa"}]}
