)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"aedeb987f30a012964c742fa2f0f46a4d3ae9713","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In different language circumstances, the vmware sdk call for some"},{"line_number":10,"context_line":"display properties will return different sentences, for example,"},{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With this change, user will be allowed to dedicate a locale in their"},{"line_number":15,"context_line":"program, so that their program will work on vcenters with various"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_88134266","line":12,"updated":"2015-05-08 06:18:32.000000000","message":"This sounds like a bug, no?  Is there any case of where this is currently a problem?","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"338bb9cba799c260e7115aa41ac3ed678d42c847","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In different language circumstances, the vmware sdk call for some"},{"line_number":10,"context_line":"display properties will return different sentences, for example,"},{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With this change, user will be allowed to dedicate a locale in their"},{"line_number":15,"context_line":"program, so that their program will work on vcenters with various"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_22000934","line":12,"in_reply_to":"1aca2d91_88134266","updated":"2015-05-15 08:15:56.000000000","message":"This is not a bug. Because when local is not assigned, the vcenter\u0027s locale configuration will be used.\nThat is to say, if the locale is not assigned, program\u0027s output may be different between vcenter of English locale and French locale.\n\nBy introducing this locale parameter, it will be much more flexible.","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9cb236bfe62836afe6e3f12b03f88f40d9d43483","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feng Xi Yan \u003cyanfengxi@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-15 17:21:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a local param to allow lacale specification."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In different language circumstances, the vmware sdk call for some"},{"line_number":10,"context_line":"display properties will return different sentences, for example,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_df6e9c2e","line":7,"updated":"2015-05-15 17:30:41.000000000","message":"s/lacle/locale","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"229afad00f16e4201226d4fe85e790864f472bb0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feng Xi Yan \u003cyanfengxi@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-15 17:21:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a local param to allow lacale specification."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In different language circumstances, the vmware sdk call for some"},{"line_number":10,"context_line":"display properties will return different sentences, for example,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_8f2a167d","line":7,"in_reply_to":"7a016987_df6e9c2e","updated":"2015-05-18 03:13:10.000000000","message":"Done","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9cb236bfe62836afe6e3f12b03f88f40d9d43483","unresolved":false,"context_lines":[{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will bring much flexiblities. With it, developers"},{"line_number":15,"context_line":"could spefify a locale in their vSphere API call, so that the"},{"line_number":16,"context_line":"return value will be in same locale no matter what locale is"},{"line_number":17,"context_line":"configured on vcenters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_1f5b1489","line":14,"updated":"2015-05-15 17:30:41.000000000","message":"I would prefer to hold off on this patch until the need arises for such support.  Like if there was a bug that demanded a locale specific string.","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"229afad00f16e4201226d4fe85e790864f472bb0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will bring much flexiblities. With it, developers"},{"line_number":15,"context_line":"could spefify a locale in their vSphere API call, so that the"},{"line_number":16,"context_line":"return value will be in same locale no matter what locale is"},{"line_number":17,"context_line":"configured on vcenters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_3c600201","line":14,"in_reply_to":"7a016987_1f5b1489","updated":"2015-05-18 03:13:10.000000000","message":"Eric, oslo.vmware is now a third party library, which means that not only openstack vmware driver but other projects can use it.\n\nIn our case, we are using it to get all the Virtual Devices of a Virtual Machine, and pick the first virtual device by it\u0027s label \"Hard Disk 1\". The \"Hard Disk 1\" is in English, and it may be different under other locales. So in our program, we should specify the local to \"EN_US\".\n\nTo speak on other side, the vSphere SDK has the feature of locale specification, as a wrap of the SDK, shouldn\u0027t oslo.vmware expose this feature to developers? And I don\u0027t think this change will bring any side effects.","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1591843706013c351989ea0f6fae9f5a31fe53e1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will bring much flexiblities. With it, developers"},{"line_number":15,"context_line":"could spefify a locale in their vSphere API call, so that the"},{"line_number":16,"context_line":"return value will be in same locale no matter what locale is"},{"line_number":17,"context_line":"configured on vcenters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_527165df","line":14,"in_reply_to":"7a016987_3c600201","updated":"2015-05-18 06:34:44.000000000","message":"Yes, I\u0027d like to see some bug associated with this.  If there is a need, there should be a bug.","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"bb110f2f3b964271eb6b16fadc1c8086239941b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"an instance\u0027s \u0027device.deviceInfo.summary\u0027 property will return"},{"line_number":12,"context_line":"\u00271323KB\u0027 in English locale, but \u00271323Ko\u0027 in French locale."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will bring much flexiblities. With it, developers"},{"line_number":15,"context_line":"could spefify a locale in their vSphere API call, so that the"},{"line_number":16,"context_line":"return value will be in same locale no matter what locale is"},{"line_number":17,"context_line":"configured on vcenters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_de72fe48","line":14,"in_reply_to":"7a016987_527165df","updated":"2015-05-18 09:41:24.000000000","message":"Done","commit_id":"9cf25538fa557846d4a1292bd33199e61b469d1c"}],"oslo_vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a3fb84a68dfad605148af8528d4b7e3cb75e87ac","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d self.vim.Login(session_manager,"},{"line_number":229,"context_line":"                                 userName\u003dself._server_username,"},{"line_number":230,"context_line":"                                 password\u003dself._server_password,"},{"line_number":231,"context_line":"                                 locale\u003d\u0027en_US\u0027)"},{"line_number":232,"context_line":"        self._session_id \u003d session.key"},{"line_number":233,"context_line":"        # We need to save the username in the session since we may need it"},{"line_number":234,"context_line":"        # later to check active session. The SessionIsActive method requires"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_ce8d077d","line":231,"updated":"2015-04-28 10:25:20.000000000","message":"This parameter is optional. Why we need to set this? As per login API doc \"The method uses the server default locale when a locale is not provided\".","commit_id":"9c14ecfc9c725ec8631d2be6516539314c2a8368"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"de311d1a7744c3ce696dcc8a1b75b366eb947b0b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        session \u003d self.vim.Login(session_manager,"},{"line_number":229,"context_line":"                                 userName\u003dself._server_username,"},{"line_number":230,"context_line":"                                 password\u003dself._server_password,"},{"line_number":231,"context_line":"                                 locale\u003d\u0027en_US\u0027)"},{"line_number":232,"context_line":"        self._session_id \u003d session.key"},{"line_number":233,"context_line":"        # We need to save the username in the session since we may need it"},{"line_number":234,"context_line":"        # later to check active session. The SessionIsActive method requires"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_59dd4741","line":231,"in_reply_to":"7ad32947_ce8d077d","updated":"2015-04-29 09:43:54.000000000","message":"Done","commit_id":"9c14ecfc9c725ec8631d2be6516539314c2a8368"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"979839b018b4303464d94797c9a9314e2d3bd9f5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                       TLS (https) server certificate."},{"line_number":159,"context_line":"        :param insecure: Verify HTTPS connections using system certificates,"},{"line_number":160,"context_line":"                         used only if cacert is not specified"},{"line_number":161,"context_line":"        :param locale: locale of sdk call"},{"line_number":162,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":163,"context_line":"                 VimSessionOverLoadException"},{"line_number":164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_9bca936d","line":161,"updated":"2015-05-07 09:54:12.000000000","message":"Add a comment saying that the locale will be default locale of the vCenter server if unspecified.","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"161c1417dd3fcd4e60245e5ec38645e34814cd4a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                       TLS (https) server certificate."},{"line_number":159,"context_line":"        :param insecure: Verify HTTPS connections using system certificates,"},{"line_number":160,"context_line":"                         used only if cacert is not specified"},{"line_number":161,"context_line":"        :param locale: locale of sdk call"},{"line_number":162,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":163,"context_line":"                 VimSessionOverLoadException"},{"line_number":164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_9eaba1d6","line":161,"in_reply_to":"1aca2d91_9bca936d","updated":"2015-05-07 10:11:23.000000000","message":"+1","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"338bb9cba799c260e7115aa41ac3ed678d42c847","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                       TLS (https) server certificate."},{"line_number":159,"context_line":"        :param insecure: Verify HTTPS connections using system certificates,"},{"line_number":160,"context_line":"                         used only if cacert is not specified"},{"line_number":161,"context_line":"        :param locale: locale of sdk call"},{"line_number":162,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":163,"context_line":"                 VimSessionOverLoadException"},{"line_number":164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_e2f9d14e","line":161,"in_reply_to":"1aca2d91_9bca936d","updated":"2015-05-15 08:15:56.000000000","message":"Good catch, will do it.","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"aedeb987f30a012964c742fa2f0f46a4d3ae9713","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                       TLS (https) server certificate."},{"line_number":159,"context_line":"        :param insecure: Verify HTTPS connections using system certificates,"},{"line_number":160,"context_line":"                         used only if cacert is not specified"},{"line_number":161,"context_line":"        :param locale: locale of sdk call"},{"line_number":162,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":163,"context_line":"                 VimSessionOverLoadException"},{"line_number":164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_c8325a10","line":161,"in_reply_to":"1aca2d91_9eaba1d6","updated":"2015-05-08 06:18:32.000000000","message":"What\u0027s the expected format of the locale string?  Is this Posix locale format?  Could you update this with that expectation?","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"338bb9cba799c260e7115aa41ac3ed678d42c847","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                       TLS (https) server certificate."},{"line_number":159,"context_line":"        :param insecure: Verify HTTPS connections using system certificates,"},{"line_number":160,"context_line":"                         used only if cacert is not specified"},{"line_number":161,"context_line":"        :param locale: locale of sdk call"},{"line_number":162,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":163,"context_line":"                 VimSessionOverLoadException"},{"line_number":164,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c295b5e4","line":161,"in_reply_to":"1aca2d91_c8325a10","updated":"2015-05-15 08:15:56.000000000","message":"Yes, I will add example format of this parameter.","commit_id":"f6d44fb1455dd0e0af1ead5fbc60a46487f52e5f"}]}