)]}'
{"oslo_vmware/rw_handles.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7bf4d4964f048133b0f0065ee06447366283b981","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":625,"context_line":"        return self._vmdk_size"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_92c41c93","line":624,"range":{"start_line":624,"start_character":14,"end_line":624,"end_character":15},"updated":"2016-02-15 02:47:07.000000000","message":"Get the size....","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"ef36cf7addd5fa42a19b53b75256d6a52613141b","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":625,"context_line":"        return self._vmdk_size"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a2455cb4","line":624,"range":{"start_line":624,"start_character":14,"end_line":624,"end_character":15},"in_reply_to":"dae33548_92c41c93","updated":"2016-02-16 06:41:13.000000000","message":"Done","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f83868ec11016ca6b9c7be8dbe576526b854e0a4","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":625,"context_line":"        return self._vmdk_size"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def __str__(self):"},{"line_number":628,"context_line":"        return \"VMDK read handle for %s\" % self._url"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b8f81a7e","line":625,"updated":"2016-02-15 08:51:17.000000000","message":"Will there be any side-effect due to this because the number of bytes read will be less than or equal to the vmdk size. See the comment in line 495.","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"ef36cf7addd5fa42a19b53b75256d6a52613141b","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":625,"context_line":"        return self._vmdk_size"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def __str__(self):"},{"line_number":628,"context_line":"        return \"VMDK read handle for %s\" % self._url"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_22eb0cb2","line":625,"in_reply_to":"dae33548_b8f81a7e","updated":"2016-02-16 06:41:13.000000000","message":"Yes, good catch!","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7bf4d4964f048133b0f0065ee06447366283b981","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        pass"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def get_size(self):"},{"line_number":669,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":670,"context_line":"        return self._file_size"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_12376cb1","line":669,"range":{"start_line":669,"start_character":14,"end_line":669,"end_character":15},"updated":"2016-02-15 02:47:07.000000000","message":"Get the size...","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"ef36cf7addd5fa42a19b53b75256d6a52613141b","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        pass"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def get_size(self):"},{"line_number":669,"context_line":"        \"\"\"Get size of the file to be read.\"\"\""},{"line_number":670,"context_line":"        return self._file_size"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_021368b9","line":669,"range":{"start_line":669,"start_character":14,"end_line":669,"end_character":15},"in_reply_to":"dae33548_12376cb1","updated":"2016-02-16 06:41:13.000000000","message":"Done","commit_id":"42b603462886cfc5cb83af59415d52c75ed4fb74"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e91654e4bb1f68b26c22e5fb95e8f0e11a21d62b","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get the size of the file to be read."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        The size of the VMDK file read may be smaller than the actual"},{"line_number":627,"context_line":"        VMDK size, therefore, returns 0 which represents the unknown"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_1751ac36","line":624,"range":{"start_line":624,"start_character":11,"end_line":624,"end_character":47},"updated":"2016-02-17 03:23:00.000000000","message":"I\u0027m not really clear why have a method that just returns 0.  Besides, the title here is misleading, since it\u0027ll never return the size of a file.","commit_id":"e6b34b0514629882b1471eac9ea47c7516ff3c71"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"1f8098a535d0d1ef102e501307b66f7fe304743e","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def get_size(self):"},{"line_number":624,"context_line":"        \"\"\"Get the size of the file to be read."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        The size of the VMDK file read may be smaller than the actual"},{"line_number":627,"context_line":"        VMDK size, therefore, returns 0 which represents the unknown"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_9d58368c","line":624,"range":{"start_line":624,"start_character":11,"end_line":624,"end_character":47},"in_reply_to":"dae33548_1751ac36","updated":"2016-02-17 07:41:14.000000000","message":"Thanks for Eric\u0027s review. The reason is to let io_util.ThreadSafePipe get transfer_size from FileHandle.get_size(), but we can not get the size of the VMDK file read, because the VM\u0027s disk capacity will not be the image size after download, since it is converted to a stream-optimized sparse disk.\nI will remove the misleading title.\nhttps://review.openstack.org/#/c/280007/4/nova/virt/vmwareapi/images.py\nhttps://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/io_util.py#L57","commit_id":"e6b34b0514629882b1471eac9ea47c7516ff3c71"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e91654e4bb1f68b26c22e5fb95e8f0e11a21d62b","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        \"\"\"Get the size of the file to be read."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        The size of the VMDK file read may be smaller than the actual"},{"line_number":627,"context_line":"        VMDK size, therefore, returns 0 which represents the unknown"},{"line_number":628,"context_line":"        size instead of self._vmdk_size."},{"line_number":629,"context_line":"        \"\"\""},{"line_number":630,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_975dbc49","line":627,"range":{"start_line":627,"start_character":30,"end_line":627,"end_character":37},"updated":"2016-02-17 03:23:00.000000000","message":"therefore this method returns 0...","commit_id":"e6b34b0514629882b1471eac9ea47c7516ff3c71"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"1f8098a535d0d1ef102e501307b66f7fe304743e","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        \"\"\"Get the size of the file to be read."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        The size of the VMDK file read may be smaller than the actual"},{"line_number":627,"context_line":"        VMDK size, therefore, returns 0 which represents the unknown"},{"line_number":628,"context_line":"        size instead of self._vmdk_size."},{"line_number":629,"context_line":"        \"\"\""},{"line_number":630,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_bdda5ae6","line":627,"range":{"start_line":627,"start_character":30,"end_line":627,"end_character":37},"in_reply_to":"dae33548_975dbc49","updated":"2016-02-17 07:41:14.000000000","message":"OK","commit_id":"e6b34b0514629882b1471eac9ea47c7516ff3c71"}]}