)]}'
{"oslo_vmware/image_transfer.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc00e3da417d7229988aaea12ed4d3023b5a9839","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                    if not data:"},{"line_number":272,"context_line":"                        LOG.debug(\"File read-write task is done.\")"},{"line_number":273,"context_line":"                        self.stop()"},{"line_number":274,"context_line":"                        self._progress_updater.stop()"},{"line_number":275,"context_line":"                        self._done.send(True)"},{"line_number":276,"context_line":"                    self._output_file.write(data)"},{"line_number":277,"context_line":"                    greenthread.sleep(FILE_READ_WRITE_TASK_SLEEP_TIME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_6044ac1a","line":274,"updated":"2016-02-17 05:30:37.000000000","message":"Can we move this to stop() method?","commit_id":"f7b7dd2426b13e7055bc774a4332240819e1b101"}],"oslo_vmware/tests/test_image_transfer.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc00e3da417d7229988aaea12ed4d3023b5a9839","unresolved":false,"context_lines":[{"line_number":149,"context_line":"class FileReadWriteTaskTest(base.TestCase):"},{"line_number":150,"context_line":"    \"\"\"Tests for FileReadWriteTask class.\"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_start(self):"},{"line_number":153,"context_line":"        data_items \u003d [[1] * 10, [1] * 20, [1] * 5, []]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        def input_file_read_side_effect(arg):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a03eb425","line":152,"updated":"2016-02-17 05:30:37.000000000","message":"I think it is better to mock the FixedIntervalLoopingCall and assert that the start and stop methods are called.","commit_id":"f7b7dd2426b13e7055bc774a4332240819e1b101"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc00e3da417d7229988aaea12ed4d3023b5a9839","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            exp_calls.append(mock.call(data_items[i]))"},{"line_number":173,"context_line":"        self.assertEqual(exp_calls, output_file.write.call_args_list)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.assertTrue(input_file.update_progress.called)"},{"line_number":176,"context_line":"        self.assertTrue(output_file.update_progress.called)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_start_with_read_exception(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_60014c6a","line":175,"updated":"2016-02-17 05:30:37.000000000","message":"It looks like _progress_updater calls the _update_progress method before any sleep, is that correct?","commit_id":"f7b7dd2426b13e7055bc774a4332240819e1b101"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc00e3da417d7229988aaea12ed4d3023b5a9839","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertTrue(input_file.update_progress.called)"},{"line_number":176,"context_line":"        self.assertTrue(output_file.update_progress.called)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_start_with_read_exception(self):"},{"line_number":179,"context_line":"        input_file \u003d mock.Mock()"},{"line_number":180,"context_line":"        input_file.read.side_effect \u003d RuntimeError()"},{"line_number":181,"context_line":"        output_file \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e0443cb8","line":178,"updated":"2016-02-17 05:30:37.000000000","message":"I think it is better to mock the FixedIntervalLoopingCall and assert that the start and stop methods are called.","commit_id":"f7b7dd2426b13e7055bc774a4332240819e1b101"}]}