)]}'
{"oslo_vmware/rw_handles.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"aff85123a8d1be8502e3e42692d10df38087e70d","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    def close(self):"},{"line_number":589,"context_line":"        \"\"\"Releases the lease and close the connection."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":592,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":593,"context_line":"        \"\"\""},{"line_number":594,"context_line":"        LOG.debug(\"Getting lease state for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_7eda63e9","line":591,"range":{"start_line":591,"start_character":17,"end_line":591,"end_character":29},"updated":"2016-02-17 18:33:25.000000000","message":"This exception is no longer raised.  So the docstring needs update.  Also, this might break code existing code that had a try-except for VimException which now is no longer raised.","commit_id":"5dac6303584ea80973a0060198698ffac0fefc59"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"0b5ff53c26aa239753efa0d3785895223646d6e3","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    def close(self):"},{"line_number":589,"context_line":"        \"\"\"Releases the lease and close the connection."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":592,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":593,"context_line":"        \"\"\""},{"line_number":594,"context_line":"        LOG.debug(\"Getting lease state for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_38773d03","line":591,"range":{"start_line":591,"start_character":17,"end_line":591,"end_character":29},"in_reply_to":"dae33548_7eda63e9","updated":"2016-02-18 03:23:31.000000000","message":"Thank you, I\u0027ll update it.","commit_id":"5dac6303584ea80973a0060198698ffac0fefc59"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"40236a86fcf09c8a6334e9aac54eaa3d121de4de","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    def close(self):"},{"line_number":589,"context_line":"        \"\"\"Releases the lease and close the connection."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :raises: VimAttributeException, VimSessionOverLoadException,"},{"line_number":592,"context_line":"                 VimConnectionException"},{"line_number":593,"context_line":"        \"\"\""},{"line_number":594,"context_line":"        LOG.debug(\"Getting lease state for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_52b93d2d","line":591,"range":{"start_line":591,"start_character":9,"end_line":591,"end_character":15},"updated":"2016-02-18 05:14:44.000000000","message":"I\u0027m not sure I like how the signature of the method has now changed.  It can potentially break code that had a try-except condition on VimException.","commit_id":"60c38e5015b43863f9357827af35ed305d2d43ac"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"04d08b519b17e3e29f5ccbd78e2fa8c2df26bf6c","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    def close(self):"},{"line_number":589,"context_line":"        \"\"\"Releases the lease and close the connection."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :raises: VimAttributeException, VimSessionOverLoadException,"},{"line_number":592,"context_line":"                 VimConnectionException"},{"line_number":593,"context_line":"        \"\"\""},{"line_number":594,"context_line":"        LOG.debug(\"Getting lease state for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_eb24d80d","line":591,"range":{"start_line":591,"start_character":9,"end_line":591,"end_character":15},"in_reply_to":"dae33548_52b93d2d","updated":"2016-02-18 07:49:32.000000000","message":"I have checked ComputeManager.backup_instance() which would call this close() method, and not found a try-except condition on VimException.\n\nThere is just a finally in VMwareVMOps.snapshot() that may be affected, but the finally will be executed regardless of whether an exception is thrown.","commit_id":"60c38e5015b43863f9357827af35ed305d2d43ac"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"40236a86fcf09c8a6334e9aac54eaa3d121de4de","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"        super(VmdkReadHandle, self).close()"},{"line_number":620,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_723d618e","line":619,"updated":"2016-02-18 05:14:44.000000000","message":"Why not just put the close in a finally?","commit_id":"60c38e5015b43863f9357827af35ed305d2d43ac"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"04d08b519b17e3e29f5ccbd78e2fa8c2df26bf6c","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"        super(VmdkReadHandle, self).close()"},{"line_number":620,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_06013338","line":619,"in_reply_to":"dae33548_723d618e","updated":"2016-02-18 07:49:32.000000000","message":"It is a good idea! but I\u0027m not sure whether we should be consistent with VmdkWriteHandle.close() in Line 475 of this file.\nI think this may be a problem of whether it should raise an exception after releasing the lease fails.","commit_id":"60c38e5015b43863f9357827af35ed305d2d43ac"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"760c1abe366c8be3a9b1e468109b8863e01be97b","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"            raise"},{"line_number":620,"context_line":"        finally:"},{"line_number":621,"context_line":"            super(VmdkReadHandle, self).close()"},{"line_number":622,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_72b8ab75","line":619,"updated":"2016-03-10 14:11:46.000000000","message":"We only need to log the warning. I think we can remove this. See VmdkWriteHandle.close()","commit_id":"3d00ecf534d1ce78a18346e28dfdf9507aafca0d"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"46a55a72550ae0d3214d6539e4f3efbee416a558","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"            raise"},{"line_number":620,"context_line":"        finally:"},{"line_number":621,"context_line":"            super(VmdkReadHandle, self).close()"},{"line_number":622,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_266421b7","line":619,"in_reply_to":"5aef4532_10c4bf3d","updated":"2016-03-10 15:03:57.000000000","message":"It seems to need a discussion:-)","commit_id":"3d00ecf534d1ce78a18346e28dfdf9507aafca0d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"07655933e926f05e600a2426c936a75b40f1bcc3","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"            raise"},{"line_number":620,"context_line":"        finally:"},{"line_number":621,"context_line":"            super(VmdkReadHandle, self).close()"},{"line_number":622,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_a971210e","line":619,"in_reply_to":"5aef4532_266421b7","updated":"2016-03-10 15:37:16.000000000","message":"I couldn\u0027t find any client relying on this behavior. AFAIK it is called only in image_transfer._start_transfer. But since this class and the close() method is not marked as private, let\u0027s keep it.","commit_id":"3d00ecf534d1ce78a18346e28dfdf9507aafca0d"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"25a2389c675c7ee10acaefc27efded8735da6ad8","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                            \"for %s.\"),"},{"line_number":617,"context_line":"                        self._url,"},{"line_number":618,"context_line":"                        exc_info\u003dTrue)"},{"line_number":619,"context_line":"            raise"},{"line_number":620,"context_line":"        finally:"},{"line_number":621,"context_line":"            super(VmdkReadHandle, self).close()"},{"line_number":622,"context_line":"        LOG.debug(\"Closed VMDK read handle for %s.\", self._url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_10c4bf3d","line":619,"in_reply_to":"5aef4532_72b8ab75","updated":"2016-03-10 15:01:18.000000000","message":"Thanks for your review, we did it like this in the patch set 2, to follow Eric\u0027s comments we added the finally.","commit_id":"3d00ecf534d1ce78a18346e28dfdf9507aafca0d"}]}