)]}'
{"oslo_vmware/rw_handles.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f504e5cb3eda5ee8d5b753f76c8357198a4d62e3","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                            \"for %s.\"),"},{"line_number":500,"context_line":"                        self._url,"},{"line_number":501,"context_line":"                        exc_info\u003dTrue)"},{"line_number":502,"context_line":"        finally:"},{"line_number":503,"context_line":"            super(VmdkWriteHandle, self).close()"},{"line_number":504,"context_line":"        LOG.debug(\"Closed VMDK write handle for %s.\", self._url)"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3250e331","line":502,"updated":"2016-03-10 14:13:01.000000000","message":"This is not needed.","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"d0a41b8cb68457719bc20623b330aa6432da7468","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                            \"for %s.\"),"},{"line_number":500,"context_line":"                        self._url,"},{"line_number":501,"context_line":"                        exc_info\u003dTrue)"},{"line_number":502,"context_line":"        finally:"},{"line_number":503,"context_line":"            super(VmdkWriteHandle, self).close()"},{"line_number":504,"context_line":"        LOG.debug(\"Closed VMDK write handle for %s.\", self._url)"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e0231ca6","line":502,"in_reply_to":"5aef4532_3250e331","updated":"2016-03-11 05:58:10.000000000","message":"Done","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"ff28b91699fd2f370a36fd2725ad6da23008ad7c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                  \"with URL \u003d %s.\"),"},{"line_number":313,"context_line":"                              self._url)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _release_lease(self, lease):"},{"line_number":316,"context_line":"        \"\"\"Release the lease"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_d47a3723","line":315,"range":{"start_line":315,"start_character":27,"end_line":315,"end_character":34},"updated":"2016-05-23 08:55:55.000000000","message":"We don\u0027t need this argument, we can use self._lease.","commit_id":"861927f825f10b8c4faf7dd58361ad506571ed1a"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"53658cf0c21af64eae104f70d85f6518275adcc7","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                  \"with URL \u003d %s.\"),"},{"line_number":313,"context_line":"                              self._url)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _release_lease(self, lease):"},{"line_number":316,"context_line":"        \"\"\"Release the lease"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_b8854fae","line":315,"range":{"start_line":315,"start_character":27,"end_line":315,"end_character":34},"in_reply_to":"bab6814e_d47a3723","updated":"2016-05-31 02:50:50.000000000","message":"Yes, thanks.\nWhen I wrote _release_lease() self._lease does not exist, add I forget to change this method after adding \"_lease\" as a member to the class.","commit_id":"861927f825f10b8c4faf7dd58361ad506571ed1a"}],"oslo_vmware/tests/test_rw_handles.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"caacec8500e2c20216a9599b35336223376d7544","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        handle.write([1] * data_size)"},{"line_number":225,"context_line":"        handle.update_progress()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_update_progress_with_error(self):"},{"line_number":228,"context_line":"        session \u003d self._create_mock_session(True, 10)"},{"line_number":229,"context_line":"        handle \u003d rw_handles.VmdkWriteHandle(session, \u002710.1.2.3\u0027, 443,"},{"line_number":230,"context_line":"                                            \u0027rp-1\u0027, \u0027folder-1\u0027, None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3c155f9b","line":227,"updated":"2016-03-10 12:08:42.000000000","message":"We can move upgrade_progress tests to VmdkHandleTest.","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"d0a41b8cb68457719bc20623b330aa6432da7468","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        handle.write([1] * data_size)"},{"line_number":225,"context_line":"        handle.update_progress()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_update_progress_with_error(self):"},{"line_number":228,"context_line":"        session \u003d self._create_mock_session(True, 10)"},{"line_number":229,"context_line":"        handle \u003d rw_handles.VmdkWriteHandle(session, \u002710.1.2.3\u0027, 443,"},{"line_number":230,"context_line":"                                            \u0027rp-1\u0027, \u0027folder-1\u0027, None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_8354e2ca","line":227,"in_reply_to":"5aef4532_3c155f9b","updated":"2016-03-11 05:58:10.000000000","message":"Done","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"caacec8500e2c20216a9599b35336223376d7544","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        data \u003d handle.read(chunk_size)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027fake-data\u0027, data)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_update_progress(self):"},{"line_number":313,"context_line":"        chunk_size \u003d len(\u0027fake-data\u0027)"},{"line_number":314,"context_line":"        vmdk_size \u003d chunk_size * 10"},{"line_number":315,"context_line":"        session \u003d self._create_mock_session(True, 10)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3c7c3feb","line":312,"updated":"2016-03-10 12:08:42.000000000","message":"We can move upgrade_progress tests to VmdkHandleTest.","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5afee52b6671666ecbc3fdca57c00ad5aaa6cdc8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        data \u003d handle.read(chunk_size)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027fake-data\u0027, data)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_update_progress(self):"},{"line_number":313,"context_line":"        chunk_size \u003d len(\u0027fake-data\u0027)"},{"line_number":314,"context_line":"        vmdk_size \u003d chunk_size * 10"},{"line_number":315,"context_line":"        session \u003d self._create_mock_session(True, 10)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_71ffe0aa","line":312,"in_reply_to":"5aef4532_035732cb","updated":"2016-03-11 07:33:45.000000000","message":"Ignore these tests and write a new test for upgrade_progess in VmdkHandleTest after creating mocks for all its dependencies.","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"680f9570789fdd9baa30f27a2bbce551e0985fcd","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        data \u003d handle.read(chunk_size)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027fake-data\u0027, data)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_update_progress(self):"},{"line_number":313,"context_line":"        chunk_size \u003d len(\u0027fake-data\u0027)"},{"line_number":314,"context_line":"        vmdk_size \u003d chunk_size * 10"},{"line_number":315,"context_line":"        session \u003d self._create_mock_session(True, 10)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6dd0cfc9","line":312,"in_reply_to":"5aef4532_3c7c3feb","updated":"2016-03-10 13:01:33.000000000","message":"OK","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"d0a41b8cb68457719bc20623b330aa6432da7468","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        data \u003d handle.read(chunk_size)"},{"line_number":310,"context_line":"        self.assertEqual(\u0027fake-data\u0027, data)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_update_progress(self):"},{"line_number":313,"context_line":"        chunk_size \u003d len(\u0027fake-data\u0027)"},{"line_number":314,"context_line":"        vmdk_size \u003d chunk_size * 10"},{"line_number":315,"context_line":"        session \u003d self._create_mock_session(True, 10)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_035732cb","line":312,"in_reply_to":"5aef4532_6dd0cfc9","updated":"2016-03-11 05:58:10.000000000","message":"This might relate to VmdkReadHandle.read(), so I think it is better to keep it.","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"d0a41b8cb68457719bc20623b330aa6432da7468","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        handle \u003d rw_handles.VmdkReadHandle(session, \u002710.1.2.3\u0027, 443,"},{"line_number":317,"context_line":"                                           \u0027vm-1\u0027, \u0027[ds] disk1.vmdk\u0027,"},{"line_number":318,"context_line":"                                           vmdk_size)"},{"line_number":319,"context_line":"        data \u003d handle.read(chunk_size)"},{"line_number":320,"context_line":"        handle.update_progress()"},{"line_number":321,"context_line":"        self.assertEqual(\u0027fake-data\u0027, data)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a308feda","line":319,"range":{"start_line":319,"start_character":22,"end_line":319,"end_character":26},"updated":"2016-03-11 05:58:10.000000000","message":"VmdkReadHandle.read()","commit_id":"2548990da6f924760c2f8fbdf947b7fd45aec093"}]}