)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"bb3d7b418de8fc37c936894375a2033db13211bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-16 22:34:08 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass tcp time out to re-establish the connection to vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"looses connectivity with vCenter because default timeout is set to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_90ac6aee","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":13},"updated":"2016-06-18 13:28:17.000000000","message":"s/time out/timeout","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-16 22:34:08 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass tcp time out to re-establish the connection to vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"looses connectivity with vCenter because default timeout is set to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_5b8645ba","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":13},"in_reply_to":"7aa08908_90ac6aee","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass tcp time out to re-establish the connection to vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"looses connectivity with vCenter because default timeout is set to"},{"line_number":11,"context_line":"None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass tcp timeout so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_7d0a8ad3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"updated":"2016-06-17 18:59:22.000000000","message":"loses","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass tcp time out to re-establish the connection to vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"looses connectivity with vCenter because default timeout is set to"},{"line_number":11,"context_line":"None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass tcp timeout so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_bb93e9f9","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"in_reply_to":"7aa08908_7d0a8ad3","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"bb3d7b418de8fc37c936894375a2033db13211bb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass tcp timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then through an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_10a07af3","line":14,"range":{"start_line":14,"start_character":44,"end_line":14,"end_character":51},"updated":"2016-06-18 13:28:17.000000000","message":"s/through/throw","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":11,"context_line":"None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass tcp timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then through an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_9b90adee","line":14,"range":{"start_line":14,"start_character":44,"end_line":14,"end_character":51},"in_reply_to":"7aa08908_10a07af3","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d04f64699ca914faf9043bc906aa5d1f775889b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"},{"line_number":11,"context_line":"is set to None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass connection timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then throw an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3aaa91ec_832d3000","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":64},"updated":"2016-06-30 14:26:09.000000000","message":"How is it possible without adding a param in VMwareAPISession and using it in vim() and pbm()? Also we have to update Service init.","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"be77904a3c8c0f0c1063fc870458bbc40636c23f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"},{"line_number":11,"context_line":"is set to None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass connection timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then throw an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3aaa91ec_f23800f1","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":64},"in_reply_to":"3aaa91ec_350d6be8","updated":"2016-07-01 13:50:54.000000000","message":"Ok, but adding a param in VMwareAPISession with a default value may be a better approach.","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"9730576f609657bf8f81a53e8b37a1964bb313ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"},{"line_number":11,"context_line":"is set to None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass connection timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then throw an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3aaa91ec_350d6be8","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":64},"in_reply_to":"3aaa91ec_832d3000","updated":"2016-07-01 06:27:30.000000000","message":"This is how we are setting the timeout throw our application: self.vim.client.options.transport.set_tcp_timeout(120)","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"6e53ce5ec7103971006296240a9bbdfc0e952b3d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"},{"line_number":11,"context_line":"is set to None which is equivalent to infinity."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch set allows any application to pass connection timeout so that"},{"line_number":14,"context_line":"it will wait for the given timeout and then throw an exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1564839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1aa78d24_26fc436f","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":64},"in_reply_to":"3aaa91ec_f23800f1","updated":"2016-07-07 06:54:26.000000000","message":"Done","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"ee3e6a25325d3bf7b1ed98e0235f9279daef4600","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 00:04:54 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass connection timeout to re-establish the connection with vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_13b3544e","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":67},"updated":"2016-07-12 17:22:45.000000000","message":"We are not re-establishing the connection. We set the timeout so that invoke_api will not wait forever if the network interface goes down and raises a connection error. I guess the clients need to catch the exception and handle it. But then we should document the exception raised in the invoke_api doc comment. What do you think?","commit_id":"fca8da5e7f28f92b5630fa128d49d9acb3c474b6"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"ea54f9ec039f4a990168ebc875c7eab22f4edab3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 00:04:54 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass connection timeout to re-establish the connection with vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_72872961","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":67},"in_reply_to":"1aa78d24_13b3544e","updated":"2016-07-12 20:51:24.000000000","message":"No need for client to catch the exception and handle it. Once network interface will go up every thing will be taken care and connection will be re-established.","commit_id":"fca8da5e7f28f92b5630fa128d49d9acb3c474b6"},{"author":{"_account_id":10368,"name":"Raghuveer Shenoy","email":"rshenoy@hpe.com","username":"RaghuveerShenoy"},"change_message_id":"724bb98e49476aa7f5819b44b73b831dc48ff998","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 00:04:54 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass connection timeout to re-establish the connection with vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_9a6a9f18","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":67},"in_reply_to":"1aa78d24_72872961","updated":"2016-07-13 04:49:42.000000000","message":"@Aman, Vipin is right. We should change commit message and need to add necessary comment in invoke_api method. Our client tries to re-establish the connection does not mean that all clients will/should do the same.","commit_id":"fca8da5e7f28f92b5630fa128d49d9acb3c474b6"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"d978b9aaf0271ad560102e0aa38582bfe441ad8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aman Kumar \u003caman.kumar3@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 00:04:54 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass connection timeout to re-establish the connection with vCenter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"invoke_api does not throw any exception when interface goes down and"},{"line_number":10,"context_line":"application loses connectivity with vCenter because default timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_d484d20c","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":67},"in_reply_to":"1aa78d24_9a6a9f18","updated":"2016-07-13 18:27:52.000000000","message":"Done","commit_id":"fca8da5e7f28f92b5630fa128d49d9acb3c474b6"}],"oslo_vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                         used only if cacert is not specified"},{"line_number":163,"context_line":"        :param pool_size: Maximum number of connections in http"},{"line_number":164,"context_line":"                          connection pool"},{"line_number":165,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":166,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":167,"context_line":"                                   if the network interface goes down"},{"line_number":168,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":169,"context_line":"                 VimSessionOverLoadException"},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_5b335e14","line":167,"range":{"start_line":165,"start_character":35,"end_line":167,"end_character":69},"updated":"2016-07-20 10:00:45.000000000","message":"Is it in seconds?\n\nI would rephrase it as:\n\nMaximum time in seconds to wait if the network interface goes down.\n\nI think this is even applicable for APIs like login() and not just invoke_api.","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                         used only if cacert is not specified"},{"line_number":163,"context_line":"        :param pool_size: Maximum number of connections in http"},{"line_number":164,"context_line":"                          connection pool"},{"line_number":165,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":166,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":167,"context_line":"                                   if the network interface goes down"},{"line_number":168,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":169,"context_line":"                 VimSessionOverLoadException"},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_c498d86c","line":167,"range":{"start_line":165,"start_character":35,"end_line":167,"end_character":69},"in_reply_to":"dada55a8_5b335e14","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                    # Re-create the session during connection exception only"},{"line_number":345,"context_line":"                    # if the session has expired. Otherwise, it could be"},{"line_number":346,"context_line":"                    # a transient issue."},{"line_number":347,"context_line":"                    # In case of any other exception where session is active,"},{"line_number":348,"context_line":"                    # just throw an vim connection exception and let client"},{"line_number":349,"context_line":"                    # to catch the exception and handle it."},{"line_number":350,"context_line":"                    if not self.is_current_session_active():"},{"line_number":351,"context_line":"                        LOG.debug(\"Re-creating session due to connection \""},{"line_number":352,"context_line":"                                  \"problems while invoking method \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f6434940","line":349,"range":{"start_line":347,"start_character":19,"end_line":349,"end_character":59},"updated":"2016-07-20 10:00:45.000000000","message":"This is obvious from the comment above.","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                    # Re-create the session during connection exception only"},{"line_number":345,"context_line":"                    # if the session has expired. Otherwise, it could be"},{"line_number":346,"context_line":"                    # a transient issue."},{"line_number":347,"context_line":"                    # In case of any other exception where session is active,"},{"line_number":348,"context_line":"                    # just throw an vim connection exception and let client"},{"line_number":349,"context_line":"                    # to catch the exception and handle it."},{"line_number":350,"context_line":"                    if not self.is_current_session_active():"},{"line_number":351,"context_line":"                        LOG.debug(\"Re-creating session due to connection \""},{"line_number":352,"context_line":"                                  \"problems while invoking method \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_24f7345a","line":349,"range":{"start_line":347,"start_character":19,"end_line":349,"end_character":59},"in_reply_to":"dada55a8_f6434940","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4bafc0a83474d9a17a8e30a0627b4643bcb1abab","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                         used only if cacert is not specified"},{"line_number":163,"context_line":"        :param pool_size: Maximum number of connections in http"},{"line_number":164,"context_line":"                          connection pool"},{"line_number":165,"context_line":"        :param connection_timeout: Maximum time in seconds to wait if the"},{"line_number":166,"context_line":"                                   network interface goes down."},{"line_number":167,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":168,"context_line":"                 VimSessionOverLoadException"},{"line_number":169,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_126b69ba","line":166,"range":{"start_line":165,"start_character":67,"end_line":166,"end_character":62},"updated":"2016-07-26 17:06:31.000000000","message":"This is weird statement since there are many reasons for a connection timeout, not just network interface going down.","commit_id":"7f14806429c1f6d276b53ac0935ac76842e6b429"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"21d3f143e2c0a9cd641dab8d7e949d52bd7401f9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                         used only if cacert is not specified"},{"line_number":163,"context_line":"        :param pool_size: Maximum number of connections in http"},{"line_number":164,"context_line":"                          connection pool"},{"line_number":165,"context_line":"        :param connection_timeout: Maximum time in seconds to wait if the"},{"line_number":166,"context_line":"                                   network interface goes down."},{"line_number":167,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":168,"context_line":"                 VimSessionOverLoadException"},{"line_number":169,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_5193d85a","line":166,"range":{"start_line":165,"start_character":67,"end_line":166,"end_character":62},"in_reply_to":"dada55a8_126b69ba","updated":"2016-08-02 07:18:32.000000000","message":"Done","commit_id":"7f14806429c1f6d276b53ac0935ac76842e6b429"}],"oslo_vmware/pbm.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                         used only if cacert is not specified"},{"line_number":56,"context_line":"        :param pool_maxsize: Maximum number of connections in http"},{"line_number":57,"context_line":"                             connection pool"},{"line_number":58,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":59,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":60,"context_line":"                                   if the network interface goes down"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        base_url \u003d service.Service.build_base_url(protocol, host, port)"},{"line_number":63,"context_line":"        soap_url \u003d base_url + \u0027/pbm\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_d66725e7","line":60,"range":{"start_line":58,"start_character":35,"end_line":60,"end_character":69},"updated":"2016-07-20 10:00:45.000000000","message":"same comment","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                         used only if cacert is not specified"},{"line_number":56,"context_line":"        :param pool_maxsize: Maximum number of connections in http"},{"line_number":57,"context_line":"                             connection pool"},{"line_number":58,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":59,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":60,"context_line":"                                   if the network interface goes down"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        base_url \u003d service.Service.build_base_url(protocol, host, port)"},{"line_number":63,"context_line":"        soap_url \u003d base_url + \u0027/pbm\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e4cfdc53","line":60,"range":{"start_line":58,"start_character":35,"end_line":60,"end_character":69},"in_reply_to":"dada55a8_d66725e7","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"}],"oslo_vmware/service.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        self.cookiejar \u003d self.session.cookies"},{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3d1482e7","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":23},"updated":"2016-06-17 18:59:22.000000000","message":"Kinda redundant to state TCP since it uses http which is tcp based.","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        self.cookiejar \u003d self.session.cookies"},{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_5b23e505","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":23},"in_reply_to":"7aa08908_3d1482e7","updated":"2016-06-20 06:32:52.000000000","message":"For this i have 2 options:\nconnection_timeout and application_timeout. I will update with connection_timeout, what do you say?","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fd1dda0f","line":149,"range":{"start_line":149,"start_character":19,"end_line":149,"end_character":22},"updated":"2016-06-17 18:59:22.000000000","message":"s/tcp/TCP","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fde4ba0d","line":149,"range":{"start_line":149,"start_character":55,"end_line":149,"end_character":62},"updated":"2016-06-17 18:59:22.000000000","message":"throw","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_5bada530","line":149,"range":{"start_line":149,"start_character":19,"end_line":149,"end_character":22},"in_reply_to":"7aa08908_fd1dda0f","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.tcp_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_db7d15e9","line":149,"range":{"start_line":149,"start_character":55,"end_line":149,"end_character":62},"in_reply_to":"7aa08908_fde4ba0d","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3dc2c253","line":150,"range":{"start_line":150,"start_character":29,"end_line":150,"end_character":69},"updated":"2016-06-17 18:59:22.000000000","message":"in case the VM lost connectivity with vCenter","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_tcp_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_db64f54a","line":150,"range":{"start_line":150,"start_character":29,"end_line":150,"end_character":69},"in_reply_to":"7aa08908_3dc2c253","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_bdacf29f","line":152,"range":{"start_line":152,"start_character":56,"end_line":152,"end_character":68},"updated":"2016-06-17 18:59:22.000000000","message":"an infinite","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\"set the tcp timeout so that oslo vmware can through an"},{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_9b742dfe","line":152,"range":{"start_line":152,"start_character":56,"end_line":152,"end_character":68},"in_reply_to":"7aa08908_bdacf29f","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"eff18b79d90bc0d8610c70ab7859db4435accd8c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fd92fa55","line":153,"range":{"start_line":153,"start_character":11,"end_line":153,"end_character":28},"updated":"2016-06-17 18:59:22.000000000","message":"redundant","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":150,"context_line":"           exception in case of vm lost the connectivity from vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_fbbbb173","line":153,"range":{"start_line":153,"start_character":11,"end_line":153,"end_character":28},"in_reply_to":"7aa08908_fd92fa55","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"bb3d7b418de8fc37c936894375a2033db13211bb","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def open(self, request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f0e32e32","line":154,"range":{"start_line":154,"start_character":11,"end_line":154,"end_character":14},"updated":"2016-06-18 13:28:17.000000000","message":"Set the tcp timeout value for raising an exception on losing connectivity with vCenter","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"022984a9b32ea6d2bb076cadb631c5fa0577e534","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for the infinity time"},{"line_number":153,"context_line":"           and hangs forever."},{"line_number":154,"context_line":"           \"\"\""},{"line_number":155,"context_line":"        self.tcp_timeout \u003d timeout"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def open(self, request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_3b5a5984","line":154,"range":{"start_line":154,"start_character":11,"end_line":154,"end_character":14},"in_reply_to":"7aa08908_f0e32e32","updated":"2016-06-20 06:32:52.000000000","message":"Done","commit_id":"a5b891555bb86695f0ae992bf13b9da9baaa6409"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"194a2aaa15c0b39c507f338fff6373a55719ab41","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_connection_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"Set the connection timeout value for raising an exception"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"           on losing connectivity with vCenter."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"           By default it is set to None which waits for an infinite"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f5341ffc","line":150,"updated":"2016-06-22 18:53:35.000000000","message":"remove blank line here","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"620cd47c8a2981343d1e9e42baa3f5cff804a563","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_connection_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"Set the connection timeout value for raising an exception"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"           on losing connectivity with vCenter."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"           By default it is set to None which waits for an infinite"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0856e35b","line":150,"in_reply_to":"3aaa91ec_f5341ffc","updated":"2016-06-24 07:12:31.000000000","message":"Done","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"194a2aaa15c0b39c507f338fff6373a55719ab41","unresolved":false,"context_lines":[{"line_number":151,"context_line":"           on losing connectivity with vCenter."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"           By default it is set to None which waits for an infinite"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"           time."},{"line_number":156,"context_line":"           \"\"\""},{"line_number":157,"context_line":"        self.connection_timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_95267bcc","line":154,"updated":"2016-06-22 18:53:35.000000000","message":"and remove blank line here","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"620cd47c8a2981343d1e9e42baa3f5cff804a563","unresolved":false,"context_lines":[{"line_number":151,"context_line":"           on losing connectivity with vCenter."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"           By default it is set to None which waits for an infinite"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"           time."},{"line_number":156,"context_line":"           \"\"\""},{"line_number":157,"context_line":"        self.connection_timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_e850b760","line":154,"in_reply_to":"3aaa91ec_95267bcc","updated":"2016-06-24 07:12:31.000000000","message":"Done","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d04f64699ca914faf9043bc906aa5d1f775889b1","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.connection_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_connection_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"Set the connection timeout value for raising an exception"},{"line_number":150,"context_line":"           on losing connectivity with vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for an infinite"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_43750830","line":149,"updated":"2016-06-30 14:26:09.000000000","message":"nit: There should be a summary line (one line) followed by a blank line and then the rest of the doc comment.","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"9730576f609657bf8f81a53e8b37a1964bb313ad","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.connection_timeout \u003d None"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def set_connection_timeout(self, timeout):"},{"line_number":149,"context_line":"        \"\"\"Set the connection timeout value for raising an exception"},{"line_number":150,"context_line":"           on losing connectivity with vCenter."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"           By default it is set to None which waits for an infinite"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b5015bb1","line":149,"in_reply_to":"3aaa91ec_43750830","updated":"2016-07-01 06:27:30.000000000","message":"will do in next patch set","commit_id":"4add2f02f8c9cbdb5e9873fdce9d23c3184b2c99"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.soap_url \u003d soap_url"},{"line_number":198,"context_line":"        LOG.debug(\"Creating suds client with soap_url\u003d\u0027%s\u0027 and wsdl_url\u003d\u0027%s\u0027\","},{"line_number":199,"context_line":"                  self.soap_url, self.wsdl_url)"},{"line_number":200,"context_line":"        transport \u003d RequestsTransport(cacert, insecure, pool_maxsize,"},{"line_number":201,"context_line":"                                      connection_timeout)"},{"line_number":202,"context_line":"        self.client \u003d client.Client(self.wsdl_url,"},{"line_number":203,"context_line":"                                    transport\u003dtransport,"},{"line_number":204,"context_line":"                                    location\u003dself.soap_url,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_563335ab","line":201,"range":{"start_line":200,"start_character":38,"end_line":201,"end_character":56},"updated":"2016-07-20 10:00:45.000000000","message":"Could you please use kwargs including the existing ones?","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.soap_url \u003d soap_url"},{"line_number":198,"context_line":"        LOG.debug(\"Creating suds client with soap_url\u003d\u0027%s\u0027 and wsdl_url\u003d\u0027%s\u0027\","},{"line_number":199,"context_line":"                  self.soap_url, self.wsdl_url)"},{"line_number":200,"context_line":"        transport \u003d RequestsTransport(cacert, insecure, pool_maxsize,"},{"line_number":201,"context_line":"                                      connection_timeout)"},{"line_number":202,"context_line":"        self.client \u003d client.Client(self.wsdl_url,"},{"line_number":203,"context_line":"                                    transport\u003dtransport,"},{"line_number":204,"context_line":"                                    location\u003dself.soap_url,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_84070081","line":201,"range":{"start_line":200,"start_character":38,"end_line":201,"end_character":56},"in_reply_to":"dada55a8_563335ab","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f40e72f164306e17c9b297ffadf325ba59594880","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.soap_url \u003d soap_url"},{"line_number":198,"context_line":"        LOG.debug(\"Creating suds client with soap_url\u003d\u0027%s\u0027 and wsdl_url\u003d\u0027%s\u0027\","},{"line_number":199,"context_line":"                  self.soap_url, self.wsdl_url)"},{"line_number":200,"context_line":"        transport \u003d RequestsTransport(cacert, insecure, pool_maxsize,"},{"line_number":201,"context_line":"                                      connection_timeout)"},{"line_number":202,"context_line":"        self.client \u003d client.Client(self.wsdl_url,"},{"line_number":203,"context_line":"                                    transport\u003dtransport,"},{"line_number":204,"context_line":"                                    location\u003dself.soap_url,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_afdbef7a","line":201,"range":{"start_line":200,"start_character":38,"end_line":201,"end_character":56},"in_reply_to":"dada55a8_84070081","updated":"2016-07-21 11:28:29.000000000","message":"Sorry I was not clear before.\n\ntransport \u003d RequestsTransport(cacert\u003dcacert, insecure\u003dinsecure, pool_maxsize\u003dpool_maxsize, connection_timeout\u003dconnection_timeout)\n\nlooks better than explicitly creating the kwagrs dict.","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3be761c06862b62663237edcfb50f5167eba2202","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class RequestsTransport(transport.Transport):"},{"line_number":137,"context_line":"    def __init__(self, **kwargs):"},{"line_number":138,"context_line":"        transport.Transport.__init__(self)"},{"line_number":139,"context_line":"        # insecure flag is used only if cacert is not"},{"line_number":140,"context_line":"        # specified."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_0f4b1b5a","line":137,"updated":"2016-07-21 11:28:45.000000000","message":"Please undo this change.","commit_id":"f42a5257973c7aadf63543257cfc21cdce2aa176"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"9de92b65bcdbc03fe7cfb2693199e479377f6047","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class RequestsTransport(transport.Transport):"},{"line_number":137,"context_line":"    def __init__(self, **kwargs):"},{"line_number":138,"context_line":"        transport.Transport.__init__(self)"},{"line_number":139,"context_line":"        # insecure flag is used only if cacert is not"},{"line_number":140,"context_line":"        # specified."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_efc20752","line":137,"in_reply_to":"dada55a8_0f4b1b5a","updated":"2016-07-21 11:29:50.000000000","message":"Please change to:\n\ndef __init__(self, cacert\u003dNone, insecure\u003dTrue, pool_maxsize\u003d10, connection_timeout\u003dNone)","commit_id":"f42a5257973c7aadf63543257cfc21cdce2aa176"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"09d82d0f428c05bc2830cdc06344f62f48f70eaf","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class RequestsTransport(transport.Transport):"},{"line_number":137,"context_line":"    def __init__(self, **kwargs):"},{"line_number":138,"context_line":"        transport.Transport.__init__(self)"},{"line_number":139,"context_line":"        # insecure flag is used only if cacert is not"},{"line_number":140,"context_line":"        # specified."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_b5706273","line":137,"in_reply_to":"dada55a8_efc20752","updated":"2016-07-21 12:09:14.000000000","message":"Done","commit_id":"f42a5257973c7aadf63543257cfc21cdce2aa176"}],"oslo_vmware/tests/test_api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3be761c06862b62663237edcfb50f5167eba2202","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                                        cacert\u003dself.cert_mock,"},{"line_number":137,"context_line":"                                        insecure\u003dFalse,"},{"line_number":138,"context_line":"                                        pool_maxsize\u003dVMwareAPISessionTest."},{"line_number":139,"context_line":"                                        POOL_SIZE,"},{"line_number":140,"context_line":"                                        connection_timeout\u003dNone)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @mock.patch.object(pbm, \u0027Pbm\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_ef6687b9","line":139,"updated":"2016-07-21 11:28:45.000000000","message":"nit: Please adjust the indentation to move this to previous line.","commit_id":"f42a5257973c7aadf63543257cfc21cdce2aa176"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"09d82d0f428c05bc2830cdc06344f62f48f70eaf","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                                        cacert\u003dself.cert_mock,"},{"line_number":137,"context_line":"                                        insecure\u003dFalse,"},{"line_number":138,"context_line":"                                        pool_maxsize\u003dVMwareAPISessionTest."},{"line_number":139,"context_line":"                                        POOL_SIZE,"},{"line_number":140,"context_line":"                                        connection_timeout\u003dNone)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @mock.patch.object(pbm, \u0027Pbm\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_95343e4a","line":139,"in_reply_to":"dada55a8_ef6687b9","updated":"2016-07-21 12:09:14.000000000","message":"Done","commit_id":"f42a5257973c7aadf63543257cfc21cdce2aa176"}],"oslo_vmware/tests/test_service.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"194a2aaa15c0b39c507f338fff6373a55719ab41","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            resp \u003d transport.session.send(request)"},{"line_number":484,"context_line":"            self.assertEqual(data, resp.content)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def test_set_connection_timeout(self):"},{"line_number":487,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":488,"context_line":"        timeout \u003d 120"},{"line_number":489,"context_line":"        transport.set_connection_timeout(timeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_700f9d2e","line":486,"updated":"2016-06-22 18:53:35.000000000","message":"Instead of just verifying that the timeout is set in the class, can you please add a unit test that confirms the session is calling methods with that timeout.","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"620cd47c8a2981343d1e9e42baa3f5cff804a563","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            resp \u003d transport.session.send(request)"},{"line_number":484,"context_line":"            self.assertEqual(data, resp.content)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def test_set_connection_timeout(self):"},{"line_number":487,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":488,"context_line":"        timeout \u003d 120"},{"line_number":489,"context_line":"        transport.set_connection_timeout(timeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2a39ccd7","line":486,"in_reply_to":"3aaa91ec_700f9d2e","updated":"2016-06-24 07:12:31.000000000","message":"Done","commit_id":"3d23f95d941d5da87700b172e1ea5a42ce20e5a9"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0ff513a067737b4b7c7ad20e42b518c6fac0ad4b","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        timeout \u003d 120"},{"line_number":489,"context_line":"        transport.set_connection_timeout(timeout)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        resp \u003d mock.Mock(status_code\u003dmock.sentinel.status_code,"},{"line_number":492,"context_line":"                         headers\u003dmock.sentinel.headers,"},{"line_number":493,"context_line":"                         content\u003dmock.sentinel.content)"},{"line_number":494,"context_line":"        transport.session.post \u003d mock.Mock(return_value\u003dresp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_4a2a3491","line":491,"updated":"2016-06-24 19:57:35.000000000","message":"Using mock.patch might be cleaner/simpler.","commit_id":"f4a9fd0d38a5a8176eb1d62816b6617ca8809d68"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"a0162a75cd644228abb56bbd5e6360a2375ebe3e","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        timeout \u003d 120"},{"line_number":489,"context_line":"        transport.set_connection_timeout(timeout)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        resp \u003d mock.Mock(status_code\u003dmock.sentinel.status_code,"},{"line_number":492,"context_line":"                         headers\u003dmock.sentinel.headers,"},{"line_number":493,"context_line":"                         content\u003dmock.sentinel.content)"},{"line_number":494,"context_line":"        transport.session.post \u003d mock.Mock(return_value\u003dresp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_79eb65dc","line":491,"in_reply_to":"3aaa91ec_4a2a3491","updated":"2016-06-27 08:46:05.000000000","message":"Done","commit_id":"f4a9fd0d38a5a8176eb1d62816b6617ca8809d68"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0ff513a067737b4b7c7ad20e42b518c6fac0ad4b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            timeout\u003d120,"},{"line_number":507,"context_line":"            verify\u003dtransport.verify)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_default_connection_timeout(self):"},{"line_number":510,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        resp \u003d mock.Mock(status_code\u003dmock.sentinel.status_code,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_6a81f08e","line":509,"updated":"2016-06-24 19:57:35.000000000","message":"These two methods do essentially the same thing except for the timeout value being different.  Can you create a common method with a timeout argument for the tests.  That\u0027ll cut down on the code maintenance.","commit_id":"f4a9fd0d38a5a8176eb1d62816b6617ca8809d68"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"a0162a75cd644228abb56bbd5e6360a2375ebe3e","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            timeout\u003d120,"},{"line_number":507,"context_line":"            verify\u003dtransport.verify)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_default_connection_timeout(self):"},{"line_number":510,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        resp \u003d mock.Mock(status_code\u003dmock.sentinel.status_code,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_39a1dd94","line":509,"in_reply_to":"3aaa91ec_6a81f08e","updated":"2016-06-27 08:46:05.000000000","message":"After using mack.patch.object there is only 4 common lines in both the methods, check in patch set 5.\nI think now using a common method will be not a good idea. What do you say?","commit_id":"f4a9fd0d38a5a8176eb1d62816b6617ca8809d68"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cd010327b8fb0d242c3a386645284ab61e37a983","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                timeout\u003d120,"},{"line_number":503,"context_line":"                verify\u003dtransport.verify)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_default_connection_timeout(self):"},{"line_number":506,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        request \u003d mock.Mock(url\u003dmock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0ac1f32e","line":505,"range":{"start_line":505,"start_character":8,"end_line":505,"end_character":39},"updated":"2016-06-28 00:17:13.000000000","message":"This test and the above one are still too common IMO.  Rather see one test with a timeout param","commit_id":"c717b0d469adbf69e52873d7589db802e6d857bb"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"b6b746caa97a5c6f34fd2324e117217f3e961f89","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                timeout\u003d120,"},{"line_number":503,"context_line":"                verify\u003dtransport.verify)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_default_connection_timeout(self):"},{"line_number":506,"context_line":"        transport \u003d service.RequestsTransport()"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        request \u003d mock.Mock(url\u003dmock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_411119af","line":505,"range":{"start_line":505,"start_character":8,"end_line":505,"end_character":39},"in_reply_to":"3aaa91ec_0ac1f32e","updated":"2016-06-28 05:10:06.000000000","message":"Okay Eric,\nI will remove this test case and i will keep only one test case.","commit_id":"c717b0d469adbf69e52873d7589db802e6d857bb"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            resp \u003d transport.session.send(request)"},{"line_number":484,"context_line":"            self.assertEqual(data, resp.content)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def test_set_connection_timeout(self):"},{"line_number":487,"context_line":"        transport \u003d service.RequestsTransport(connection_timeout\u003d120)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        request \u003d mock.Mock(url\u003dmock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b6b27104","line":486,"range":{"start_line":486,"start_character":8,"end_line":486,"end_character":35},"updated":"2016-07-20 10:00:45.000000000","message":"test_send_with_connection_timeout","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            resp \u003d transport.session.send(request)"},{"line_number":484,"context_line":"            self.assertEqual(data, resp.content)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def test_set_connection_timeout(self):"},{"line_number":487,"context_line":"        transport \u003d service.RequestsTransport(connection_timeout\u003d120)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        request \u003d mock.Mock(url\u003dmock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_c4fd786f","line":486,"range":{"start_line":486,"start_character":8,"end_line":486,"end_character":35},"in_reply_to":"dada55a8_b6b27104","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4bafc0a83474d9a17a8e30a0627b4643bcb1abab","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                            message\u003dmock.sentinel.message,"},{"line_number":491,"context_line":"                            headers\u003dmock.sentinel.req_headers)"},{"line_number":492,"context_line":"        with mock.patch.object(transport.session, \"post\") as mock_post:"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"            transport.send(request)"},{"line_number":495,"context_line":"            mock_post.assert_called_once_with("},{"line_number":496,"context_line":"                mock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_52b04143","line":493,"updated":"2016-07-26 17:06:31.000000000","message":"remove blank line","commit_id":"7f14806429c1f6d276b53ac0935ac76842e6b429"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"21d3f143e2c0a9cd641dab8d7e949d52bd7401f9","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                            message\u003dmock.sentinel.message,"},{"line_number":491,"context_line":"                            headers\u003dmock.sentinel.req_headers)"},{"line_number":492,"context_line":"        with mock.patch.object(transport.session, \"post\") as mock_post:"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"            transport.send(request)"},{"line_number":495,"context_line":"            mock_post.assert_called_once_with("},{"line_number":496,"context_line":"                mock.sentinel.url,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_119b2067","line":493,"in_reply_to":"dada55a8_52b04143","updated":"2016-08-02 07:18:32.000000000","message":"Done","commit_id":"7f14806429c1f6d276b53ac0935ac76842e6b429"}],"oslo_vmware/vim.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1a2cbafba09d724b9a2e50ea78cce56ce340b8ea","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                         used only if cacert is not specified"},{"line_number":35,"context_line":"        :param pool_maxsize: Maximum number of connections in http"},{"line_number":36,"context_line":"                             connection pool"},{"line_number":37,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":38,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":39,"context_line":"                                   if the network interface goes down"},{"line_number":40,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":41,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":42,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_d6cd6586","line":39,"range":{"start_line":37,"start_character":35,"end_line":39,"end_character":69},"updated":"2016-07-20 10:00:45.000000000","message":"Same comment.","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"3a3f922b86fb2902f568175d32f45c4d9d41a137","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                         used only if cacert is not specified"},{"line_number":35,"context_line":"        :param pool_maxsize: Maximum number of connections in http"},{"line_number":36,"context_line":"                             connection pool"},{"line_number":37,"context_line":"        :param connection_timeout: Maximum timeout value to allow invoke_api"},{"line_number":38,"context_line":"                                   to wait and then raise a connection error,"},{"line_number":39,"context_line":"                                   if the network interface goes down"},{"line_number":40,"context_line":"        :raises: VimException, VimFaultException, VimAttributeException,"},{"line_number":41,"context_line":"                 VimSessionOverLoadException, VimConnectionException"},{"line_number":42,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_04fcb06e","line":39,"range":{"start_line":37,"start_character":35,"end_line":39,"end_character":69},"in_reply_to":"dada55a8_d6cd6586","updated":"2016-07-21 07:02:00.000000000","message":"Done","commit_id":"3c9d69682866a5739b01ed27ea7d9b843cb3b33d"}]}