)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"09f0309c8b8ba539ad2d364ac5dd2549ee7840b9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for tasks to complete and also update total duration"},{"line_number":11,"context_line":"in seconds on successful completion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"2016-08-01 17:44:23.418 6415 DEBUG oslo_vmware.api [-] Task: {"},{"line_number":14,"context_line":"\u0027id\u0027: task-7778, \u0027name\u0027: Rename_Task} progress is 0%."},{"line_number":15,"context_line":" _poll_task /opt/stack/oslo.vmware/oslo_vmware/api.py:421"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_e3d09055","line":13,"updated":"2016-08-05 03:15:49.000000000","message":"super nit: may be we can avoid the timestamps in commit message","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"307ef8cf6e75265cc678141cccd6a0730d5bd23c","unresolved":false,"context_lines":[{"line_number":15,"context_line":" _poll_task /opt/stack/oslo.vmware/oslo_vmware/api.py:421"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"2016-08-01 17:44:23.924 6415 DEBUG oslo_vmware.api [-] Task: {"},{"line_number":18,"context_line":"\u0027id\u0027: task-7778, \u0027name\u0027: Rename_Task} is successful and took 0.320311 seconds."},{"line_number":19,"context_line":" _poll_task /opt/stack/oslo.vmware/oslo_vmware/api.py:427"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia1448cc9baf1cf7abc7d4b14e27e90c86af5583c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_725c887d","line":18,"updated":"2016-08-04 14:34:02.000000000","message":"nit: please wrap at col 72","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"09f0309c8b8ba539ad2d364ac5dd2549ee7840b9","unresolved":false,"context_lines":[{"line_number":15,"context_line":" _poll_task /opt/stack/oslo.vmware/oslo_vmware/api.py:421"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"2016-08-01 17:44:23.924 6415 DEBUG oslo_vmware.api [-] Task: {"},{"line_number":18,"context_line":"\u0027id\u0027: task-7778, \u0027name\u0027: Rename_Task} is successful and took 0.320311 seconds."},{"line_number":19,"context_line":" _poll_task /opt/stack/oslo.vmware/oslo_vmware/api.py:427"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia1448cc9baf1cf7abc7d4b14e27e90c86af5583c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_03f5e4eb","line":18,"in_reply_to":"bacf61ea_725c887d","updated":"2016-08-05 03:15:49.000000000","message":"looks like pep8 is not checking commit messages.","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"}],"oslo_vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"307ef8cf6e75265cc678141cccd6a0730d5bd23c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f2dfd8d3","line":426,"range":{"start_line":426,"start_character":60,"end_line":426,"end_character":62},"updated":"2016-08-04 14:34:02.000000000","message":"% -\u003e ,\n\n\nIf debug is disabled this would skip the formatting.","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"5e6351dfbd4d9cfe2cb4862fefc892a5088cde07","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                  \"task: %s.\"),"},{"line_number":409,"context_line":"                              task)"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            task_detail \u003d {\u0027id\u0027: task.value}"},{"line_number":412,"context_line":"            # some internal tasks do not have \u0027name\u0027 set"},{"line_number":413,"context_line":"            if getattr(task_info, \u0027name\u0027, None):"},{"line_number":414,"context_line":"                task_detail[\u0027name\u0027] \u003d task_info.name"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if task_info.state in [\u0027queued\u0027, \u0027running\u0027]:"},{"line_number":417,"context_line":"                if hasattr(task_info, \u0027progress\u0027):"},{"line_number":418,"context_line":"                    LOG.debug(\"Task: %(task)s progress is %(progress)s%%.\","},{"line_number":419,"context_line":"                              {\u0027task\u0027: task_detail,"},{"line_number":420,"context_line":"                               \u0027progress\u0027: task_info.progress})"},{"line_number":421,"context_line":"            elif task_info.state \u003d\u003d \u0027success\u0027:"},{"line_number":422,"context_line":"                complete_time \u003d getattr(task_info, \u0027completeTime\u0027, None)"},{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_070be224","line":426,"range":{"start_line":411,"start_character":12,"end_line":426,"end_character":75},"updated":"2016-08-18 15:11:02.000000000","message":"this snippet of code are all for debug,\nhow about create fun to prepare data for task_detail, \nand this fun only called by LOG.debug, such as LOG.debug(\u0027\u0027, fun()), \nso we can skip unnecessary computing if debug is disabled.","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47bc2319c584bc67f180a5dd0edd01feaabb7f6f","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                  \"task: %s.\"),"},{"line_number":409,"context_line":"                              task)"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            task_detail \u003d {\u0027id\u0027: task.value}"},{"line_number":412,"context_line":"            # some internal tasks do not have \u0027name\u0027 set"},{"line_number":413,"context_line":"            if getattr(task_info, \u0027name\u0027, None):"},{"line_number":414,"context_line":"                task_detail[\u0027name\u0027] \u003d task_info.name"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if task_info.state in [\u0027queued\u0027, \u0027running\u0027]:"},{"line_number":417,"context_line":"                if hasattr(task_info, \u0027progress\u0027):"},{"line_number":418,"context_line":"                    LOG.debug(\"Task: %(task)s progress is %(progress)s%%.\","},{"line_number":419,"context_line":"                              {\u0027task\u0027: task_detail,"},{"line_number":420,"context_line":"                               \u0027progress\u0027: task_info.progress})"},{"line_number":421,"context_line":"            elif task_info.state \u003d\u003d \u0027success\u0027:"},{"line_number":422,"context_line":"                complete_time \u003d getattr(task_info, \u0027completeTime\u0027, None)"},{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_6620d0f8","line":426,"range":{"start_line":411,"start_character":12,"end_line":426,"end_character":75},"in_reply_to":"3ac371cc_070be224","updated":"2016-08-19 10:28:46.000000000","message":"\u003e so we can skip unnecessary computing if debug is disabled\n\nI don\u0027t think this is correct. The decision to create format string and then print the log happens in LOG.debug function. Before calling LOG.debug, all its arguments including the function which returns the dictionary are evaulated. So there is no advantage in extracting this to a function. I prefer the old version instead.","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"0aa6a9f09bca5b2d4ce2128677c2369119709da5","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                  \"task: %s.\"),"},{"line_number":409,"context_line":"                              task)"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            task_detail \u003d {\u0027id\u0027: task.value}"},{"line_number":412,"context_line":"            # some internal tasks do not have \u0027name\u0027 set"},{"line_number":413,"context_line":"            if getattr(task_info, \u0027name\u0027, None):"},{"line_number":414,"context_line":"                task_detail[\u0027name\u0027] \u003d task_info.name"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if task_info.state in [\u0027queued\u0027, \u0027running\u0027]:"},{"line_number":417,"context_line":"                if hasattr(task_info, \u0027progress\u0027):"},{"line_number":418,"context_line":"                    LOG.debug(\"Task: %(task)s progress is %(progress)s%%.\","},{"line_number":419,"context_line":"                              {\u0027task\u0027: task_detail,"},{"line_number":420,"context_line":"                               \u0027progress\u0027: task_info.progress})"},{"line_number":421,"context_line":"            elif task_info.state \u003d\u003d \u0027success\u0027:"},{"line_number":422,"context_line":"                complete_time \u003d getattr(task_info, \u0027completeTime\u0027, None)"},{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_b91023ad","line":426,"range":{"start_line":411,"start_character":12,"end_line":426,"end_character":75},"in_reply_to":"3ac371cc_070be224","updated":"2016-08-18 18:58:00.000000000","message":"Done","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1e7af4beab88f90ab7ba83e8e2798a1e7e03df74","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_c7c39936","line":426,"range":{"start_line":426,"start_character":60,"end_line":426,"end_character":62},"in_reply_to":"9ad45d7e_a78f7473","updated":"2016-08-18 12:18:48.000000000","message":"This should be \n\nLOG.debug(\"Task: %s completed successfully.\", task_detail)","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"868e1148c258cdc572b4aa5d234d0d2278636f21","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                if complete_time:"},{"line_number":424,"context_line":"                    duration \u003d complete_time - task_info.queueTime"},{"line_number":425,"context_line":"                    task_detail[\u0027duration_secs\u0027] \u003d duration.total_seconds()"},{"line_number":426,"context_line":"                LOG.debug(\"Task: %s completed successfully.\" % task_detail)"},{"line_number":427,"context_line":"                raise loopingcall.LoopingCallDone(task_info)"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                error_msg \u003d six.text_type(task_info.error.localizedMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_a78f7473","line":426,"range":{"start_line":426,"start_character":60,"end_line":426,"end_character":62},"in_reply_to":"bacf61ea_f2dfd8d3","updated":"2016-08-12 03:15:23.000000000","message":"yes, but how to do?","commit_id":"07961315143c484004ba2ac9d25a01d7ff9d7977"}]}
