)]}'
{"oslo_vmware/service.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"17fcb3f2d98ad920ad9333100f2fcc399a3554bf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from suds import plugin"},{"line_number":32,"context_line":"import suds.sax.element as element"},{"line_number":33,"context_line":"from suds import transport"},{"line_number":34,"context_line":"import uuid"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from oslo_vmware._i18n import _"},{"line_number":37,"context_line":"from oslo_vmware import exceptions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_807b007b","line":34,"updated":"2016-12-19 12:34:11.000000000","message":"I think this should be in the first section of import statements.","commit_id":"9734659800b7ca322e04f9b9c5817bbebeab6218"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"17fcb3f2d98ad920ad9333100f2fcc399a3554bf","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    return"},{"line_number":315,"context_line":"                # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":316,"context_line":"                # this particular remote call."},{"line_number":317,"context_line":"                op_id \u003d \u0027%s-%s\u0027 % (self.op_id_prefix, str(uuid.uuid4()))"},{"line_number":318,"context_line":"                LOG.debug(\u0027Invoking %s.%s with opID\u003d%s\u0027,"},{"line_number":319,"context_line":"                          managed_object._type,"},{"line_number":320,"context_line":"                          attr_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_20522cde","line":317,"range":{"start_line":317,"start_character":54,"end_line":317,"end_character":71},"updated":"2016-12-19 12:34:11.000000000","message":"Can we use oslo_utils.uuidutils.generate_uuid()?","commit_id":"9734659800b7ca322e04f9b9c5817bbebeab6218"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"624426a40ef9fc336fc7df612fa28d26ca88af84","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    return"},{"line_number":315,"context_line":"                # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":316,"context_line":"                # this particular remote call."},{"line_number":317,"context_line":"                op_id \u003d \u0027%s-%s\u0027 % (self.op_id_prefix, str(uuid.uuid4()))"},{"line_number":318,"context_line":"                LOG.debug(\u0027Invoking %s.%s with opID\u003d%s\u0027,"},{"line_number":319,"context_line":"                          managed_object._type,"},{"line_number":320,"context_line":"                          attr_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_e1a48809","line":317,"range":{"start_line":317,"start_character":54,"end_line":317,"end_character":71},"in_reply_to":"1a6eadb0_20522cde","updated":"2016-12-20 09:39:14.000000000","message":"Done","commit_id":"9734659800b7ca322e04f9b9c5817bbebeab6218"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7bdd6e9aa8962a64a6aa02904f864fc83e6f3bd3","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":316,"context_line":"                # this particular remote call."},{"line_number":317,"context_line":"                op_id \u003d \u0027%s-%s\u0027 % (self.op_id_prefix, str(uuid.uuid4()))"},{"line_number":318,"context_line":"                LOG.debug(\u0027Invoking %s.%s with opID\u003d%s\u0027,"},{"line_number":319,"context_line":"                          managed_object._type,"},{"line_number":320,"context_line":"                          attr_name,"},{"line_number":321,"context_line":"                          op_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_affbcd45","line":318,"updated":"2016-12-16 13:49:22.000000000","message":"We had a similar debug message here which was removed because it was creating a lot of noise in the logs (due to task polling calls). Can we disable the opID generation and/or this log message selectively?","commit_id":"9734659800b7ca322e04f9b9c5817bbebeab6218"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"aeed7691c154cacef7aebfb654fe3a0f0b61eba6","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":316,"context_line":"                # this particular remote call."},{"line_number":317,"context_line":"                op_id \u003d \u0027%s-%s\u0027 % (self.op_id_prefix, str(uuid.uuid4()))"},{"line_number":318,"context_line":"                LOG.debug(\u0027Invoking %s.%s with opID\u003d%s\u0027,"},{"line_number":319,"context_line":"                          managed_object._type,"},{"line_number":320,"context_line":"                          attr_name,"},{"line_number":321,"context_line":"                          op_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_151e906f","line":318,"in_reply_to":"1a6eadb0_affbcd45","updated":"2016-12-16 14:36:01.000000000","message":"I\u0027d suggest to remove the following log messages instead:\n\napi.py:396      LOG.debug(\"Waiting for the task: %s to complete.\", task)\napi.py:408      LOG.debug(\"Invoking VIM API to read info of task: %s.\", task)\n\nwhich are not very useful and generate a lot of noise. Having the operation ID is super useful and I think it should be enabled by default with DEBUG level.","commit_id":"9734659800b7ca322e04f9b9c5817bbebeab6218"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e3caa86aa1649720085f68f3587d89f6186aebc7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import suds.sax.element as element"},{"line_number":33,"context_line":"from suds import transport"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from oslo_utils import uuidutils"},{"line_number":36,"context_line":"from oslo_vmware._i18n import _"},{"line_number":37,"context_line":"from oslo_vmware import exceptions"},{"line_number":38,"context_line":"from oslo_vmware import vim_util"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_9405bec3","line":35,"updated":"2016-12-20 15:36:43.000000000","message":"Please move this to line 25.","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"403554b0616c3d62d441ae24cfafbfbc5eb84f91","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import suds.sax.element as element"},{"line_number":33,"context_line":"from suds import transport"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from oslo_utils import uuidutils"},{"line_number":36,"context_line":"from oslo_vmware._i18n import _"},{"line_number":37,"context_line":"from oslo_vmware import exceptions"},{"line_number":38,"context_line":"from oslo_vmware import vim_util"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_28e80e10","line":35,"in_reply_to":"1a6eadb0_9405bec3","updated":"2016-12-20 15:43:34.000000000","message":"Done","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e3caa86aa1649720085f68f3587d89f6186aebc7","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                if managed_object is None:"},{"line_number":314,"context_line":"                    return"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"                skip_op_id \u003d False"},{"line_number":317,"context_line":"                if \u0027skip_op_id\u0027 in kwargs:"},{"line_number":318,"context_line":"                    skip_op_id \u003d kwargs[\u0027skip_op_id\u0027]"},{"line_number":319,"context_line":"                    del kwargs[\u0027skip_op_id\u0027]"},{"line_number":320,"context_line":"                if not skip_op_id:"},{"line_number":321,"context_line":"                    # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":322,"context_line":"                    # this particular remote call."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_54dc0612","line":319,"range":{"start_line":316,"start_character":0,"end_line":319,"end_character":44},"updated":"2016-12-20 15:36:43.000000000","message":"skip_op_id \u003d kwargs.pop(\u0027skip_op_id\u0027, False)","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"403554b0616c3d62d441ae24cfafbfbc5eb84f91","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                if managed_object is None:"},{"line_number":314,"context_line":"                    return"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"                skip_op_id \u003d False"},{"line_number":317,"context_line":"                if \u0027skip_op_id\u0027 in kwargs:"},{"line_number":318,"context_line":"                    skip_op_id \u003d kwargs[\u0027skip_op_id\u0027]"},{"line_number":319,"context_line":"                    del kwargs[\u0027skip_op_id\u0027]"},{"line_number":320,"context_line":"                if not skip_op_id:"},{"line_number":321,"context_line":"                    # Generate opID. It will appear in vCenter and ESX logs for"},{"line_number":322,"context_line":"                    # this particular remote call."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_08d99283","line":319,"range":{"start_line":316,"start_character":0,"end_line":319,"end_character":44},"in_reply_to":"1a6eadb0_54dc0612","updated":"2016-12-20 15:43:34.000000000","message":"Done","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"bba746dad62fd01a6c1954a926c182b84bd8f1b3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from suds import cache"},{"line_number":31,"context_line":"from suds import client"},{"line_number":32,"context_line":"from suds import plugin"},{"line_number":33,"context_line":"import suds.sax.element as element"},{"line_number":34,"context_line":"from suds import transport"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from oslo_vmware._i18n import _"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b20c8595","line":33,"updated":"2016-12-20 17:40:06.000000000","message":"Why not just?:\nfrom suds.sax import element","commit_id":"6a63362919c12023798458e721a4818e61702e3a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"bba746dad62fd01a6c1954a926c182b84bd8f1b3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # Suds builds the entire request object based on the WSDL schema."},{"line_number":73,"context_line":"        # VI SDK throws server errors if optional SOAP nodes are sent"},{"line_number":74,"context_line":"        # without values; e.g., \u003ctest/\u003e as opposed to \u003ctest\u003etest\u003c/test\u003e."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        context.envelope.prune()"},{"line_number":77,"context_line":"        context.envelope.walk(self.add_attribute_for_value)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_521c11c1","line":75,"updated":"2016-12-20 17:40:06.000000000","message":"nit","commit_id":"6a63362919c12023798458e721a4818e61702e3a"}],"oslo_vmware/vim_util.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e3caa86aa1649720085f68f3587d89f6186aebc7","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    :param vim: Vim object"},{"line_number":292,"context_line":"    :param moref: managed object reference"},{"line_number":293,"context_line":"    :param skip_op_id: whether to skip putting opID in the request"},{"line_number":294,"context_line":"    :param properties_to_collect: names of the managed object properties to be"},{"line_number":295,"context_line":"                                  collected"},{"line_number":296,"context_line":"    :returns: properties of the given managed object"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_34feaa38","line":293,"updated":"2016-12-20 15:36:43.000000000","message":"nit: we can move this below properties_to_collect description","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"403554b0616c3d62d441ae24cfafbfbc5eb84f91","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    :param vim: Vim object"},{"line_number":292,"context_line":"    :param moref: managed object reference"},{"line_number":293,"context_line":"    :param skip_op_id: whether to skip putting opID in the request"},{"line_number":294,"context_line":"    :param properties_to_collect: names of the managed object properties to be"},{"line_number":295,"context_line":"                                  collected"},{"line_number":296,"context_line":"    :returns: properties of the given managed object"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_883a0297","line":293,"in_reply_to":"1a6eadb0_34feaa38","updated":"2016-12-20 15:43:34.000000000","message":"Done","commit_id":"98974d9d1a9ecc964d5afbfb0c7c0efd5cf8a2aa"}]}