)]}'
{"oslo_vmware/service.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3c57645d7ef70402245d8a64b08a7e9229322e1b","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if op_id:"},{"line_number":282,"context_line":"            elem \u003d element.Element(\u0027operationID\u0027).setText(op_id)"},{"line_number":283,"context_line":"            headers.append(elem)"},{"line_number":284,"context_line":"        self.client.set_options(soapheaders\u003dheaders)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @property"},{"line_number":287,"context_line":"    def service_content(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_6054e2fd","line":284,"updated":"2017-01-11 14:24:39.000000000","message":"Not related to this patch. Since multiple threads can use the same VMwareAPISession instance, the client instance may be shared. Will this cause any problem like overwriting the headers with the wrong opID when there are concurrent VIM/PBM API invocations? I\u0027m not sure whether suds client uses thread local objects.","commit_id":"6d3a33285dcde1e28ee6f7d85b31b768be68807b"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"0eb422093ea6cf4d89dc28781685483e95dfa4f2","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if op_id:"},{"line_number":282,"context_line":"            elem \u003d element.Element(\u0027operationID\u0027).setText(op_id)"},{"line_number":283,"context_line":"            headers.append(elem)"},{"line_number":284,"context_line":"        self.client.set_options(soapheaders\u003dheaders)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @property"},{"line_number":287,"context_line":"    def service_content(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_f90472c7","line":284,"in_reply_to":"9a57fde8_fe2536ae","updated":"2017-01-13 11:08:34.000000000","message":"Done","commit_id":"6d3a33285dcde1e28ee6f7d85b31b768be68807b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a2d8f125293b369cf27a7cefda2e43cdc1106d66","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if op_id:"},{"line_number":282,"context_line":"            elem \u003d element.Element(\u0027operationID\u0027).setText(op_id)"},{"line_number":283,"context_line":"            headers.append(elem)"},{"line_number":284,"context_line":"        self.client.set_options(soapheaders\u003dheaders)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @property"},{"line_number":287,"context_line":"    def service_content(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a57fde8_fe2536ae","line":284,"in_reply_to":"ba5201f7_06496eb7","updated":"2017-01-12 16:58:56.000000000","message":"nit:\n\n\nif headers:\n\n  self.client.set_options(soapheaders\u003dheaders)","commit_id":"6d3a33285dcde1e28ee6f7d85b31b768be68807b"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"cc3f192d38092e50a9b774d43390178355f3efef","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if op_id:"},{"line_number":282,"context_line":"            elem \u003d element.Element(\u0027operationID\u0027).setText(op_id)"},{"line_number":283,"context_line":"            headers.append(elem)"},{"line_number":284,"context_line":"        self.client.set_options(soapheaders\u003dheaders)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @property"},{"line_number":287,"context_line":"    def service_content(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_06496eb7","line":284,"in_reply_to":"ba5201f7_6054e2fd","updated":"2017-01-11 15:02:59.000000000","message":"I have thought about this. It is OK because we are using green threads and context switch happens only on IO operations. There are no IO operations between setting the headers and making the RPC call \u003d\u003e there is no chance for context switch here.","commit_id":"6d3a33285dcde1e28ee6f7d85b31b768be68807b"}]}