)]}'
{"oslo_vmware/objects/datastore.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0a28b8245adf9a02b609b2d88c90d57a01d6faa2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"Return reference and name of the specified datastore cluster."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    :param ds_val: datastore cluster name or datastore cluster moid"},{"line_number":62,"context_line":"    :return: tuple of dastastore cluster moref and datastore cluster name"},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    if re.match(\"group-p\\d+\", dsc_val):"},{"line_number":65,"context_line":"        # the configured value is moid"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d2794082","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":32},"updated":"2018-07-16 12:52:15.000000000","message":"nit: datastore","commit_id":"80112baaf6fe01fd126a571d6d75524406ad83bb"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0a28b8245adf9a02b609b2d88c90d57a01d6faa2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    result \u003d session.invoke_api(vim_util, \u0027get_objects\u0027, session.vim,"},{"line_number":76,"context_line":"                                \u0027StoragePod\u0027, 100, [\u0027name\u0027])"},{"line_number":77,"context_line":"    with vim_util.WithRetrieval(session.vim, result) as objs:"},{"line_number":78,"context_line":"        for obj in objs:"},{"line_number":79,"context_line":"            if not hasattr(obj, \u0027propSet\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b2bcc407","line":76,"updated":"2018-07-16 12:52:15.000000000","message":"We have a driver config option vmware_max_objects_retrieval. In most cases, there will be only few clusters, so it is ok to hardcode this.","commit_id":"80112baaf6fe01fd126a571d6d75524406ad83bb"}],"oslo_vmware/tests/objects/test_datastore.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0a28b8245adf9a02b609b2d88c90d57a01d6faa2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        session.invoke_api \u003d mock.Mock()"},{"line_number":204,"context_line":"        session.invoke_api.return_value \u003d retrieve_result"},{"line_number":205,"context_line":"        name \u003d \u0027ds-cluster\u0027"},{"line_number":206,"context_line":"        dsc_ref, dsc_name \u003d datastore.get_dsc_ref_and_name(session, name)"},{"line_number":207,"context_line":"        self.assertEqual((pod_ref.value, pod_ref._type),"},{"line_number":208,"context_line":"                         (dsc_ref.value, dsc_ref._type))"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_521770ef","line":206,"updated":"2018-07-16 12:52:15.000000000","message":"We should also assert for cluster name and invoke_api call.","commit_id":"80112baaf6fe01fd126a571d6d75524406ad83bb"}]}
