)]}'
{"oslo_vmware/vim_util.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d7f938506e61243e43d16f8d1464ba2c330a0393","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    return {prop.name: prop.val for prop in propset}"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"def clone_vm_spec(client_factory, location,"},{"line_number":634,"context_line":"                  power_on\u003dFalse, snapshot\u003dNone, template\u003dFalse, config\u003dNone):"},{"line_number":635,"context_line":"    \"\"\"Builds the VM clone spec.\"\"\""},{"line_number":636,"context_line":"    clone_spec \u003d client_factory.create(\u0027ns0:VirtualMachineCloneSpec\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4e59f226","line":633,"updated":"2018-07-17 06:42:11.000000000","message":"We already have code in both Cinder and Nova to create config, clone and relocate specs. So we can directly pass the specs to oslo.vmware instead of constructing it here. Another reason is, nova and cinder have different values for some of these fields; for example powerOn.","commit_id":"0be1334e58a858d239363344b44b4103c9b65d1c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"1e784b308ccf3b29c0faa5de43634ba49c5209b0","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    return {prop.name: prop.val for prop in propset}"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"def clone_vm_spec(client_factory, location,"},{"line_number":634,"context_line":"                  power_on\u003dFalse, snapshot\u003dNone, template\u003dFalse, config\u003dNone):"},{"line_number":635,"context_line":"    \"\"\"Builds the VM clone spec.\"\"\""},{"line_number":636,"context_line":"    clone_spec \u003d client_factory.create(\u0027ns0:VirtualMachineCloneSpec\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6452cf6a","line":633,"in_reply_to":"5f7c97a3_4e59f226","updated":"2018-07-17 08:32:44.000000000","message":"OK, will remove those","commit_id":"0be1334e58a858d239363344b44b4103c9b65d1c"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d7f938506e61243e43d16f8d1464ba2c330a0393","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    return rel_spec"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def storage_placement_spec(client_factory,"},{"line_number":663,"context_line":"                           dsc_ref,"},{"line_number":664,"context_line":"                           config_spec,"},{"line_number":665,"context_line":"                           vm_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0e2a1a7d","line":662,"updated":"2018-07-17 06:42:11.000000000","message":"Can we extend or add a new method to cover the following?\n\nCreating a virtual machine (set StoragePlacementSpec.configSpec)\n\nRelocating a virtual machine (set StoragePlacementSpec.relocateSpec)","commit_id":"0be1334e58a858d239363344b44b4103c9b65d1c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"275ce7304a84f5f291be38dd19ca4ec4e6411846","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    return rel_spec"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def storage_placement_spec(client_factory,"},{"line_number":663,"context_line":"                           dsc_ref,"},{"line_number":664,"context_line":"                           config_spec,"},{"line_number":665,"context_line":"                           vm_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_246ff729","line":662,"in_reply_to":"5f7c97a3_0e2a1a7d","updated":"2018-07-17 08:32:14.000000000","message":"I made storage_placement_spec a generic one, suitable for clone, create and relocate. Now we can have more specific functions in datastore.py for getting recommended datastores for each operation.","commit_id":"0be1334e58a858d239363344b44b4103c9b65d1c"}]}