)]}'
{"oslo_vmware/common/loopingcall.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09a685812e97ea109617361e03a9c6be97de1cf8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            except LoopingCallDone as e:"},{"line_number":86,"context_line":"                self.stop()"},{"line_number":87,"context_line":"                done.send(e.retvalue)"},{"line_number":88,"context_line":"            except Exception as e:"},{"line_number":89,"context_line":"                done.send_exception(*sys.exc_info())"},{"line_number":90,"context_line":"                return"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_33f6aafb","line":88,"range":{"start_line":88,"start_character":32,"end_line":88,"end_character":33},"updated":"2019-05-08 13:39:03.000000000","message":"Doesn\u0027t look like \"e\" is used anywhere now.\n\nThere are a couple of options here. The main issue is that str() is being called. That should never be done in logging calls. Just dropping that and passing \"e\" in directly as an arg will work since the logging code will properly handle it.\n\nWhat might be better though is just dropping the formatting all together and don\u0027t pass in \"e\" and just call LOG.exception(). That will automatically pick up any in scope exceptions and include it in the ERROR level logging.","commit_id":"5efd5e78a2681f4192b0de730c474db5cb0f034a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"bf0c8a22273a10d001277e4c89b2157dadcf1958","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            except LoopingCallDone as e:"},{"line_number":86,"context_line":"                self.stop()"},{"line_number":87,"context_line":"                done.send(e.retvalue)"},{"line_number":88,"context_line":"            except Exception as e:"},{"line_number":89,"context_line":"                done.send_exception(*sys.exc_info())"},{"line_number":90,"context_line":"                return"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_9763b9b1","line":88,"range":{"start_line":88,"start_character":32,"end_line":88,"end_character":33},"in_reply_to":"dfbec78f_33f6aafb","updated":"2019-05-08 22:56:46.000000000","message":"Previously it was LOG.exception ; see https://github.com/openstack/oslo.vmware/commit/b6b6e7bdd4064a1c216f453323a270a1c7566dbb\n\nWe observed that in certain cases, the logging formatter (during the LOG.exception call) raises UnicodeDecodeError. So it is not handling that issue.\n\nWe should explore ways to set the locale while establishing the session to override the VC\u0027s default one. Also, we should consider adding a timeout in the Event.wait() calls (api.py/wait_for_task() and wait_for_lease_ready()) so that we don\u0027t wait indefinitely if this green thread crashes before calling Event.send()","commit_id":"5efd5e78a2681f4192b0de730c474db5cb0f034a"}]}