)]}'
{"oslo_vmware/exceptions.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ed4f8dd1bf5774e53ed1d6280b6a11178aae1606","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        if not excep_msg:"},{"line_number":309,"context_line":"            excep_msg \u003d six.text_type(localized_method_fault.localizedMessage)"},{"line_number":310,"context_line":"        name \u003d localized_method_fault.fault.__class__.__name__"},{"line_number":311,"context_line":"        fault_class \u003d get_fault_class(name)"},{"line_number":312,"context_line":"        if fault_class:"},{"line_number":313,"context_line":"            ex \u003d fault_class(excep_msg)"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            ex \u003d VimFaultException([name], excep_msg)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        LOG.debug(\"Unexpected exception thrown (%s) while translating\""},{"line_number":318,"context_line":"                  \" fault (%s) with message: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5e6bc784","line":315,"range":{"start_line":311,"start_character":8,"end_line":315,"end_character":53},"updated":"2020-02-11 16:02:12.000000000","message":"Why not return this one as the default if `fault_class` is None (not found) in `get_fault_class` instead of checking this here.\n\nI think it could be more appropriate to manage this in `get_fault_class`.\n\nAll the logic of this block could be moved in `get_fault_class`","commit_id":"7370c400c4f87b6a74a151c69108216140d71fb6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a352f0c85f9848bd7d8787d60c40f0f0cfe37b44","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        if not excep_msg:"},{"line_number":309,"context_line":"            excep_msg \u003d six.text_type(localized_method_fault.localizedMessage)"},{"line_number":310,"context_line":"        name \u003d localized_method_fault.fault.__class__.__name__"},{"line_number":311,"context_line":"        fault_class \u003d get_fault_class(name)"},{"line_number":312,"context_line":"        if fault_class:"},{"line_number":313,"context_line":"            ex \u003d fault_class(excep_msg)"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            ex \u003d VimFaultException([name], excep_msg)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        LOG.debug(\"Unexpected exception thrown (%s) while translating\""},{"line_number":318,"context_line":"                  \" fault (%s) with message: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9f0a99cd","line":315,"range":{"start_line":311,"start_character":8,"end_line":315,"end_character":53},"in_reply_to":"3fa7e38b_59752132","updated":"2020-02-11 18:58:08.000000000","message":"The constructor signature to VimFaultException is different than the VimException class, which is why this is done here instead of refactoring it into get_fault_class.   In order to move this logic inside of get_fault_class, we\u0027d have to refactor everywhere that calls get_fault_class and doesn\u0027t expect a VimFaultException to be returned.\n\nChanging the signature of the constructor to VimFaultException would induce a lot of refactoring, which I think isn\u0027t worth the effort.","commit_id":"7370c400c4f87b6a74a151c69108216140d71fb6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d49b636c6e8cae2062377b987c553018b970928f","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        if not excep_msg:"},{"line_number":309,"context_line":"            excep_msg \u003d six.text_type(localized_method_fault.localizedMessage)"},{"line_number":310,"context_line":"        name \u003d localized_method_fault.fault.__class__.__name__"},{"line_number":311,"context_line":"        fault_class \u003d get_fault_class(name)"},{"line_number":312,"context_line":"        if fault_class:"},{"line_number":313,"context_line":"            ex \u003d fault_class(excep_msg)"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            ex \u003d VimFaultException([name], excep_msg)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        LOG.debug(\"Unexpected exception thrown (%s) while translating\""},{"line_number":318,"context_line":"                  \" fault (%s) with message: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_59752132","line":315,"range":{"start_line":311,"start_character":8,"end_line":315,"end_character":53},"in_reply_to":"3fa7e38b_5e6bc784","updated":"2020-02-11 17:04:20.000000000","message":"ok I\u0027ll move this to get_fault_class()","commit_id":"7370c400c4f87b6a74a151c69108216140d71fb6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d640e5d3c90b05d525abbf4fef693831948cc25a","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        if not excep_msg:"},{"line_number":309,"context_line":"            excep_msg \u003d six.text_type(localized_method_fault.localizedMessage)"},{"line_number":310,"context_line":"        name \u003d localized_method_fault.fault.__class__.__name__"},{"line_number":311,"context_line":"        fault_class \u003d get_fault_class(name)"},{"line_number":312,"context_line":"        if fault_class:"},{"line_number":313,"context_line":"            ex \u003d fault_class(excep_msg)"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            ex \u003d VimFaultException([name], excep_msg)"},{"line_number":316,"context_line":"    except Exception as e:"},{"line_number":317,"context_line":"        LOG.debug(\"Unexpected exception thrown (%s) while translating\""},{"line_number":318,"context_line":"                  \" fault (%s) with message: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_abf05893","line":315,"range":{"start_line":311,"start_character":8,"end_line":315,"end_character":53},"in_reply_to":"3fa7e38b_9f0a99cd","updated":"2020-02-13 14:08:24.000000000","message":"good point, then let\u0027s continue with these changes it\u0027s not an issue just a minor suggestion.","commit_id":"7370c400c4f87b6a74a151c69108216140d71fb6"}]}