)]}'
{"oslo_vmware/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c13991c976debf5edc5ed03dda87a3abf14dae3b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def _build_response_from_file(self, request):"},{"line_number":146,"context_line":"        file_path \u003d request.url[7:]"},{"line_number":147,"context_line":"        with open(file_path, \u0027rb\u0027) as f:"},{"line_number":148,"context_line":"            file_content \u003d f.read(os.path.getsize(file_path))"},{"line_number":149,"context_line":"            buff \u003d bytearray(file_content.decode(), \"utf-8\")"},{"line_number":150,"context_line":"            resp \u003d Response(buff)"},{"line_number":151,"context_line":"            return self.build_response(request, resp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_e9f4f189","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":60},"updated":"2020-03-11 10:55:49.000000000","message":"do we need this? By default, \u0027read\u0027 will read until EOF is hit, right?","commit_id":"743bfe5288d9c5e68c20d6578df1266335f1f7f5"},{"author":{"_account_id":20322,"name":"Lichao Xue","email":"xuel@vmware.com","username":"xuelichao"},"change_message_id":"5212e2930ca0a9f420a8ea5e95637b9a10211bd9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def _build_response_from_file(self, request):"},{"line_number":146,"context_line":"        file_path \u003d request.url[7:]"},{"line_number":147,"context_line":"        with open(file_path, \u0027rb\u0027) as f:"},{"line_number":148,"context_line":"            file_content \u003d f.read(os.path.getsize(file_path))"},{"line_number":149,"context_line":"            buff \u003d bytearray(file_content.decode(), \"utf-8\")"},{"line_number":150,"context_line":"            resp \u003d Response(buff)"},{"line_number":151,"context_line":"            return self.build_response(request, resp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ac1607f1","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":60},"in_reply_to":"1fa4df85_6c500f0c","updated":"2020-03-11 11:39:52.000000000","message":"Good catch,  just call read() is enough. thanks","commit_id":"743bfe5288d9c5e68c20d6578df1266335f1f7f5"},{"author":{"_account_id":20322,"name":"Lichao Xue","email":"xuel@vmware.com","username":"xuelichao"},"change_message_id":"5212e2930ca0a9f420a8ea5e95637b9a10211bd9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def _build_response_from_file(self, request):"},{"line_number":146,"context_line":"        file_path \u003d request.url[7:]"},{"line_number":147,"context_line":"        with open(file_path, \u0027rb\u0027) as f:"},{"line_number":148,"context_line":"            file_content \u003d f.read(os.path.getsize(file_path))"},{"line_number":149,"context_line":"            buff \u003d bytearray(file_content.decode(), \"utf-8\")"},{"line_number":150,"context_line":"            resp \u003d Response(buff)"},{"line_number":151,"context_line":"            return self.build_response(request, resp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4cd1932f","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":60},"in_reply_to":"1fa4df85_e9f4f189","updated":"2020-03-11 11:39:52.000000000","message":"Good catch, \nyou are right, it will read all the file content if we do not need to pass size here.\ni will remove it.\n\nthanks","commit_id":"743bfe5288d9c5e68c20d6578df1266335f1f7f5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e3c3a792cad6a619f97c70cf9471f0126084cb1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def _build_response_from_file(self, request):"},{"line_number":146,"context_line":"        file_path \u003d request.url[7:]"},{"line_number":147,"context_line":"        with open(file_path, \u0027rb\u0027) as f:"},{"line_number":148,"context_line":"            file_content \u003d f.read(os.path.getsize(file_path))"},{"line_number":149,"context_line":"            buff \u003d bytearray(file_content.decode(), \"utf-8\")"},{"line_number":150,"context_line":"            resp \u003d Response(buff)"},{"line_number":151,"context_line":"            return self.build_response(request, resp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6c500f0c","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":60},"in_reply_to":"1fa4df85_e9f4f189","updated":"2020-03-11 11:30:09.000000000","message":"I could see if we were chunking the reads into smaller chunks for a large file, but that is not what we are doing here. I agree, probably better to just call read() and let it read the file.","commit_id":"743bfe5288d9c5e68c20d6578df1266335f1f7f5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9fd18368507631ed0b1a1ce9ad2899e3451c0e04","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import netaddr"},{"line_number":24,"context_line":"from oslo_utils import timeutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_2cb537ce","line":21,"updated":"2020-03-11 11:48:08.000000000","message":"This needs to be removed now.","commit_id":"57f410236a7bcdbe907c441b51eddfbdd9c60b9d"},{"author":{"_account_id":20322,"name":"Lichao Xue","email":"xuel@vmware.com","username":"xuelichao"},"change_message_id":"8b1aa441a441f82f76341ed6cbdd5e44d8f21171","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import netaddr"},{"line_number":24,"context_line":"from oslo_utils import timeutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_0c339b64","line":21,"in_reply_to":"1fa4df85_2cb537ce","updated":"2020-03-11 11:52:29.000000000","message":"Done","commit_id":"57f410236a7bcdbe907c441b51eddfbdd9c60b9d"}],"oslo_vmware/tests/test_service.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e3c3a792cad6a619f97c70cf9471f0126084cb1","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        data \u003d b\"Hello World\""},{"line_number":501,"context_line":"        get_size_mock.return_value \u003d len(data)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        def read_mock(len):"},{"line_number":504,"context_line":"            return data"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if six.PY3:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_0ccabba0","line":503,"range":{"start_line":503,"start_character":22,"end_line":503,"end_character":25},"updated":"2020-03-11 11:30:09.000000000","message":"Probably better not to use a Python reserved word for your variable name, even if the variable isn\u0027t being used right now.","commit_id":"743bfe5288d9c5e68c20d6578df1266335f1f7f5"}]}