)]}'
{"id":"openstack%2Foslo.vmware~739447","triplet_id":"openstack%2Foslo.vmware~master~I0b0a3d37f6c7d0c750b48596bc3d79b8b2cb0cee","project":"openstack/oslo.vmware","branch":"master","topic":"bp/oslo-vmware-soap-library-switch","hashtags":[],"change_id":"I0b0a3d37f6c7d0c750b48596bc3d79b8b2cb0cee","subject":"Add moref helper functions","status":"MERGED","created":"2020-07-06 09:51:17.000000000","updated":"2020-07-10 12:05:15.000000000","submitted":"2020-07-10 12:03:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"739447-1594382585278-69e2330c","meta_rev_id":"c9e3e9c1cc33ef397abf255b093f2040b358c88c","_number":739447,"virtual_id_number":739447,"owner":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"date":"2020-07-09 11:24:07.000000000","_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-10 12:03:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2020-07-10 10:36:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2020-07-10 08:37:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2020-07-10 10:36:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-10 08:37:03.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-07-10 10:36:57.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-07-10 12:03:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"59ffe55730a768047d9f379d5670232b70aaf818","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2020-07-06 09:51:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"584358f88f0cee1e686728177b7a9ea27276f56a","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2020-07-06 09:55:45.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bd482f222be1193782638c95391d96111498e1f9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-06 11:20:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f96228286ed542eea99a779ba022fd62 : SUCCESS in 1h 17m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/40d3d098d85b42c9877c5cd5ebce72be : SUCCESS in 6m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51fda18283284fd2992b350ceefc848c : SUCCESS in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/818786696c9d4c8fa8ec0cc0ffd2c25c : SUCCESS in 6m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/646bfe4bc13d4659a7a4a0ed05cf4c10 : SUCCESS in 4m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f9ad0c48b78f4ebea17ebd3478e2571e : SUCCESS in 5m 39s","accounts_in_message":[],"_revision_number":2},{"id":"071aadef24f1b3ab796b5246bfc3ffd1f8903eef","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-06 11:57:29.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"b7cdd6b4c2d9001e956b83d7dd6dd2192e77b3ee","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-07 14:03:50.000000000","message":"Patch Set 2:\n\nThis looks good to me. Do we expect any consumers of oslo.vmware to see any impact or need to take any action, i.e. do we need a release note?","accounts_in_message":[],"_revision_number":2},{"id":"090663fcfdd4755f37ee659e990073303abb4241","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2020-07-07 14:26:33.000000000","message":"Patch Set 2:\n\n\u003e This looks good to me. Do we expect any consumers of oslo.vmware to\n \u003e see any impact or need to take any action, i.e. do we need a\n \u003e release note?\n\nWe probably want all our consumers to switch to the new functions, as phase 2 of the spec describes as action items. So yes, sounds like we need a release note.","accounts_in_message":[],"_revision_number":2},{"id":"d902bd6176ca94a74ced9e66b4aaa142e9c20632","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-09 09:13:22.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e \u003e This looks good to me. Do we expect any consumers of oslo.vmware\n \u003e to\n \u003e \u003e see any impact or need to take any action, i.e. do we need a\n \u003e \u003e release note?\n \u003e \n \u003e We probably want all our consumers to switch to the new functions,\n \u003e as phase 2 of the spec describes as action items. So yes, sounds\n \u003e like we need a release note.\n\nOkay, let\u0027s include that here so","accounts_in_message":[],"_revision_number":2},{"id":"8ee3671fb4acedfc002017393a5fa718d3854c60","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2020-07-09 11:23:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"684d2fb571de4dad0db4502baee1195d5918b42d","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2020-07-09 11:24:07.000000000","message":"Patch Set 3:\n\nSorry, got sidetracked downstream. Added a release note. Is the \"upgrade\" section the right one?","accounts_in_message":[],"_revision_number":3},{"id":"cf4818cac75e93f311026fd6a0b9b4053111a39e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-09 13:01:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8c7a73daabbf4d7394d6c025773e22af : SUCCESS in 1h 31m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2b07242289e4462a99d37be19b27de3e : SUCCESS in 6m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b01fffba715f43259d98cad7b0de4c07 : SUCCESS in 4m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4bd82d4022db42099c10b05d89a10f25 : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/92a8c87156454b3ea2b6ff36a6c66f4e : SUCCESS in 3m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7b4f77f0839046208098c7ec56bfb1d5 : SUCCESS in 5m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/98091e5689df4409842dd48dace2800c : SUCCESS in 5m 34s","accounts_in_message":[],"_revision_number":3},{"id":"8dca7a26adfbbfcfcaa0b6803bebb2d302df7141","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-10 08:37:03.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f6c49b8c83ef7cf4a4e8f4e51a7197a959b08b89","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-10 10:36:26.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b915a11440983d9c2cd9bc65e58b6e146b333683","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-10 10:36:47.000000000","message":"Patch Set 3: Code-Review+2\n\nNow that we\u0027ve a release note, I\u0027m happy with this. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"46ecc798bc0a4f547bff5e152098de7e8e23402c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-10 10:36:57.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"ded5c92aef84e13fea250745b587b5eb14375bac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 10:37:09.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"85c768059e85d58d10910796b236e873c830cfdb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 12:03:05.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ae72ed2a809c46c5994bdfe390a5ca53 : SUCCESS in 1h 19m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f768f44adac8420580f4122bd4a4ef68 : SUCCESS in 6m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5c42a12d2041406d9f2edb0395602a8a : SUCCESS in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b8d40153005643b89bcbde6a0909bae0 : SUCCESS in 5m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bd9e4a8d1da047ac91828b05d1fd9083 : SUCCESS in 3m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/99a425bdbaf449ba802359159c82bd58 : SUCCESS in 4m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7a0920f906d34ba9801d5fd93218c638 : SUCCESS in 5m 04s","accounts_in_message":[],"_revision_number":3},{"id":"1eafa8c2d1b8cca545d59b3a039d45e9625f3018","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 12:03:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"5f5e156e8fe12cdb403326481e1a4ed5f311cef3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 12:05:15.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3138041e7f1249c99dd755f1da04cc08 : SUCCESS in 1m 28s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/876be8d2c8d24527a95833f092c01806 : SUCCESS in 1m 53s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"32c8d43a20cb6a29f03324fbc2e6cad3bfb5a294","revisions":{"a99d7b5b19934475709aeeadd81e113c086d0f5f":{"kind":"REWORK","_number":1,"created":"2020-07-06 09:51:17.000000000","uploader":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"ref":"refs/changes/47/739447/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.vmware","ref":"refs/changes/47/739447/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/1"}}},"commit":{"parents":[{"commit":"89e1612cb22887370bce14bbea5574e34b014c3c","subject":"Merge \"Align contributing doc with oslo\u0027s policy\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/89e1612cb22887370bce14bbea5574e34b014c3c"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-05-07 12:03:41.000000000","tz":120},"committer":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-07-06 09:49:27.000000000","tz":120},"subject":"Add moref helper functions","message":"Add moref helper functions\n\nSince the attribute access on a ManagedObjectReference can differ\ndepending on the SOAP library used in the backend, we and especially\ndepending projects should not rely on it, because that breaks the\nabstraction layer oslo.vmware is supposed to provide. To help\ntransitioning to a newer backend library, we introduce two methods for\nretrieving a ManagedObjectReference\u0027s value and type: get_moref_value()\nand get_moref_type().\n\nWe cannot handle this by just returning our own ManagedObjectReference\nobject with uniform access, because it\u0027s hard to get control of all\nmorefs returned by the API.\n\nIn that spirit, we also change all references inside of oslo_vmware to\nusing `get_moref_value()` and `get_moref_type()` instead of directly\naccessing the attributes.\n\nImplements: blueprint oslo-vmware-soap-library-switch\nChange-Id: I0b0a3d37f6c7d0c750b48596bc3d79b8b2cb0cee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/a99d7b5b19934475709aeeadd81e113c086d0f5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/a99d7b5b19934475709aeeadd81e113c086d0f5f"}]},"branch":"refs/heads/master"},"ee5ffa56bade4967d6f75446228fc63c2be499a5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-06 09:55:45.000000000","uploader":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"ref":"refs/changes/47/739447/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.vmware","ref":"refs/changes/47/739447/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/2"}}},"commit":{"parents":[{"commit":"89e1612cb22887370bce14bbea5574e34b014c3c","subject":"Merge \"Align contributing doc with oslo\u0027s policy\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/89e1612cb22887370bce14bbea5574e34b014c3c"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-05-07 12:03:41.000000000","tz":120},"committer":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-07-06 09:54:44.000000000","tz":120},"subject":"Add moref helper functions","message":"Add moref helper functions\n\nSince the attribute access on a ManagedObjectReference can differ\ndepending on the SOAP library used in the backend, we and especially\ndepending projects should not rely on it, because that breaks the\nabstraction layer oslo.vmware is supposed to provide. To help\ntransitioning to a newer backend library, we introduce two methods for\nretrieving a ManagedObjectReference\u0027s value and type: get_moref_value()\nand get_moref_type().\n\nWe cannot handle this by just returning our own ManagedObjectReference\nobject with uniform access, because it\u0027s hard to get control of all\nmorefs returned by the API.\n\nIn that spirit, we also change all references inside of oslo_vmware to\nusing `get_moref_value()` and `get_moref_type()` instead of directly\naccessing the attributes.\n\nThis is part of phase 1 of\nhttps://specs.openstack.org/openstack/oslo-specs/specs/victoria/oslo-vmware-soap-library-switch.html\n\nChange-Id: I0b0a3d37f6c7d0c750b48596bc3d79b8b2cb0cee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/ee5ffa56bade4967d6f75446228fc63c2be499a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/ee5ffa56bade4967d6f75446228fc63c2be499a5"}]},"branch":"refs/heads/master"},"32c8d43a20cb6a29f03324fbc2e6cad3bfb5a294":{"kind":"REWORK","_number":3,"created":"2020-07-09 11:23:14.000000000","uploader":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"ref":"refs/changes/47/739447/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.vmware","ref":"refs/changes/47/739447/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.vmware refs/changes/47/739447/3"}}},"commit":{"parents":[{"commit":"89e1612cb22887370bce14bbea5574e34b014c3c","subject":"Merge \"Align contributing doc with oslo\u0027s policy\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/89e1612cb22887370bce14bbea5574e34b014c3c"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-05-07 12:03:41.000000000","tz":120},"committer":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-07-09 10:16:32.000000000","tz":120},"subject":"Add moref helper functions","message":"Add moref helper functions\n\nSince the attribute access on a ManagedObjectReference can differ\ndepending on the SOAP library used in the backend, we and especially\ndepending projects should not rely on it, because that breaks the\nabstraction layer oslo.vmware is supposed to provide. To help\ntransitioning to a newer backend library, we introduce two methods for\nretrieving a ManagedObjectReference\u0027s value and type: get_moref_value()\nand get_moref_type().\n\nWe cannot handle this by just returning our own ManagedObjectReference\nobject with uniform access, because it\u0027s hard to get control of all\nmorefs returned by the API.\n\nIn that spirit, we also change all references inside of oslo_vmware to\nusing `get_moref_value()` and `get_moref_type()` instead of directly\naccessing the attributes.\n\nThis is part of phase 1 of\nhttps://specs.openstack.org/openstack/oslo-specs/specs/victoria/oslo-vmware-soap-library-switch.html\n\nChange-Id: I0b0a3d37f6c7d0c750b48596bc3d79b8b2cb0cee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/32c8d43a20cb6a29f03324fbc2e6cad3bfb5a294"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/32c8d43a20cb6a29f03324fbc2e6cad3bfb5a294"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}