)]}'
{"id":"openstack%2Foslo.vmware~812435","triplet_id":"openstack%2Foslo.vmware~stable%2Fxena~I072c64904298cf83cb113e402d85fb62626f39f7","project":"openstack/oslo.vmware","branch":"stable/xena","topic":"trivial-stable/xena","hashtags":[],"change_id":"I072c64904298cf83cb113e402d85fb62626f39f7","subject":"Don\u0027t use \u0027requests.PreparedRequest\u0027","status":"MERGED","created":"2021-10-05 08:24:17.000000000","updated":"2021-10-05 11:15:51.000000000","submitted":"2021-10-05 11:13:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"812435-trivial-stable/xena","cherry_pick_of_change":810271,"cherry_pick_of_patch_set":1,"meta_rev_id":"bf412af505e11046d842042f9b795f011ca5667f","_number":812435,"virtual_id_number":812435,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-10-05 11:13:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2021-10-05 08:24:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-10-05 08:24:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-05 09:53:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1383162c02590f9cf2db053875c9c3a5eda53e45","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-05 08:24:17.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"a5bf8a0e4a6d52bd8679f57306b7b3041270a3cc","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-05 08:24:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0e3085ca6cacc9ceba55e40ec18a5cac72340ec3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-05 09:53:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3c9e3772874c4764a5445c59bf73df47 : SUCCESS in 1h 26m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c710bf527454a60a4de2d588b57429c : SUCCESS in 4m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a94a401d8d5444eebec4f60a9e57c49d : SUCCESS in 5m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/205fdadb9eb643599ec20815193d9ca6 : SUCCESS in 5m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3c29bc5062b74bb7a7031086fe9bc9bb : SUCCESS in 5m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/713690aa1d304e1e9fbb11798e4bb7e7 : SUCCESS in 6m 29s","accounts_in_message":[],"_revision_number":1},{"id":"45d9dda1e8897dba33829369f038e443f5e4bd58","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-05 09:54:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c3ca2f6ea1648b389253245d4c9d66f7a4c851a4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-05 11:13:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a3fca7d240e440078cbe36445bf9dbe1 : SUCCESS in 1h 18m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6c1ecca4507044f794df8e22e28284a9 : SUCCESS in 5m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5000829b85e14ff2800eccf26419bd85 : SUCCESS in 4m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b57df52eaddc4612a00ee1836d8d40c6 : SUCCESS in 5m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c54606bb4474d0d88b0efd92bfcb98d : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":1},{"id":"f40c705834744276fcea57dcacf56e6ead32f5c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-05 11:13:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"bf412af505e11046d842042f9b795f011ca5667f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-05 11:15:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2f6dca14fb9423f9ece7efb70e7fb86 : SUCCESS in 1m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a22679b2bf80d47519fa5dc99659501933d7037","revisions":{"2a22679b2bf80d47519fa5dc99659501933d7037":{"kind":"REWORK","_number":1,"created":"2021-10-05 08:24:17.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/812435/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.vmware","ref":"refs/changes/35/812435/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/35/812435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/35/812435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.vmware refs/changes/35/812435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.vmware refs/changes/35/812435/1"}}},"commit":{"parents":[{"commit":"3e3fa66cb6f6e845c3f53bea8a13771c1f2b748f","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/3e3fa66cb6f6e845c3f53bea8a13771c1f2b748f"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-09-21 14:41:58.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-10-05 08:24:17.000000000","tz":0},"subject":"Don\u0027t use \u0027requests.PreparedRequest\u0027","message":"Don\u0027t use \u0027requests.PreparedRequest\u0027\n\nWe\u0027re using \u0027requests.PreparedRequest\u0027 in one place in the tests.\nHowever, the requests docs have a warning that one shouldn\u0027t do this:\n\n  Instances are generated from a Request object, and should not be\n  instantiated manually; doing so may produce undesirable effects.\n\nIt seems we\u0027re now seeing just such an effect, as requests has started\nattempting to do proxy-related things resulting in the following error:\n\n    Traceback (most recent call last):\n      File \"/usr/lib64/python3.6/unittest/mock.py\", line 1183, in patched\n    return func(*args, **keywargs)\n      File \".../oslo.vmware/oslo_vmware/tests/test_service.py\", line 518, in test_send_with_local_file_url\n    resp \u003d transport.session.send(request)\n      File \".../oslo.vmware/.tox/py36/lib/python3.6/site-packages/requests/sessions.py\", line 636, in send\n    kwargs.setdefault(\u0027proxies\u0027, self.rebuild_proxies(request, self.proxies))\n      File \".../oslo.vmware/.tox/py36/lib/python3.6/site-packages/requests/sessions.py\", line 301, in rebuild_proxies\n    if \u0027Proxy-Authorization\u0027 in headers:\n    TypeError: argument of type \u0027NoneType\u0027 is not iterable\n\nDo what we should have done from the beginning and use\n\u0027requests.Request.prepare\u0027 instead.\n\n[1] https://docs.python-requests.org/en/master/api/#requests.PreparedRequest\n\nChange-Id: I072c64904298cf83cb113e402d85fb62626f39f7\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n(cherry picked from commit e991194cbd82925c8bac43cb979f9262a49850e6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/2a22679b2bf80d47519fa5dc99659501933d7037"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.vmware/commit/2a22679b2bf80d47519fa5dc99659501933d7037"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}