)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unittest method \"test_download_flat_image\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, there is not a test method of down_load_flat_image."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8ed68222b3ef195464901d8c6442cc397ffdb272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FOQQ%3D","line":9,"updated":"2014-03-19 12:21:16.000000000","message":"download_flat_image","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"}],"tests/test_image_transfer.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        input_file.read.assert_called_once_with(rw_handles.READ_CHUNKSIZE)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ImageTransfer_UtilityTest(base.TestCase):"},{"line_number":185,"context_line":"    \"\"\"Tests for image_transfer utility methods.\"\"\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch.object(httplib.HTTPConnection, \u0027endheaders\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FONo%3D","line":184,"updated":"2014-03-19 12:21:16.000000000","message":"What about ImageTransferTest?\n\nWe should use CapWords convention for naming classes.\nhttp://legacy.python.org/dev/peps/pep-0008/#class-names","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"953158a08c08b3dacee7b13e2ac7f879f2328eac","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        input_file.read.assert_called_once_with(rw_handles.READ_CHUNKSIZE)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ImageTransfer_UtilityTest(base.TestCase):"},{"line_number":185,"context_line":"    \"\"\"Tests for image_transfer utility methods.\"\"\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch.object(httplib.HTTPConnection, \u0027endheaders\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FDT8%3D","line":184,"in_reply_to":"AAAAWH%2F%2FIrk%3D","updated":"2014-03-20 16:45:51.000000000","message":"My comment was about the underscore.\nImageTransferTest or ImageTransferUtilityTest should be fine.","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"ca4825912aeb59f5780659fd8cbb31f10716d431","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        input_file.read.assert_called_once_with(rw_handles.READ_CHUNKSIZE)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ImageTransfer_UtilityTest(base.TestCase):"},{"line_number":185,"context_line":"    \"\"\"Tests for image_transfer utility methods.\"\"\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch.object(httplib.HTTPConnection, \u0027endheaders\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FIrk%3D","line":184,"in_reply_to":"AAAAWH%2F%2FONo%3D","updated":"2014-03-20 13:10:26.000000000","message":"I agree with your idea. I just followed a name used in test_pbm.py, https://github.com/openstack/oslo.vmware/blob/master/tests/test_pbm.py Do you think we could change a name of \"PBMUtilityTest\" too?","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":184,"context_line":"class ImageTransfer_UtilityTest(base.TestCase):"},{"line_number":185,"context_line":"    \"\"\"Tests for image_transfer utility methods.\"\"\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @mock.patch.object(httplib.HTTPConnection, \u0027endheaders\u0027)"},{"line_number":188,"context_line":"    @mock.patch.object(image_transfer, \u0027_start_transfer\u0027)"},{"line_number":189,"context_line":"    def test_download_flat_image(self, fake_transfer, fake_http_conn):"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNx0%3D","line":187,"updated":"2014-03-19 12:21:16.000000000","message":"fake_http_conn is not used.","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        ds_name \u003d \u0027ds1\u0027"},{"line_number":205,"context_line":"        file_path \u003d \u0027/fake_path\u0027"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        def side_effect(*args, **kwargs):"},{"line_number":208,"context_line":"            if args[0] \u003d\u003d \u0027fake_iter\u0027:"},{"line_number":209,"context_line":"                return fake_ImageReadHandle"},{"line_number":210,"context_line":"            elif args \u003d\u003d (host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNuE%3D","line":207,"updated":"2014-03-19 12:21:16.000000000","message":"this can be removed","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                          image_size):"},{"line_number":216,"context_line":"                return fake_FileWriteHandle"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        rw_handles.ImageReadHandle \u003d mock.Mock()"},{"line_number":219,"context_line":"        rw_handles.ImageReadHandle.side_effect \u003d side_effect"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        rw_handles.FileWriteHandle \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNxI%3D","line":218,"updated":"2014-03-19 12:21:16.000000000","message":"Patching this class should be undone after this test.","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                return fake_FileWriteHandle"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        rw_handles.ImageReadHandle \u003d mock.Mock()"},{"line_number":219,"context_line":"        rw_handles.ImageReadHandle.side_effect \u003d side_effect"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        rw_handles.FileWriteHandle \u003d mock.Mock()"},{"line_number":222,"context_line":"        rw_handles.FileWriteHandle.side_effect \u003d side_effect"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNwQ%3D","line":219,"updated":"2014-03-19 12:21:16.000000000","message":"what about rw_handles.ImageReadHandle.return_value \u003d fake_ImageReadHandle","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        rw_handles.ImageReadHandle \u003d mock.Mock()"},{"line_number":219,"context_line":"        rw_handles.ImageReadHandle.side_effect \u003d side_effect"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        rw_handles.FileWriteHandle \u003d mock.Mock()"},{"line_number":222,"context_line":"        rw_handles.FileWriteHandle.side_effect \u003d side_effect"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        image_transfer.download_flat_image("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNw8%3D","line":221,"updated":"2014-03-19 12:21:16.000000000","message":"Patching this class should be undone after this test.","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        rw_handles.ImageReadHandle.side_effect \u003d side_effect"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        rw_handles.FileWriteHandle \u003d mock.Mock()"},{"line_number":222,"context_line":"        rw_handles.FileWriteHandle.side_effect \u003d side_effect"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        image_transfer.download_flat_image("},{"line_number":225,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNwA%3D","line":222,"updated":"2014-03-19 12:21:16.000000000","message":"rw_handles.FileWriteHandle.return_value \u003d fake_FileWriteHandle","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f5d1e21f195c20dddd599db67da9f85b337644a5","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            file_path\u003dfile_path)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        image_service.download.assert_called_once_with(context, image_id)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        fake_transfer.assert_called_once_with("},{"line_number":239,"context_line":"            context,"},{"line_number":240,"context_line":"            timeout_secs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNrs%3D","line":237,"updated":"2014-03-19 12:21:16.000000000","message":"can also assert for rw_handles.ImageReadHandle and rw_handles.FileWriteHandle.\n\nrw_handles.ImageReadHandle.assert_called_once_with(\u0027fake_iter\u0027)","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"953158a08c08b3dacee7b13e2ac7f879f2328eac","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            file_path\u003dfile_path)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        image_service.download.assert_called_once_with(context, image_id)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        fake_transfer.assert_called_once_with("},{"line_number":239,"context_line":"            context,"},{"line_number":240,"context_line":"            timeout_secs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FDPw%3D","line":237,"in_reply_to":"AAAAWH%2F%2FInA%3D","updated":"2014-03-20 16:45:51.000000000","message":"Please use patch decorators.\nhttp://www.voidspace.org.uk/python/mock/patch.html#patch\n\n@patch(\u0027oslo.vmware.rw_handles.ImageReadHandle\u0027)\n@patch(\u0027oslo.vmware.rw_handles.FileWriteHandle\u0027)","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"ca4825912aeb59f5780659fd8cbb31f10716d431","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            file_path\u003dfile_path)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        image_service.download.assert_called_once_with(context, image_id)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        fake_transfer.assert_called_once_with("},{"line_number":239,"context_line":"            context,"},{"line_number":240,"context_line":"            timeout_secs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FInA%3D","line":237,"in_reply_to":"AAAAWH%2F%2FNrs%3D","updated":"2014-03-20 13:10:26.000000000","message":"Sure. And do you think that I could undone both classes here?\ne.g.\n        rw_handles.ImageReadHandle.assert_called_once_with(\u0027fake_iter\u0027)\n        rw_handles.ImageReadHandle.stop\n\n        rw_handles.FileWriteHandle.assert_called_once_with(...)\n        rw_handles.FileWriteHandle.stop","commit_id":"35f99aae3ae52030879be88cac04a965d7be61e4"}]}
