)]}'
{"oslo/vmware/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dd90f5bc06f1d3473fa7ede377fb3b823c75ff32","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \"\"\"Setup a session with the server and handles all calls made to it."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    Example:"},{"line_number":128,"context_line":"        api_session \u003d VMwareAPISession(\u002710.1.2.3\u0027, \u0027administrator\u0027, \u0027password\u0027,"},{"line_number":129,"context_line":"                                       10, 0.1, create_session\u003dFalse)"},{"line_number":130,"context_line":"        result \u003d api_session.invoke_api(vim_util, \u0027get_objects\u0027,"},{"line_number":131,"context_line":"                                        api_session.vim, \u0027HostSystem\u0027, 100)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_928094c1","side":"PARENT","line":128,"updated":"2014-05-07 11:06:36.000000000","message":"Please add port number.","commit_id":"a150cf7bf1233638293e593c564e25dbbbec70ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"50deca4cb9f255e1b68ba427217fa1e4a989f003","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \"\"\"Setup a session with the server and handles all calls made to it."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    Example:"},{"line_number":128,"context_line":"        api_session \u003d VMwareAPISession(\u002710.1.2.3\u0027, \u0027administrator\u0027, \u0027password\u0027,"},{"line_number":129,"context_line":"                                       10, 0.1, create_session\u003dFalse)"},{"line_number":130,"context_line":"        result \u003d api_session.invoke_api(vim_util, \u0027get_objects\u0027,"},{"line_number":131,"context_line":"                                        api_session.vim, \u0027HostSystem\u0027, 100)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_c62341a5","side":"PARENT","line":128,"in_reply_to":"9ad9bd40_928094c1","updated":"2014-05-07 11:19:28.000000000","message":"Done","commit_id":"a150cf7bf1233638293e593c564e25dbbbec70ab"}],"oslo/vmware/pbm.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dd90f5bc06f1d3473fa7ede377fb3b823c75ff32","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        :param pbm_wsdl_loc: PBM WSDL file location"},{"line_number":45,"context_line":"        :param protocol: http or https"},{"line_number":46,"context_line":"        :param host: server IP address[:port] or host name[:port]"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        self._url \u003d vim_util.get_soap_url(protocol, host, \u0027pbm\u0027)"},{"line_number":49,"context_line":"        self._pbm_client \u003d suds.client.Client(pbm_wsdl_loc, location\u003dself._url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_9267b44c","side":"PARENT","line":46,"updated":"2014-05-07 11:06:36.000000000","message":"\"param port\" missing","commit_id":"a150cf7bf1233638293e593c564e25dbbbec70ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"50deca4cb9f255e1b68ba427217fa1e4a989f003","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        :param pbm_wsdl_loc: PBM WSDL file location"},{"line_number":45,"context_line":"        :param protocol: http or https"},{"line_number":46,"context_line":"        :param host: server IP address[:port] or host name[:port]"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        self._url \u003d vim_util.get_soap_url(protocol, host, \u0027pbm\u0027)"},{"line_number":49,"context_line":"        self._pbm_client \u003d suds.client.Client(pbm_wsdl_loc, location\u003dself._url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_26322df2","side":"PARENT","line":46,"in_reply_to":"9ad9bd40_9267b44c","updated":"2014-05-07 11:19:28.000000000","message":"Done","commit_id":"a150cf7bf1233638293e593c564e25dbbbec70ab"}],"oslo/vmware/rw_handles.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e914739289beb9d68505f0984de1f0dfc0b7136a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        urlp \u003d urlparse.urlparse(url)"},{"line_number":119,"context_line":"        if urlp.netloc \u003d\u003d \u0027*\u0027:"},{"line_number":120,"context_line":"            scheme, netloc, path, params, query, fragment \u003d urlp"},{"line_number":121,"context_line":"            if netaddr.valid_ipv6(host):"},{"line_number":122,"context_line":"                netloc \u003d \u0027[%s]:%d\u0027 % (host, port)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                netloc \u003d \"%s:%d\" % (host, port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_7881ba8e","line":121,"updated":"2014-05-08 21:41:33.000000000","message":"We have similar logic in the incubator module network_utils.py. Can that be reused here by using that module to parse the URL and then using urlunparse() to re-build it?","commit_id":"a76bd253fb4fa54c72d3440f2345642b209b5f41"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bb4d425228943888b363e34689aacfc4d402de74","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        urlp \u003d urlparse.urlparse(url)"},{"line_number":119,"context_line":"        if urlp.netloc \u003d\u003d \u0027*\u0027:"},{"line_number":120,"context_line":"            scheme, netloc, path, params, query, fragment \u003d urlp"},{"line_number":121,"context_line":"            if netaddr.valid_ipv6(host):"},{"line_number":122,"context_line":"                netloc \u003d \u0027[%s]:%d\u0027 % (host, port)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                netloc \u003d \"%s:%d\" % (host, port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_58a6cc54","line":121,"in_reply_to":"7adec928_2d27e465","updated":"2014-05-21 13:56:46.000000000","message":"I swear I tested that and was able to make it work. I wonder what I did special? We should think about adding an IPv6-aware urlunparse function to network_utils.","commit_id":"a76bd253fb4fa54c72d3440f2345642b209b5f41"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"5bf563de9055d68fb1f694216b179125fe16cae9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        urlp \u003d urlparse.urlparse(url)"},{"line_number":119,"context_line":"        if urlp.netloc \u003d\u003d \u0027*\u0027:"},{"line_number":120,"context_line":"            scheme, netloc, path, params, query, fragment \u003d urlp"},{"line_number":121,"context_line":"            if netaddr.valid_ipv6(host):"},{"line_number":122,"context_line":"                netloc \u003d \u0027[%s]:%d\u0027 % (host, port)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                netloc \u003d \"%s:%d\" % (host, port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_2d27e465","line":121,"in_reply_to":"7adec928_7881ba8e","updated":"2014-05-09 11:23:16.000000000","message":"@Doug, unfortunately parse_host_port can only split a string with a host+port into its components. we know we have a host, we just don\u0027t know if it is ipv6 or not. Also urlunparse cannot build the special ipv6 url with \u0027[\u0027 and \u0027]\u0027 so no, network_utils.py won\u0027t help","commit_id":"a76bd253fb4fa54c72d3440f2345642b209b5f41"}],"oslo/vmware/vim_util.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e914739289beb9d68505f0984de1f0dfc0b7136a","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    :param path: path part of the SOAP URL"},{"line_number":389,"context_line":"    :returns: SOAP service URL"},{"line_number":390,"context_line":"    \"\"\""},{"line_number":391,"context_line":"    if netaddr.valid_ipv6(host):"},{"line_number":392,"context_line":"        if port is None:"},{"line_number":393,"context_line":"            return \u0027%s://[%s]/%s\u0027 % (protocol, host, path)"},{"line_number":394,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_933107ef","line":391,"updated":"2014-05-08 21:41:33.000000000","message":"Would using urlparse.urlunparse() simplify this code?","commit_id":"a76bd253fb4fa54c72d3440f2345642b209b5f41"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"5bf563de9055d68fb1f694216b179125fe16cae9","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    :param path: path part of the SOAP URL"},{"line_number":389,"context_line":"    :returns: SOAP service URL"},{"line_number":390,"context_line":"    \"\"\""},{"line_number":391,"context_line":"    if netaddr.valid_ipv6(host):"},{"line_number":392,"context_line":"        if port is None:"},{"line_number":393,"context_line":"            return \u0027%s://[%s]/%s\u0027 % (protocol, host, path)"},{"line_number":394,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_6d200c4a","line":391,"in_reply_to":"7adec928_933107ef","updated":"2014-05-09 11:23:16.000000000","message":"Ditto.","commit_id":"a76bd253fb4fa54c72d3440f2345642b209b5f41"}]}