)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4091f6b297677f941b6841a85d274224de96f374","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaru Nomura \u003cmassa.nomura@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-23 18:55:08 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add two files to oslo/vmware and tests/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds vmdk.py and test_vmdk.py(correspoing unit tests)"},{"line_number":10,"context_line":"vmdk.py has a class API which has the following methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_2ba07a42","line":7,"updated":"2014-05-23 18:00:17.000000000","message":"Could you provide a more descriptive summary? Maybe something like \"Add API for introspecting VMDKs\"?","commit_id":"a5959b28e3d136ede8c9f1ce75b43d8658107a5c"}],"oslo/vmware/vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f46c878741b351595e1273dc263f5f33ae36ffb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class API(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_adapter_type(self, vmdk):"},{"line_number":28,"context_line":"        \"\"\"Return string of adapater type defined in VMDK file"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0f3d1d2b","line":25,"updated":"2014-07-07 15:57:58.000000000","message":"Consider giving a different name.","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"35365829916a41019d06d20115495511dd6248c3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class API(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_adapter_type(self, vmdk):"},{"line_number":28,"context_line":"        \"\"\"Return string of adapater type defined in VMDK file"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_7a6283db","line":25,"in_reply_to":"baada198_0f3d1d2b","updated":"2014-08-13 15:34:23.000000000","message":"Sure, I\u0027ll try to come up with the different name for the next patch set.","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f02bc269cc4b77931873c5696030183c66645f6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                info \u003d line.split()"},{"line_number":41,"context_line":"                if info \u003d\u003d []:"},{"line_number":42,"context_line":"                    continue"},{"line_number":43,"context_line":"                if info[0] \u003d\u003d \u0027ddb.adapterType\u0027:"},{"line_number":44,"context_line":"                    #info format \u003d\u003e [\u0027ddb.adapterType\u0027,\u0027\u003d\u0027,adapter_type]"},{"line_number":45,"context_line":"                    return info[2]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_83b95918","line":43,"updated":"2014-06-26 06:38:29.000000000","message":"I don\u0027t think we can rely on descriptor ddb section to find the adapter type. For example, one can create a VM from a streamOptimized image and the import spec can specify an adapter type which is different from the ddb.adapterType in the streamOptimized image. The adapterType corresponding to the disk (one that shows up in UI) is the adapterType in the spec and not the one in the ddb section.\n\nThe adapter type can be determined using the controller key associated with the VirtualDevice corresponding to the virtual disk.","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"ba19db537bee22a2bf514c17bfa0d64d7e27623e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                info \u003d line.split()"},{"line_number":41,"context_line":"                if info \u003d\u003d []:"},{"line_number":42,"context_line":"                    continue"},{"line_number":43,"context_line":"                if info[0] \u003d\u003d \u0027ddb.adapterType\u0027:"},{"line_number":44,"context_line":"                    #info format \u003d\u003e [\u0027ddb.adapterType\u0027,\u0027\u003d\u0027,adapter_type]"},{"line_number":45,"context_line":"                    return info[2]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0652a93a","line":43,"in_reply_to":"1ae5cdf2_83b95918","updated":"2014-07-04 00:33:28.000000000","message":"I think there is some confusion here.\nThe goal here is to introspect VMDKs when it is an image (file) not a disk for in a VM yet. For example, a vmdk stored in Glance would not have the VirtualDevice afaik.\nFrom that perspective, I think Masaru\u0027s approach is correct.\nHowever, since there is confusion, it would make sense to add comments to explain exactly what we are doing here.\n\nDoes that make sense?","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f46c878741b351595e1273dc263f5f33ae36ffb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                info \u003d line.split()"},{"line_number":41,"context_line":"                if info \u003d\u003d []:"},{"line_number":42,"context_line":"                    continue"},{"line_number":43,"context_line":"                if info[0] \u003d\u003d \u0027ddb.adapterType\u0027:"},{"line_number":44,"context_line":"                    #info format \u003d\u003e [\u0027ddb.adapterType\u0027,\u0027\u003d\u0027,adapter_type]"},{"line_number":45,"context_line":"                    return info[2]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_8f95ad34","line":43,"in_reply_to":"baada198_0652a93a","updated":"2014-07-07 15:57:58.000000000","message":"So this change is to read the properties of a vmdk image file in glance. This should be made clear in the commit message as well. Also, add necessary module/class comments.\n\nArnaud,\n\nWhat exactly is the use case of this? Is it used for sanity check?\nAdmin should be able to create a glance image with an adapter type which may be different from the adapter type in the ddb section.\n\nWill this approach work for preallocated images?","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebbcacebb04a24597bdf6b98ca282828cb47c9e6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                if info \u003d\u003d []:"},{"line_number":77,"context_line":"                    continue"},{"line_number":78,"context_line":"                if info[0] \u003d\u003d \u0027createType\u0027:"},{"line_number":79,"context_line":"                    #info format \u003d\u003e [\u0027createType\u0027, disk_type\u0027\\n\u0027]"},{"line_number":80,"context_line":"                    createType_without_newline \u003d info[1][:-1]"},{"line_number":81,"context_line":"                    return createType_without_newline"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2a61d237","line":79,"updated":"2014-08-12 17:43:22.000000000","message":"i think that you can drop the \\n","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"35365829916a41019d06d20115495511dd6248c3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                if info \u003d\u003d []:"},{"line_number":77,"context_line":"                    continue"},{"line_number":78,"context_line":"                if info[0] \u003d\u003d \u0027createType\u0027:"},{"line_number":79,"context_line":"                    #info format \u003d\u003e [\u0027createType\u0027, disk_type\u0027\\n\u0027]"},{"line_number":80,"context_line":"                    createType_without_newline \u003d info[1][:-1]"},{"line_number":81,"context_line":"                    return createType_without_newline"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_5a093f2a","line":79,"in_reply_to":"baada198_2a61d237","updated":"2014-08-13 15:34:23.000000000","message":"Do you mean I don\u0027t have to clearly state that the last element, disk_type in this case, has a new line character at the end?","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f02bc269cc4b77931873c5696030183c66645f6","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def extract_virtual_size(file):"},{"line_number":109,"context_line":"            for line in file:"},{"line_number":110,"context_line":"                if line \u003d\u003d \u0027# Extent description\\n\u0027:"},{"line_number":111,"context_line":"                    # description format \u003d\u003e \u0027\u003caccesstype\u003e[space]\u003csize\u003e[space]\u0027"},{"line_number":112,"context_line":"                    description \u003d file.next()"},{"line_number":113,"context_line":"                    size \u003d description.split()[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_835079d6","line":110,"updated":"2014-06-26 06:38:29.000000000","message":"Why can\u0027t we get it from VirtualDisk.capacityInKB?","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"ba19db537bee22a2bf514c17bfa0d64d7e27623e","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def extract_virtual_size(file):"},{"line_number":109,"context_line":"            for line in file:"},{"line_number":110,"context_line":"                if line \u003d\u003d \u0027# Extent description\\n\u0027:"},{"line_number":111,"context_line":"                    # description format \u003d\u003e \u0027\u003caccesstype\u003e[space]\u003csize\u003e[space]\u0027"},{"line_number":112,"context_line":"                    description \u003d file.next()"},{"line_number":113,"context_line":"                    size \u003d description.split()[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_46482187","line":110,"in_reply_to":"1ae5cdf2_835079d6","updated":"2014-07-04 00:33:28.000000000","message":"ditto","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f46c878741b351595e1273dc263f5f33ae36ffb","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def extract_virtual_size(file):"},{"line_number":109,"context_line":"            for line in file:"},{"line_number":110,"context_line":"                if line \u003d\u003d \u0027# Extent description\\n\u0027:"},{"line_number":111,"context_line":"                    # description format \u003d\u003e \u0027\u003caccesstype\u003e[space]\u003csize\u003e[space]\u0027"},{"line_number":112,"context_line":"                    description \u003d file.next()"},{"line_number":113,"context_line":"                    size \u003d description.split()[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_6f2e99fc","line":110,"in_reply_to":"baada198_46482187","updated":"2014-07-07 15:57:58.000000000","message":"But this is still wrong. It gives only the number of sectors.","commit_id":"77c7fb1ca48530b678670fe92ac08efe67fadfc0"}],"tests/test_vmdk.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"43df8daaea181434617500c4fb40642baad0ed78","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        with contextlib.nested(tempfile.NamedTemporaryFile(),"},{"line_number":52,"context_line":"                               tempfile.NamedTemporaryFile(),"},{"line_number":53,"context_line":"                               tempfile.NamedTemporaryFile()) \\"},{"line_number":54,"context_line":"                as (monolithicSparse, monolithicFlat, streamOptimized):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            monolithicSparse.write(monolithicSparse_vmdk[\u0027vmdk\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b12b0881","line":53,"updated":"2014-06-18 12:23:49.000000000","message":"can we please try and write this without the \\","commit_id":"520b3161737796df1895d7eb446100d28218a8eb"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"7b0b0dff3b96bdc215f910d101375f963d9e57ef","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        with contextlib.nested(tempfile.NamedTemporaryFile(),"},{"line_number":52,"context_line":"                               tempfile.NamedTemporaryFile(),"},{"line_number":53,"context_line":"                               tempfile.NamedTemporaryFile()) \\"},{"line_number":54,"context_line":"                as (monolithicSparse, monolithicFlat, streamOptimized):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            monolithicSparse.write(monolithicSparse_vmdk[\u0027vmdk\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b7b693da","line":53,"in_reply_to":"1ae5cdf2_b12b0881","updated":"2014-06-18 15:01:42.000000000","message":"Done","commit_id":"520b3161737796df1895d7eb446100d28218a8eb"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"933a8860d8c356b3f6853efcfd8620ca4eae3c13","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        with contextlib.nested(tempfile.NamedTemporaryFile(),"},{"line_number":52,"context_line":"                               tempfile.NamedTemporaryFile(),"},{"line_number":53,"context_line":"                               tempfile.NamedTemporaryFile()) \\"},{"line_number":54,"context_line":"                as (monolithicSparse, monolithicFlat, streamOptimized):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            monolithicSparse.write(monolithicSparse_vmdk[\u0027vmdk\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_79687a88","line":53,"in_reply_to":"1ae5cdf2_b12b0881","updated":"2014-06-18 16:50:47.000000000","message":"It seems that pep8 and unittest  fail without \u0027\\\u0027 .","commit_id":"520b3161737796df1895d7eb446100d28218a8eb"},{"author":{"_account_id":10839,"name":"Masaru Nomura","email":"massa.nomura@gmail.com","username":"massa"},"change_message_id":"77881a12e18723276301bc04539f193027acce7e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        with contextlib.nested(tempfile.NamedTemporaryFile(),"},{"line_number":52,"context_line":"                               tempfile.NamedTemporaryFile(),"},{"line_number":53,"context_line":"                               tempfile.NamedTemporaryFile()) \\"},{"line_number":54,"context_line":"                as (monolithicSparse, monolithicFlat, streamOptimized):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            monolithicSparse.write(monolithicSparse_vmdk[\u0027vmdk\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_ddba59e0","line":53,"in_reply_to":"1ae5cdf2_b12b0881","updated":"2014-06-18 17:14:05.000000000","message":"Okay, to avoid using contexlib.nested with \u0027\\\u0027, we can use three with(s) to create three tempfiles. Could you give me your opinions on this please?\nThis could be something like -\u003e\nwith tempfile.NamedTemporaryFile() as f1:\n[indent] with tempfile.NamedTemporaryFile() as f2:\n[indent] [indent] with tempfile.NamedTemporaryFile() as f3: [followed by contents]","commit_id":"520b3161737796df1895d7eb446100d28218a8eb"}]}
