)]}'
{"tools/oslo_debug_helper":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0e45a860fc752e616f65a93944f6fc990e1e3f16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# relative to the project directory. If no value is passed, it is assumed"},{"line_number":11,"context_line":"# to be packagename/tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -n \"${PYTHON}\" ] ; then"},{"line_number":14,"context_line":"\tPYTHON\u003dpython"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_a365b91f","line":13,"updated":"2018-06-04 14:22:12.000000000","message":"What sets PYTHON outside of this script?","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a223794afdd901c0b7eca0adab573ff03914f7d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# relative to the project directory. If no value is passed, it is assumed"},{"line_number":11,"context_line":"# to be packagename/tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -n \"${PYTHON}\" ] ; then"},{"line_number":14,"context_line":"\tPYTHON\u003dpython"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f7f25105","line":13,"in_reply_to":"5f7c97a3_7c85f1ad","updated":"2019-12-18 14:45:48.000000000","message":"Done","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4c0d3a886dba6d418b4f64e6f7d02f0018db36c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# relative to the project directory. If no value is passed, it is assumed"},{"line_number":11,"context_line":"# to be packagename/tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -n \"${PYTHON}\" ] ; then"},{"line_number":14,"context_line":"\tPYTHON\u003dpython"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_7c85f1ad","line":13,"in_reply_to":"5f7c97a3_a365b91f","updated":"2018-06-15 22:13:06.000000000","message":"This could be done more succinctly as:\n\nPYTHON\u003d${PYTHON:-python}\n\nWhich will use the value of $PYTHON if it\u0027s set, otherwise default to \u0027python\u0027.","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d98e4597af248672b73db15452f013342e37adfb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# to be packagename/tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -n \"${PYTHON}\" ] ; then"},{"line_number":14,"context_line":"\tPYTHON\u003dpython"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"TMP_DIR\u003d`mktemp -d debug-$$-XXX` || exit 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_47e00327","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":1},"updated":"2018-06-08 10:55:56.000000000","message":"nit: should be spaces","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a223794afdd901c0b7eca0adab573ff03914f7d8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# to be packagename/tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -n \"${PYTHON}\" ] ; then"},{"line_number":14,"context_line":"\tPYTHON\u003dpython"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"TMP_DIR\u003d`mktemp -d debug-$$-XXX` || exit 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_97d75d51","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":1},"in_reply_to":"5f7c97a3_47e00327","updated":"2019-12-18 14:45:48.000000000","message":"Done","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4c0d3a886dba6d418b4f64e6f7d02f0018db36c3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"TEST_DIR\u003d./$PACKAGENAME/tests"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# If a specific path is passed, use that one"},{"line_number":28,"context_line":"while getopts \":t:\" opt; do"},{"line_number":29,"context_line":"    case $opt in"},{"line_number":30,"context_line":"        t) TEST_DIR\u003d$OPTARG;;"},{"line_number":31,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_9fd6bf53","line":28,"updated":"2018-06-15 22:13:06.000000000","message":"What if we made -p an explicit option on the script and set $PYTHON based on that?  Then instead of setting PACKAGENAME and TEST_DIR above this, we set them below only if TEST_DIR isn\u0027t already set.  That way if a user specified a different python we\u0027ll use it to run setup.py, and as an added bonus we don\u0027t make the unnecessary call at all if the user passed in an explicit test dir.\n\nEdit: As much as I have an aversion to input environment variables, looking at the next file in this change I see we were already doing that.  Since that file wasn\u0027t using getopts already, maybe we should just stick with the $PYTHON pattern.","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"}],"tools/oslo_run_cross_tests":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4c0d3a886dba6d418b4f64e6f7d02f0018db36c3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    elif [ -f \".testrepository/0\" ] ; then"},{"line_number":93,"context_line":"        .tox/$venv/bin/subunit-1to2 \u003c .testrepository/0 \u003e ./subunit_log.txt"},{"line_number":94,"context_line":"    fi"},{"line_number":95,"context_line":"    .tox/$venv/bin/${PYTHON} /usr/local/jenkins/slave_scripts/subunit2html.py ./subunit_log.txt testr_results.html"},{"line_number":96,"context_line":"    gzip -9 ./subunit_log.txt"},{"line_number":97,"context_line":"    gzip -9 ./testr_results.html"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_bf3dbb8f","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":28},"updated":"2018-06-15 22:13:06.000000000","message":"We don\u0027t want to override the python version in the venv.  In a py27 job the python3 binary won\u0027t even be present.\n\nNote that tox correctly links \"python\" to the appropriate version, so it\u0027s okay to hardcode the name here.","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a223794afdd901c0b7eca0adab573ff03914f7d8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    elif [ -f \".testrepository/0\" ] ; then"},{"line_number":93,"context_line":"        .tox/$venv/bin/subunit-1to2 \u003c .testrepository/0 \u003e ./subunit_log.txt"},{"line_number":94,"context_line":"    fi"},{"line_number":95,"context_line":"    .tox/$venv/bin/${PYTHON} /usr/local/jenkins/slave_scripts/subunit2html.py ./subunit_log.txt testr_results.html"},{"line_number":96,"context_line":"    gzip -9 ./subunit_log.txt"},{"line_number":97,"context_line":"    gzip -9 ./testr_results.html"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_d7c6359d","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":28},"in_reply_to":"5f7c97a3_bf3dbb8f","updated":"2019-12-18 14:45:48.000000000","message":"Done","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4c0d3a886dba6d418b4f64e6f7d02f0018db36c3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    gzip -9 ./subunit_log.txt"},{"line_number":97,"context_line":"    gzip -9 ./testr_results.html"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    export PYTHON\u003d.tox/$venv/bin/${PYTHON}"},{"line_number":100,"context_line":"    set -e"},{"line_number":101,"context_line":"    rancount\u003d$(.tox/$venv/bin/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":102,"context_line":"    if [ \"$rancount\" -eq \"0\" ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_df10b703","line":99,"updated":"2018-06-15 22:13:06.000000000","message":"Ditto, although this raises the interesting point that $PYTHON was already being used as an input variable to something (testr?), so I guess there\u0027s precedent for this.","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a223794afdd901c0b7eca0adab573ff03914f7d8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    gzip -9 ./subunit_log.txt"},{"line_number":97,"context_line":"    gzip -9 ./testr_results.html"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    export PYTHON\u003d.tox/$venv/bin/${PYTHON}"},{"line_number":100,"context_line":"    set -e"},{"line_number":101,"context_line":"    rancount\u003d$(.tox/$venv/bin/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":102,"context_line":"    if [ \"$rancount\" -eq \"0\" ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f7cb31a1","line":99,"in_reply_to":"5f7c97a3_df10b703","updated":"2019-12-18 14:45:48.000000000","message":"Done","commit_id":"e7966291504b935f79e20c040b5567bdc0f31a9d"}]}