)]}'
{"osprofiler/opts.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"91947e90f56a624773cb069aaa4e8b583ad896b3","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def list_opts():"},{"line_number":121,"context_line":"    return [(_profiler_opt_group.name, copy.deepcopy(_PROFILER_OPTS))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_42baec0b","line":121,"updated":"2016-01-19 20:50:51.000000000","message":"@dims: I got comment https://review.openstack.org/#/c/254703/19/nova/conf/profiler_options.py - line 81. Do you think it\u0027s valid here?","commit_id":"d77e1bc7b96650cd0beedf52508bef358f9771dd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"d11dc55a3523e8170f678d381ae69cf77e5a6370","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def list_opts():"},{"line_number":121,"context_line":"    return [(_profiler_opt_group.name, copy.deepcopy(_PROFILER_OPTS))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_85ab0ed6","line":121,"in_reply_to":"ba63e191_224fb8be","updated":"2016-01-19 21:08:09.000000000","message":"should we use other oslo lib style? I would say yes to have identical styles here.","commit_id":"d77e1bc7b96650cd0beedf52508bef358f9771dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"be457d3aa379a6315afead1fe70c2bd16c6334f1","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def list_opts():"},{"line_number":121,"context_line":"    return [(_profiler_opt_group.name, copy.deepcopy(_PROFILER_OPTS))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_224fb8be","line":121,"in_reply_to":"ba63e191_42baec0b","updated":"2016-01-19 21:00:42.000000000","message":"This is the style from other oslo libs, i think either one should work.","commit_id":"d77e1bc7b96650cd0beedf52508bef358f9771dd"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"45bb6dbfafd57b7ca7c892d75644a1d82fd991f8","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def list_opts():"},{"line_number":121,"context_line":"    return [(_profiler_opt_group.name, copy.deepcopy(_PROFILER_OPTS))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_93bb3fe5","line":121,"in_reply_to":"ba63e191_85ab0ed6","updated":"2016-01-20 08:32:31.000000000","message":"The style we\u0027ve chosen there (the dict) is *not* directly used by \"oslo.config\". We have in Nova a \"nova/conf/opts.py\" which is the single point of entry for the config generation. The interface to \"oslo.config\" is there still a list of tuples with (group, list of opts). IOW, the code you have here in line 121 is correct.","commit_id":"d77e1bc7b96650cd0beedf52508bef358f9771dd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"8eed09bd7d369c78b001cc02bed4bceacdfa1b7f","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def list_opts():"},{"line_number":121,"context_line":"    return [(_profiler_opt_group.name, copy.deepcopy(_PROFILER_OPTS))]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_0956425c","line":121,"in_reply_to":"ba63e191_93bb3fe5","updated":"2016-01-20 09:18:16.000000000","message":"thanks!","commit_id":"d77e1bc7b96650cd0beedf52508bef358f9771dd"}]}