)]}'
{"osprofiler/initializer.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b5ceb3757674626ae3fd7be11f465b7de4d537a5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from osprofiler import web"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def init_from_conf(conf, context, project, service, host):"},{"line_number":22,"context_line":"    \"\"\"Initialize notifier from service configuration"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    :param conf: service configuration"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_112bfe31","line":21,"updated":"2016-07-18 10:28:03.000000000","message":"I think we should move this to profiler module. I don\u0027t see any value having a separate module for this function.","commit_id":"f94b9fb8bed94bdc1d0273320e0e5e6dd038d667"},{"author":{"_account_id":21765,"name":"Aleksandr Ignatev","email":"aignatyev@mirantis.com","username":"aignatyev"},"change_message_id":"61acfdb1d4e4fb4c51a79e8770b572969f752633","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from osprofiler import web"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def init_from_conf(conf, context, project, service, host):"},{"line_number":22,"context_line":"    \"\"\"Initialize notifier from service configuration"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    :param conf: service configuration"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a0f8d97d","line":21,"in_reply_to":"dada55a8_112bfe31","updated":"2016-07-18 11:07:35.000000000","message":"Moving it to profiler causes import loop.","commit_id":"f94b9fb8bed94bdc1d0273320e0e5e6dd038d667"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3370d668f588bd425e54bac925a767613ba02fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"from osprofiler import notifier"},{"line_number":18,"context_line":"from osprofiler import web"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e0fc9140","line":17,"updated":"2016-07-18 11:17:30.000000000","message":"We need a blank line after the oslo_messaging import.","commit_id":"ddb680e15ef52484ff9129716c2153133417991d"},{"author":{"_account_id":21765,"name":"Aleksandr Ignatev","email":"aignatyev@mirantis.com","username":"aignatyev"},"change_message_id":"8d973d9896cbce65bbd4da2a5bf2f854d5bd706a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"from osprofiler import notifier"},{"line_number":18,"context_line":"from osprofiler import web"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_79a05c91","line":17,"in_reply_to":"dada55a8_e0fc9140","updated":"2016-07-18 12:10:30.000000000","message":"Done","commit_id":"ddb680e15ef52484ff9129716c2153133417991d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3370d668f588bd425e54bac925a767613ba02fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    connection_str \u003d conf.profiler.connection_string"},{"line_number":32,"context_line":"    _notifier \u003d notifier.create("},{"line_number":33,"context_line":"        connection_str,"},{"line_number":34,"context_line":"        messaging\u003doslo_messaging,"},{"line_number":35,"context_line":"        context\u003dcontext,"},{"line_number":36,"context_line":"        transport\u003doslo_messaging.get_transport(conf),"},{"line_number":37,"context_line":"        project\u003dproject,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c0034d0e","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":32},"updated":"2016-07-18 11:17:30.000000000","message":"Why do we need a dependency on oslo_messaging? I think we need oslo_messaging dependency only if the driver is messaging. We don\u0027t need it if we use mongoDB driver.","commit_id":"ddb680e15ef52484ff9129716c2153133417991d"},{"author":{"_account_id":21765,"name":"Aleksandr Ignatev","email":"aignatyev@mirantis.com","username":"aignatyev"},"change_message_id":"8d973d9896cbce65bbd4da2a5bf2f854d5bd706a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    connection_str \u003d conf.profiler.connection_string"},{"line_number":32,"context_line":"    _notifier \u003d notifier.create("},{"line_number":33,"context_line":"        connection_str,"},{"line_number":34,"context_line":"        messaging\u003doslo_messaging,"},{"line_number":35,"context_line":"        context\u003dcontext,"},{"line_number":36,"context_line":"        transport\u003doslo_messaging.get_transport(conf),"},{"line_number":37,"context_line":"        project\u003dproject,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_165e4fe9","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":32},"in_reply_to":"dada55a8_c0034d0e","updated":"2016-07-18 12:10:30.000000000","message":"MongoDB and Elasticsearch won\u0027t use this argument. This is done to provide support for queue messaging only. Same goes for transport and context.","commit_id":"ddb680e15ef52484ff9129716c2153133417991d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e3ac2363b4a71d94b5a3054ce96c1665d1793e0e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    connection_str \u003d conf.profiler.connection_string"},{"line_number":33,"context_line":"    _notifier \u003d notifier.create("},{"line_number":34,"context_line":"        connection_str,"},{"line_number":35,"context_line":"        messaging\u003doslo_messaging,"},{"line_number":36,"context_line":"        context\u003dcontext,"},{"line_number":37,"context_line":"        transport\u003doslo_messaging.get_transport(conf),"},{"line_number":38,"context_line":"        project\u003dproject,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_917017de","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":32},"updated":"2016-07-20 10:20:22.000000000","message":"IIUC osprofiler doesn\u0027t need oslo_messaging dependency if the backend is not ceilometer. Is there any way we can move messaging related arguments to drivers/messaging.py?","commit_id":"aca7aeb13384bae39172fe1186ea62e58f52e493"},{"author":{"_account_id":21765,"name":"Aleksandr Ignatev","email":"aignatyev@mirantis.com","username":"aignatyev"},"change_message_id":"60a5dc1c7b3da315cc26c6aba177a957ef93d804","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    connection_str \u003d conf.profiler.connection_string"},{"line_number":33,"context_line":"    _notifier \u003d notifier.create("},{"line_number":34,"context_line":"        connection_str,"},{"line_number":35,"context_line":"        messaging\u003doslo_messaging,"},{"line_number":36,"context_line":"        context\u003dcontext,"},{"line_number":37,"context_line":"        transport\u003doslo_messaging.get_transport(conf),"},{"line_number":38,"context_line":"        project\u003dproject,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_d299acc5","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":32},"in_reply_to":"dada55a8_917017de","updated":"2016-07-21 11:44:56.000000000","message":"You are right. This needed to be done, but not in this patchset. Right now we still need to support old api, before migrating all existing code in services to new api with initializer. After that we will be able to change notifier.create method without breaking anything, as it will be only used inside profiler.","commit_id":"aca7aeb13384bae39172fe1186ea62e58f52e493"}],"requirements.txt":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b5ceb3757674626ae3fd7be11f465b7de4d537a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":2,"context_line":"oslo.messaging\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":3,"context_line":"oslo.utils\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":4,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"dada55a8_31dd6243","line":2,"updated":"2016-07-18 10:28:03.000000000","message":"There is no mentioning of this change in the commit.","commit_id":"f94b9fb8bed94bdc1d0273320e0e5e6dd038d667"},{"author":{"_account_id":21765,"name":"Aleksandr Ignatev","email":"aignatyev@mirantis.com","username":"aignatyev"},"change_message_id":"2cdfa4361b1a322e700e0a521211d6189d488ad6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":2,"context_line":"oslo.messaging\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":3,"context_line":"oslo.utils\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":4,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"dada55a8_60354145","line":2,"in_reply_to":"dada55a8_31dd6243","updated":"2016-07-18 11:08:00.000000000","message":"Done","commit_id":"f94b9fb8bed94bdc1d0273320e0e5e6dd038d667"}]}