)]}'
{"osprofiler/profiler.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"43eeaae031c97906344f44bd791953527931738a","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                 connection_str\u003dNone, project\u003dNone, service\u003dNone):"},{"line_number":334,"context_line":"        self.hmac_key \u003d hmac_key"},{"line_number":335,"context_line":"        if not base_id:"},{"line_number":336,"context_line":"            base_id \u003d str(uuidutils.generate_uuid(True))"},{"line_number":337,"context_line":"        self._trace_stack \u003d collections.deque([base_id, parent_id or base_id])"},{"line_number":338,"context_line":"        self._name \u003d collections.deque()"},{"line_number":339,"context_line":"        self._host \u003d socket.gethostname()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_d6cc0e37","line":336,"updated":"2016-12-07 07:26:33.000000000","message":"-1: This requires oslo.utils 3.20.0. We should update the requirements in order to use this.","commit_id":"0fa8ea42b168a0befd987cc5a9259bcff47aa06d"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8b52c70f58df98776545c18d0db308fd6a8866c4","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                 connection_str\u003dNone, project\u003dNone, service\u003dNone):"},{"line_number":334,"context_line":"        self.hmac_key \u003d hmac_key"},{"line_number":335,"context_line":"        if not base_id:"},{"line_number":336,"context_line":"            base_id \u003d str(uuidutils.generate_uuid(True))"},{"line_number":337,"context_line":"        self._trace_stack \u003d collections.deque([base_id, parent_id or base_id])"},{"line_number":338,"context_line":"        self._name \u003d collections.deque()"},{"line_number":339,"context_line":"        self._host \u003d socket.gethostname()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_711c246a","line":336,"in_reply_to":"3a71b18c_d6cc0e37","updated":"2016-12-07 07:41:25.000000000","message":"Oh, yes. So, remove `True` would be a better solution!","commit_id":"0fa8ea42b168a0befd987cc5a9259bcff47aa06d"}],"osprofiler/tests/test_profiler.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"93f3d1418ccaea982a236e4db9c0c2c656fb88b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"},{"line_number":67,"context_line":"        self.assertEqual(prof.get_base_id(), \"1\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @mock.patch(\"osprofiler.profiler.uuidutils.generate_uuid\")"},{"line_number":70,"context_line":"    def test_profiler_get_parent_id(self, mock_uuid4):"},{"line_number":71,"context_line":"        mock_uuid4.return_value \u003d \"42\""},{"line_number":72,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d8a70209","line":69,"updated":"2016-12-06 13:46:47.000000000","message":"Why osprofiler.profiler.uuidutils and not oslo_utils.uuidutils?\n\nThis may make sense if we are using system calls such as open and global patching may have side effects, but not in this case.","commit_id":"0f9c3a9843cd197df1e49ca1ebf3024621f36697"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1e1b3039a247debb37de947988c4adbe83c3efc3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"},{"line_number":67,"context_line":"        self.assertEqual(prof.get_base_id(), \"1\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @mock.patch(\"osprofiler.profiler.uuidutils.generate_uuid\")"},{"line_number":70,"context_line":"    def test_profiler_get_parent_id(self, mock_uuid4):"},{"line_number":71,"context_line":"        mock_uuid4.return_value \u003d \"42\""},{"line_number":72,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f6810ac4","line":69,"in_reply_to":"3a71b18c_6b7fde14","updated":"2016-12-07 10:14:42.000000000","message":"Looks like there is some confusion. I was telling that\n\ninstead of mock.patch(\"osprofiler.profiler.uuidutils.generate_uuid\") we should use mock.patch(\"oslo_utils.uuidutils.generate_uuid\")","commit_id":"0f9c3a9843cd197df1e49ca1ebf3024621f36697"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"71d0b63445746851e66c6302313ceb4975897dd0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"},{"line_number":67,"context_line":"        self.assertEqual(prof.get_base_id(), \"1\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @mock.patch(\"osprofiler.profiler.uuidutils.generate_uuid\")"},{"line_number":70,"context_line":"    def test_profiler_get_parent_id(self, mock_uuid4):"},{"line_number":71,"context_line":"        mock_uuid4.return_value \u003d \"42\""},{"line_number":72,"context_line":"        prof \u003d profiler._Profiler(\"secret\", base_id\u003d\"1\", parent_id\u003d\"2\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6b7fde14","line":69,"in_reply_to":"3a71b18c_d8a70209","updated":"2016-12-07 02:01:23.000000000","message":"Thank you!\n\nHowever, in __init__ in _Profiler class, the base_id is assigned to the generated uuid if the base_id is not passed to the constructor.\nTherefore, this method tests predefined base_id case.\n\nP/S: I will add opposite test cases in follow up patch set.","commit_id":"0f9c3a9843cd197df1e49ca1ebf3024621f36697"}]}