)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d312696edcbad412114de1c9afabea011934a01b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add function/sql results to trace info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds function/sql results to trace info"},{"line_number":10,"context_line":"New arg: hide_results (Boolean True/False)"},{"line_number":11,"context_line":"- True (default): Hide function/sql results by default"},{"line_number":12,"context_line":"- False: Show results in trace info"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df3967d1_dcf7f08a","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":21},"updated":"2017-08-03 18:57:19.000000000","message":"hide_result","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"28217bff90ff0c0596a592ada08e45dab7af54ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add function/sql results to trace info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds function/sql results to trace info"},{"line_number":10,"context_line":"New arg: hide_results (Boolean True/False)"},{"line_number":11,"context_line":"- True (default): Hide function/sql results by default"},{"line_number":12,"context_line":"- False: Show results in trace info"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df3967d1_b4c9dcac","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":21},"in_reply_to":"df3967d1_dcf7f08a","updated":"2017-08-04 01:14:56.000000000","message":"Done","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d312696edcbad412114de1c9afabea011934a01b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- True (default): Hide function/sql results by default"},{"line_number":12,"context_line":"- False: Show results in trace info"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With database: add_tracing(sqlalchemy, engine, name, hide_results\u003dTrue)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Demo: https://tovin07.github.io/murano/environment-show-with-results.html"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df3967d1_fc3f5422","line":14,"range":{"start_line":14,"start_character":53,"end_line":14,"end_character":65},"updated":"2017-08-03 18:57:19.000000000","message":"hide_result","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"28217bff90ff0c0596a592ada08e45dab7af54ee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- True (default): Hide function/sql results by default"},{"line_number":12,"context_line":"- False: Show results in trace info"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With database: add_tracing(sqlalchemy, engine, name, hide_results\u003dTrue)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Demo: https://tovin07.github.io/murano/environment-show-with-results.html"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df3967d1_74c7f497","line":14,"range":{"start_line":14,"start_character":53,"end_line":14,"end_character":65},"in_reply_to":"df3967d1_fc3f5422","updated":"2017-08-04 01:14:56.000000000","message":"Done","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"}],"osprofiler/profiler.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"60366829143eb79237a90f5fa689d1a1ac83d24d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                info[\"function\"][\"args\"] \u003d str(args)"},{"line_number":150,"context_line":"                info[\"function\"][\"kwargs\"] \u003d str(kwargs)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            with Trace(name, info\u003dinfo):"},{"line_number":153,"context_line":"                return f(*args, **kwargs)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_b02264ff","side":"PARENT","line":152,"updated":"2017-03-27 11:39:55.000000000","message":"-1: We can pass hide_results to Trace and modify its __exit__ method to add function result to info.","commit_id":"1173576ea8d96f69789334ffb9a0f74cdecbdbcf"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a3ff5be2e47606cab582b33d4b8b2acce0699956","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                info[\"function\"][\"args\"] \u003d str(args)"},{"line_number":150,"context_line":"                info[\"function\"][\"kwargs\"] \u003d str(kwargs)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            with Trace(name, info\u003dinfo):"},{"line_number":153,"context_line":"                return f(*args, **kwargs)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_6b3fa087","side":"PARENT","line":152,"in_reply_to":"ffe62b97_4207c383","updated":"2017-05-02 18:18:49.000000000","message":"Ok, I got confused with the argument \u0027value\u0027 in __exit__","commit_id":"1173576ea8d96f69789334ffb9a0f74cdecbdbcf"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8c0c2300fc252c0623e77ed5c759bfb8c885aa09","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                info[\"function\"][\"args\"] \u003d str(args)"},{"line_number":150,"context_line":"                info[\"function\"][\"kwargs\"] \u003d str(kwargs)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            with Trace(name, info\u003dinfo):"},{"line_number":153,"context_line":"                return f(*args, **kwargs)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4207c383","side":"PARENT","line":152,"in_reply_to":"ffe62b97_b02264ff","updated":"2017-03-27 14:38:20.000000000","message":"Nope! I don\u0027t think that we can pass result to this context manager as you think.\nBecause:\n1. Run traced function/method first --\u003e Pass result to context manager. Or, we have to run it in __enter__. Or, we have to modify Trace class to yield style. Therefore, I choose to use try/catch/else to not mess things up.\n2. __exit__ method takes exception information only. There is no result can be passed to it.","commit_id":"1173576ea8d96f69789334ffb9a0f74cdecbdbcf"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"88d35ba0c250a08cbaf958314a09c6f0e2cad6f9","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        @functools.wraps(f)"},{"line_number":146,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":147,"context_line":"            # NOTE(tovin07): Workaround for this issues"},{"line_number":148,"context_line":"            # F823 local variable \u0027info\u0027"},{"line_number":149,"context_line":"            # (defined in enclosing scope on line xxx)"},{"line_number":150,"context_line":"            # referenced before assignment"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e2d497bf","line":147,"range":{"start_line":147,"start_character":54,"end_line":147,"end_character":55},"updated":"2017-03-27 14:41:46.000000000","message":"Remember to remove this","commit_id":"2f3cbc7df248fd322f8dd76532b5595c7c706eb0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"60366829143eb79237a90f5fa689d1a1ac83d24d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if not hide_results:"},{"line_number":171,"context_line":"                    stop_info \u003d {"},{"line_number":172,"context_line":"                        \"function\": {"},{"line_number":173,"context_line":"                            \"results\": str(results)"},{"line_number":174,"context_line":"                        }"},{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":"                    stop(info\u003dstop_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_3c2f55f7","line":173,"updated":"2017-03-27 11:39:55.000000000","message":"-1: This may result in unicode encode error for string return types.","commit_id":"2f3cbc7df248fd322f8dd76532b5595c7c706eb0"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8c0c2300fc252c0623e77ed5c759bfb8c885aa09","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if not hide_results:"},{"line_number":171,"context_line":"                    stop_info \u003d {"},{"line_number":172,"context_line":"                        \"function\": {"},{"line_number":173,"context_line":"                            \"results\": str(results)"},{"line_number":174,"context_line":"                        }"},{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":"                    stop(info\u003dstop_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_87939dfa","line":173,"in_reply_to":"ffe62b97_3c2f55f7","updated":"2017-03-27 14:38:20.000000000","message":"Yep! I totally agree with this. I will change to repr :D","commit_id":"2f3cbc7df248fd322f8dd76532b5595c7c706eb0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8cae1091525aae001f938fa1600e11f3fc007d77","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        profiler.stop(info\u003dinfo)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def trace(name, info\u003dNone, hide_args\u003dFalse, hide_results\u003dTrue,"},{"line_number":98,"context_line":"          allow_multiple_trace\u003dTrue):"},{"line_number":99,"context_line":"    \"\"\"Trace decorator for functions."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_59000068","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":56},"updated":"2017-08-01 20:19:05.000000000","message":"nit: hide_result","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        profiler.stop(info\u003dinfo)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def trace(name, info\u003dNone, hide_args\u003dFalse, hide_results\u003dTrue,"},{"line_number":98,"context_line":"          allow_multiple_trace\u003dTrue):"},{"line_number":99,"context_line":"    \"\"\"Trace decorator for functions."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_ee70ffde","line":97,"range":{"start_line":97,"start_character":44,"end_line":97,"end_character":56},"in_reply_to":"df3967d1_59000068","updated":"2017-08-02 08:47:23.000000000","message":"got it","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"0f758b1c96abcb0e5b4828373dcfa5e137b2c680","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        @functools.wraps(f)"},{"line_number":146,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":147,"context_line":"            # NOTE(tovin07): Workaround for this issue"},{"line_number":148,"context_line":"            # F823 local variable \u0027info\u0027"},{"line_number":149,"context_line":"            # (defined in enclosing scope on line xxx)"},{"line_number":150,"context_line":"            # referenced before assignment"},{"line_number":151,"context_line":"            info_ \u003d info"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_4f692789","line":148,"updated":"2017-06-23 13:52:25.000000000","message":"just curious - is it pep8 complains about this? in this function \u0027info\u0027 should not be treated as local variable, it comes from the outer scope","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2e25c02f7208e5de9ae8e17428a7364e5bdf11fe","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        @functools.wraps(f)"},{"line_number":146,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":147,"context_line":"            # NOTE(tovin07): Workaround for this issue"},{"line_number":148,"context_line":"            # F823 local variable \u0027info\u0027"},{"line_number":149,"context_line":"            # (defined in enclosing scope on line xxx)"},{"line_number":150,"context_line":"            # referenced before assignment"},{"line_number":151,"context_line":"            info_ \u003d info"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_e225865d","line":148,"in_reply_to":"5f201791_4f692789","updated":"2017-07-07 02:33:12.000000000","message":"Yes, this message came from pep8 output.","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8cae1091525aae001f938fa1600e11f3fc007d77","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_d9abd01a","line":163,"range":{"start_line":163,"start_character":16,"end_line":163,"end_character":23},"updated":"2017-08-01 20:19:05.000000000","message":"nit: result","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_4e638b43","line":163,"range":{"start_line":163,"start_character":16,"end_line":163,"end_character":23},"in_reply_to":"df3967d1_d9abd01a","updated":"2017-08-02 08:47:23.000000000","message":"got it","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8cae1091525aae001f938fa1600e11f3fc007d77","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_34d423bd","line":164,"updated":"2017-08-01 20:19:05.000000000","message":"-1: Where do we re-raise this exception?    :-(","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e8afea9284b6f1284bdec2e2f9dadd6d3ed36825","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_4f5a6ef3","line":164,"in_reply_to":"df3967d1_34d423bd","updated":"2017-08-01 20:36:17.000000000","message":"Added a unit test to cover this path:\nhttps://review.openstack.org/#/c/489739\n\nPlease rebase if you think it is useful.","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_8eacd334","line":164,"in_reply_to":"df3967d1_34d423bd","updated":"2017-08-02 08:47:23.000000000","message":"just here, then, we append exception info to info in strop trace.","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_6e4befaf","line":164,"in_reply_to":"df3967d1_4f5a6ef3","updated":"2017-08-02 08:47:23.000000000","message":"Thanks!","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8cae1091525aae001f938fa1600e11f3fc007d77","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"},{"line_number":168,"context_line":"                stop(info\u003dstop_info)"},{"line_number":169,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_942bcfe9","line":166,"updated":"2017-08-01 20:19:05.000000000","message":"-1: reflection.get_class_name","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                results \u003d f(*args, **kwargs)"},{"line_number":164,"context_line":"            except Exception as ex:"},{"line_number":165,"context_line":"                stop_info \u003d {"},{"line_number":166,"context_line":"                    \"etype\": reflection.get_all_class_names(ex)"},{"line_number":167,"context_line":"                }"},{"line_number":168,"context_line":"                stop(info\u003dstop_info)"},{"line_number":169,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_8e50535f","line":166,"in_reply_to":"df3967d1_942bcfe9","updated":"2017-08-02 08:47:23.000000000","message":"good catch","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8cae1091525aae001f938fa1600e11f3fc007d77","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":"                    stop(info\u003dstop_info)"},{"line_number":177,"context_line":"                else:"},{"line_number":178,"context_line":"                    stop()"},{"line_number":179,"context_line":"                return results"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_74c18be4","line":178,"updated":"2017-08-01 20:19:05.000000000","message":"Can we move all the stop() calls to finally? We can initialize stop_info to None and then set its value appropriately in various blocks.","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"2d43f95a3eefe0b6fc326f7cf9416dcff1038608","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                    }"},{"line_number":176,"context_line":"                    stop(info\u003dstop_info)"},{"line_number":177,"context_line":"                else:"},{"line_number":178,"context_line":"                    stop()"},{"line_number":179,"context_line":"                return results"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return wrapper"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_6ea76f51","line":178,"in_reply_to":"df3967d1_74c18be4","updated":"2017-08-02 08:47:23.000000000","message":"yes, I think so","commit_id":"9f70a6bc7b8dbbac2ccec2a147e061d976b1222e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3116e40c44829154ff8bba5610b7037b32bcf2a9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":157,"context_line":"                result \u003d f(*args, **kwargs)"},{"line_number":158,"context_line":"            except Exception as ex:"},{"line_number":159,"context_line":"                stop_info \u003d {\"etype\": reflection.get_class_name(ex)}"},{"line_number":160,"context_line":"            else:"},{"line_number":161,"context_line":"                if not hide_result:"},{"line_number":162,"context_line":"                    stop_info \u003d {\"function\": {\"result\": repr(result)}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_84cdb867","line":159,"updated":"2017-08-02 18:41:51.000000000","message":"-1: We should re-raise the exception after setting stop_info.\n\nPlease rebase your patch on https://review.openstack.org/#/c/489739/ and check if that test pass.","commit_id":"258e69775bfbd046a4a8718516d6b38e6608afa3"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"69f315811bdcd46403c21328cb6bb55edfdbba64","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                start(name, info\u003dinfo_)"},{"line_number":157,"context_line":"                result \u003d f(*args, **kwargs)"},{"line_number":158,"context_line":"            except Exception as ex:"},{"line_number":159,"context_line":"                stop_info \u003d {\"etype\": reflection.get_class_name(ex)}"},{"line_number":160,"context_line":"            else:"},{"line_number":161,"context_line":"                if not hide_result:"},{"line_number":162,"context_line":"                    stop_info \u003d {\"function\": {\"result\": repr(result)}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_78170747","line":159,"in_reply_to":"df3967d1_84cdb867","updated":"2017-08-03 06:54:06.000000000","message":"got it :D","commit_id":"258e69775bfbd046a4a8718516d6b38e6608afa3"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"36cba838e5cbf59606441e1ec850a8e213401ae8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                result \u003d f(*args, **kwargs)"},{"line_number":158,"context_line":"            except Exception as ex:"},{"line_number":159,"context_line":"                stop_info \u003d {\"etype\": reflection.get_class_name(ex)}"},{"line_number":160,"context_line":"                raise ex"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                if not hide_result:"},{"line_number":163,"context_line":"                    stop_info \u003d {\"function\": {\"result\": repr(result)}}"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf3e73b7_ecb736d8","line":160,"updated":"2017-08-07 08:48:27.000000000","message":"Please replace \"raise ex\" -\u003e \"raise\" to keep the traceback of  original exception.","commit_id":"60c3a981ab1458458ade8976a8f65680513d5570"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e9e433f58ebe8e7daa3f7859bc603b97f8b96e39","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                result \u003d f(*args, **kwargs)"},{"line_number":158,"context_line":"            except Exception as ex:"},{"line_number":159,"context_line":"                stop_info \u003d {\"etype\": reflection.get_class_name(ex)}"},{"line_number":160,"context_line":"                raise ex"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                if not hide_result:"},{"line_number":163,"context_line":"                    stop_info \u003d {\"function\": {\"result\": repr(result)}}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_698a806a","line":160,"in_reply_to":"bf3e73b7_ecb736d8","updated":"2017-08-14 19:56:20.000000000","message":"Good catch!","commit_id":"60c3a981ab1458458ade8976a8f65680513d5570"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"7a695a264b9cdf8c521c12b73bf60370cf2a4a8f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                result \u003d f(*args, **kwargs)"},{"line_number":158,"context_line":"            except Exception as ex:"},{"line_number":159,"context_line":"                stop_info \u003d {\"etype\": reflection.get_class_name(ex)}"},{"line_number":160,"context_line":"                raise ex"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                if not hide_result:"},{"line_number":163,"context_line":"                    stop_info \u003d {\"function\": {\"result\": repr(result)}}"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf3e73b7_df9412eb","line":160,"in_reply_to":"bf3e73b7_ecb736d8","updated":"2017-08-07 08:55:16.000000000","message":"Got it!","commit_id":"60c3a981ab1458458ade8976a8f65680513d5570"}],"osprofiler/tests/unit/test_profiler.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"88d35ba0c250a08cbaf958314a09c6f0e2cad6f9","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        return k + l"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"class FakeTraceWithMetaclassHideResults(FakeTraceWithMetaclassBase):"},{"line_number":510,"context_line":"    __trace_args__ \u003d {\"name\": \"a\","},{"line_number":511,"context_line":"                      \"info\": {\"b\": 20},"},{"line_number":512,"context_line":"                      \"hide_results\": False}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4296a3f2","line":509,"range":{"start_line":509,"start_character":6,"end_line":509,"end_character":39},"updated":"2017-03-27 14:41:46.000000000","message":"I should add more test for this class!","commit_id":"2f3cbc7df248fd322f8dd76532b5595c7c706eb0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d312696edcbad412114de1c9afabea011934a01b","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @mock.patch(\"osprofiler.profiler.stop\")"},{"line_number":272,"context_line":"    @mock.patch(\"osprofiler.profiler.start\")"},{"line_number":273,"context_line":"    def test_without_result(self, mock_start, mock_stop):"},{"line_number":274,"context_line":"        self.assertEqual(1, traced_func(1))"},{"line_number":275,"context_line":"        expected_info \u003d {"},{"line_number":276,"context_line":"            \"info\": \"some_info\","}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_ff9866c0","line":273,"updated":"2017-08-03 18:57:19.000000000","message":"Identical to test_with_args, please remove this test.","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"28217bff90ff0c0596a592ada08e45dab7af54ee","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @mock.patch(\"osprofiler.profiler.stop\")"},{"line_number":272,"context_line":"    @mock.patch(\"osprofiler.profiler.start\")"},{"line_number":273,"context_line":"    def test_without_result(self, mock_start, mock_stop):"},{"line_number":274,"context_line":"        self.assertEqual(1, traced_func(1))"},{"line_number":275,"context_line":"        expected_info \u003d {"},{"line_number":276,"context_line":"            \"info\": \"some_info\","}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_14bae808","line":273,"in_reply_to":"df3967d1_ff9866c0","updated":"2017-08-04 01:14:56.000000000","message":"Done","commit_id":"adb8bf0479c3616f4f4855bc9595e25fc712134a"}]}