)]}'
{"osprofiler/cmd/commands.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"dd234bf802409443665d5fbdf7dc40066cc6743f","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        traces \u003d engine.list_traces({}, (\"name\", \"base_id\"))"},{"line_number":170,"context_line":"        for trace in traces:"},{"line_number":171,"context_line":"            print(\"%s\\t%s\" % (trace[\"name\"], trace[\"base_id\"]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_b65b5952","line":171,"updated":"2017-11-23 09:38:43.000000000","message":"maybe, we should add time stamp to this output","commit_id":"a4ae533e59bb10998cc5421e2e6f8e68eec380e9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c29cfec326c7ca7c2dfa25f5f498defba3c3040d","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        traces \u003d engine.list_traces({}, (\"name\", \"base_id\"))"},{"line_number":170,"context_line":"        for trace in traces:"},{"line_number":171,"context_line":"            print(\"%s\\t%s\" % (trace[\"name\"], trace[\"base_id\"]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_0f08bf8f","line":171,"in_reply_to":"ff82abbf_b65b5952","updated":"2017-11-25 14:07:50.000000000","message":"Done","commit_id":"a4ae533e59bb10998cc5421e2e6f8e68eec380e9"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"026289374ada3523f45d6a4186a63ee69f31afe4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        fields \u003d (\"name\", \"base_id\", \"timestamp\", \"project\")"},{"line_number":173,"context_line":"        pretty_table \u003d prettytable.PrettyTable(fields)"},{"line_number":174,"context_line":"        pretty_table.align \u003d \"l\""},{"line_number":175,"context_line":"        traces \u003d engine.list_traces({}, fields)"},{"line_number":176,"context_line":"        for trace in traces:"},{"line_number":177,"context_line":"            row \u003d [trace[field] for field in fields]"},{"line_number":178,"context_line":"            pretty_table.add_row(row)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_712d1494","line":175,"range":{"start_line":175,"start_character":36,"end_line":175,"end_character":38},"updated":"2017-12-22 09:35:47.000000000","message":"and this one should be a query string (redis), json (mongo)","commit_id":"d70dc3b66a2d59576116426014643e562276e10b"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"53a73853415ff90818997ec63853a3edef2f90ed","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        fields \u003d (\"name\", \"base_id\", \"timestamp\", \"project\")"},{"line_number":173,"context_line":"        pretty_table \u003d prettytable.PrettyTable(fields)"},{"line_number":174,"context_line":"        pretty_table.align \u003d \"l\""},{"line_number":175,"context_line":"        traces \u003d engine.list_traces({}, fields)"},{"line_number":176,"context_line":"        for trace in traces:"},{"line_number":177,"context_line":"            row \u003d [trace[field] for field in fields]"},{"line_number":178,"context_line":"            pretty_table.add_row(row)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_82c96879","line":175,"range":{"start_line":175,"start_character":36,"end_line":175,"end_character":38},"in_reply_to":"bf8cb3f7_712d1494","updated":"2017-12-22 14:18:20.000000000","message":"I\u0027d suggest to fix this in a separate patch; function `list_traces` is not consistent across drivers","commit_id":"d70dc3b66a2d59576116426014643e562276e10b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ec6d2af5d915314a543b97b6adc0852817bc921a","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @cliutils.arg(\"--connection-string\", dest\u003d\"conn_str\","},{"line_number":161,"context_line":"                  default\u003d(cliutils.env(\"OSPROFILER_CONNECTION_STRING\") or"},{"line_number":162,"context_line":"                           \"ceilometer://\"),"},{"line_number":163,"context_line":"                  help\u003d\"Storage driver\u0027s connection string. Defaults to \""},{"line_number":164,"context_line":"                       \"env[OSPROFILER_CONNECTION_STRING] if set, else \""},{"line_number":165,"context_line":"                       \"ceilometer://\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_442de5fb","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":38},"updated":"2018-01-19 06:56:37.000000000","message":"change this to messaging?","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"2cdf781407e3f531d65e80ee5dcd237279938485","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @cliutils.arg(\"--connection-string\", dest\u003d\"conn_str\","},{"line_number":161,"context_line":"                  default\u003d(cliutils.env(\"OSPROFILER_CONNECTION_STRING\") or"},{"line_number":162,"context_line":"                           \"ceilometer://\"),"},{"line_number":163,"context_line":"                  help\u003d\"Storage driver\u0027s connection string. Defaults to \""},{"line_number":164,"context_line":"                       \"env[OSPROFILER_CONNECTION_STRING] if set, else \""},{"line_number":165,"context_line":"                       \"ceilometer://\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_e4f66ed9","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":38},"in_reply_to":"7f96bb07_442de5fb","updated":"2018-01-19 09:13:39.000000000","message":"`messaging` driver does not have `list_traces` (because it reads them from queue, so after reading the queue becomes empty). \n\nI would vote to make parameter `--connection-string` mandatory without default value in both `trace list` and `trace show` commands. But maybe it deserves a separate patch.","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"d9f7cfe40915d894ad1a03ae5b7bcee08f410448","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @cliutils.arg(\"--connection-string\", dest\u003d\"conn_str\","},{"line_number":161,"context_line":"                  default\u003d(cliutils.env(\"OSPROFILER_CONNECTION_STRING\") or"},{"line_number":162,"context_line":"                           \"ceilometer://\"),"},{"line_number":163,"context_line":"                  help\u003d\"Storage driver\u0027s connection string. Defaults to \""},{"line_number":164,"context_line":"                       \"env[OSPROFILER_CONNECTION_STRING] if set, else \""},{"line_number":165,"context_line":"                       \"ceilometer://\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_4aecbd8e","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":38},"in_reply_to":"7f96bb07_e4f66ed9","updated":"2018-01-23 06:12:49.000000000","message":"agree","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ec6d2af5d915314a543b97b6adc0852817bc921a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                           \"ceilometer://\"),"},{"line_number":163,"context_line":"                  help\u003d\"Storage driver\u0027s connection string. Defaults to \""},{"line_number":164,"context_line":"                       \"env[OSPROFILER_CONNECTION_STRING] if set, else \""},{"line_number":165,"context_line":"                       \"ceilometer://\")"},{"line_number":166,"context_line":"    def list(self, args):"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            engine \u003d base.get_driver(args.conn_str, **args.__dict__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_64302157","line":165,"range":{"start_line":165,"start_character":24,"end_line":165,"end_character":34},"updated":"2018-01-19 06:56:37.000000000","message":"this one too","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"2462a9eb0bc1d3c2845c6898591662135a2a97db","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        fields \u003d (\"base_id\", \"timestamp\")"},{"line_number":173,"context_line":"        pretty_table \u003d prettytable.PrettyTable(fields)"},{"line_number":174,"context_line":"        pretty_table.align \u003d \"l\""},{"line_number":175,"context_line":"        traces \u003d engine.list_traces({}, fields)"},{"line_number":176,"context_line":"        for trace in traces:"},{"line_number":177,"context_line":"            row \u003d [trace[field] for field in fields]"},{"line_number":178,"context_line":"            pretty_table.add_row(row)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_bc3cc4bf","line":175,"updated":"2018-01-22 17:07:55.000000000","message":"I suspect a type mismatch between the different implementations of list_traces and the query parameter\n\n- Redis query seems to be a string \n\n  def list_traces(self, query\u003d\"*\", fields\u003d[]):\n\n- in Mongodb query must be a dict.\n\nI faced a\n\n  File \"/usr/local/lib/python2.7/dist-packages/osprofiler/drivers/redis_driver.py\", line 82, in list_traces\n    ids \u003d self.db.scan_iter(match\u003dself.namespace + query)\n  TypeError: cannot concatenate \u0027str\u0027 and \u0027dict\u0027 objects\n\nwhen using the redis driver","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e12444639d92129a2907532b063050b258e85bbf","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        fields \u003d (\"base_id\", \"timestamp\")"},{"line_number":173,"context_line":"        pretty_table \u003d prettytable.PrettyTable(fields)"},{"line_number":174,"context_line":"        pretty_table.align \u003d \"l\""},{"line_number":175,"context_line":"        traces \u003d engine.list_traces({}, fields)"},{"line_number":176,"context_line":"        for trace in traces:"},{"line_number":177,"context_line":"            row \u003d [trace[field] for field in fields]"},{"line_number":178,"context_line":"            pretty_table.add_row(row)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_e534e8e0","line":175,"in_reply_to":"7f96bb07_bc3cc4bf","updated":"2018-01-22 20:13:45.000000000","message":"I think this is covered by the next patch ( https://review.openstack.org/#/c/532867/ ) where the parameter is removed ( https://review.openstack.org/#/c/532867/3/osprofiler/drivers/base.py@106 )","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"c8a283b4d0cdf942d65ee643138a18fbfeeddfab","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        fields \u003d (\"base_id\", \"timestamp\")"},{"line_number":173,"context_line":"        pretty_table \u003d prettytable.PrettyTable(fields)"},{"line_number":174,"context_line":"        pretty_table.align \u003d \"l\""},{"line_number":175,"context_line":"        traces \u003d engine.list_traces({}, fields)"},{"line_number":176,"context_line":"        for trace in traces:"},{"line_number":177,"context_line":"            row \u003d [trace[field] for field in fields]"},{"line_number":178,"context_line":"            pretty_table.add_row(row)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_c5ebec0f","line":175,"in_reply_to":"7f96bb07_e534e8e0","updated":"2018-01-22 20:16:40.000000000","message":"Oh thanks :) \nI totally missed this patch","commit_id":"fe572b179f5b6bd83bfcb955fa9273ae0e4e758c"}],"requirements.txt":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"9298824390a498257452656c4ce7ec340ac4bee5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":5,"context_line":"netaddr\u003e\u003d0.7.13,!\u003d0.7.16  # BSD"},{"line_number":6,"context_line":"oslo.concurrency\u003e\u003d3.8.0 # Apache-2.0"},{"line_number":7,"context_line":"PrettyTable\u003e\u003d0.7.1,\u003c0.8 # BSD"}],"source_content_type":"text/plain","patch_set":5,"id":"df87a7cf_399d7509","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2017-12-12 09:44:35.000000000","message":"is it possible without using PrettyTable?","commit_id":"d70dc3b66a2d59576116426014643e562276e10b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e30be49e2306381be3a202136cb18cc05403f88a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":5,"context_line":"netaddr\u003e\u003d0.7.13,!\u003d0.7.16  # BSD"},{"line_number":6,"context_line":"oslo.concurrency\u003e\u003d3.8.0 # Apache-2.0"},{"line_number":7,"context_line":"PrettyTable\u003e\u003d0.7.1,\u003c0.8 # BSD"}],"source_content_type":"text/plain","patch_set":5,"id":"df87a7cf_c7fb40bb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"df87a7cf_399d7509","updated":"2017-12-12 11:34:53.000000000","message":"Yes. It means manually printing the information, and it will be less readable.","commit_id":"d70dc3b66a2d59576116426014643e562276e10b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"0d03f07773a642a8492f1691b8c92802a713a41e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":5,"context_line":"netaddr\u003e\u003d0.7.13,!\u003d0.7.16  # BSD"},{"line_number":6,"context_line":"oslo.concurrency\u003e\u003d3.8.0 # Apache-2.0"},{"line_number":7,"context_line":"PrettyTable\u003e\u003d0.7.1,\u003c0.8 # BSD"}],"source_content_type":"text/plain","patch_set":5,"id":"df87a7cf_7ba4fa08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"df87a7cf_c7fb40bb","updated":"2017-12-15 06:45:00.000000000","message":"Okay, I understand that.\nOSProfiler is a small library, therefore, keep it small is better :D\nAnw, I\u0027m OK with this :D","commit_id":"d70dc3b66a2d59576116426014643e562276e10b"}]}