)]}'
{"osprofiler/drivers/redis_driver.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"0ed659710bfa1849c2ded82f6b43cbbcb779fdee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                \"\u0027pip install redis\u0027.\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # only connection over network is supported with schema"},{"line_number":42,"context_line":"        # redis://[:password]@host[:port][/db]"},{"line_number":43,"context_line":"        self.db \u003d StrictRedis.from_url(self.connection_str)"},{"line_number":44,"context_line":"        self.namespace \u003d \"osprofiler:\""},{"line_number":45,"context_line":"        self.namespace_error \u003d \"osprofiler_error:\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_efa526a0","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":46},"updated":"2018-05-30 09:40:37.000000000","message":"I think you should update documentation and other places in code/help text too.","commit_id":"b77f684d96818802396b49c3f6b11eaa47a73ff7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9b0a98cafb7cc3bd22f2f12e33eb87f2e9896089","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Redis(base.Driver):"},{"line_number":26,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"},{"line_number":27,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_51eb33db","side":"PARENT","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":45},"updated":"2018-06-05 16:06:47.000000000","message":"This is a backwards-incompatible change to a public api.  The parameter should have been deprecated before its removal to give callers a chance to adjust their calls to the new argument list.  As-is, this opens up the possibility that someone was passing db as a positional argument, which will now be passed as project instead.  That\u0027s probably going to result in some confusing errors.","commit_id":"e1ba98e13a598f2df7d3f18376680e372adc309d"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"d9bef37274102f3c1803f56dd066f23848eb90ae","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Redis(base.Driver):"},{"line_number":26,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"},{"line_number":27,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3cb683de","side":"PARENT","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":45},"in_reply_to":"5f7c97a3_51eb33db","updated":"2018-06-06 00:30:29.000000000","message":"Thank Ben for this.\nYour concern is reasonable.\nThere is a small change that will break this API.\n\nActually, this __init__ function will be called only at [1].\nAnd, `db\u003d0` is never documented anywhere/or recommended (in this project) before this patch set.\n\n[1] https://git.openstack.org/cgit/openstack/osprofiler/tree/osprofiler/drivers/base.py#n41","commit_id":"e1ba98e13a598f2df7d3f18376680e372adc309d"}]}