)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"107e699e9a0adb3bc15fdd1b19fbc1fa4be08e0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2018-06-11 17:26:24 +0700"},{"line_number":4,"context_line":"Commit:     Nguyen Van Duc \u003cducnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-11 17:26:24 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Put \u0027db\u0027 parameter back and provide a deprecation warning before remove"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The parameter should have been deprecated before its removal to give"},{"line_number":10,"context_line":"callers a chance to adjust their calls to the new argument list."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I606796a33f6304276fe78b9868239a0ee5b9f46a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_8f3b6d9a","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":64},"updated":"2018-06-11 11:25:14.000000000","message":"Please add reference to this commit https://review.openstack.org/#/c/569078/","commit_id":"3814e9c912a0d63f9d84220fc17d911f23b00e71"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c9baae98e50224901be76f09e31312b6218b8b63","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The parameter should have been deprecated before its removal to give"},{"line_number":10,"context_line":"callers a chance to adjust their calls to the new argument list."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patchset follow BenNeme\u0027s comment in commit"},{"line_number":13,"context_line":"https://review.openstack.org/#/c/569078/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I606796a33f6304276fe78b9868239a0ee5b9f46a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_39a1f5f7","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":28},"updated":"2018-06-14 08:31:44.000000000","message":"Ben Nemec","commit_id":"d95d6a4d4316749c4cde4af3fbb8edeb1d6a95e8"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c9baae98e50224901be76f09e31312b6218b8b63","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The parameter should have been deprecated before its removal to give"},{"line_number":10,"context_line":"callers a chance to adjust their calls to the new argument list."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patchset follow BenNeme\u0027s comment in commit"},{"line_number":13,"context_line":"https://review.openstack.org/#/c/569078/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I606796a33f6304276fe78b9868239a0ee5b9f46a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f9ae1de5","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":20},"updated":"2018-06-14 08:31:44.000000000","message":"follows","commit_id":"d95d6a4d4316749c4cde4af3fbb8edeb1d6a95e8"}],"osprofiler/drivers/redis_driver.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"107e699e9a0adb3bc15fdd1b19fbc1fa4be08e0c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from osprofiler.drivers import base"},{"line_number":22,"context_line":"from osprofiler import exc"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_efc46194","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":14},"updated":"2018-06-11 11:25:14.000000000","message":"this import should be on top of import list (it should be put at line #17)","commit_id":"3814e9c912a0d63f9d84220fc17d911f23b00e71"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"107e699e9a0adb3bc15fdd1b19fbc1fa4be08e0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Redis(base.Driver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_efdb017a","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":6},"updated":"2018-06-11 11:25:14.000000000","message":"it should be `LOG` for consistent\n\nhttp://git.openstack.org/cgit/openstack/osprofiler/tree/osprofiler/drivers/base.py#n23","commit_id":"3814e9c912a0d63f9d84220fc17d911f23b00e71"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"107e699e9a0adb3bc15fdd1b19fbc1fa4be08e0c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"},{"line_number":31,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":33,"context_line":"        logger.warning(\"\u0027db\u0027 parameter is deprecated and will be removed in future.\")"},{"line_number":34,"context_line":"        super(Redis, self).__init__(connection_str, project\u003dproject,"},{"line_number":35,"context_line":"                                    service\u003dservice, host\u003dhost,"},{"line_number":36,"context_line":"                                    conf\u003dconf, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_afb3c94d","line":33,"range":{"start_line":33,"start_character":79,"end_line":33,"end_character":85},"updated":"2018-06-11 11:25:14.000000000","message":"pep8","commit_id":"3814e9c912a0d63f9d84220fc17d911f23b00e71"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"107e699e9a0adb3bc15fdd1b19fbc1fa4be08e0c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"},{"line_number":154,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":155,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":156,"context_line":"        logger.warning(\"\u0027db\u0027 parameter is deprecated and will be removed in future.\")"},{"line_number":157,"context_line":"        super(RedisSentinel, self).__init__(connection_str, project\u003dproject,"},{"line_number":158,"context_line":"                                            service\u003dservice, host\u003dhost,"},{"line_number":159,"context_line":"                                            conf\u003dconf, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cfb08543","line":156,"range":{"start_line":156,"start_character":79,"end_line":156,"end_character":85},"updated":"2018-06-11 11:25:14.000000000","message":"pep8","commit_id":"3814e9c912a0d63f9d84220fc17d911f23b00e71"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c9baae98e50224901be76f09e31312b6218b8b63","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        LOG.warning(\"\u0027db\u0027 parameter is deprecated and will be removed \""},{"line_number":35,"context_line":"                    \"in future.\")"},{"line_number":36,"context_line":"        super(Redis, self).__init__(connection_str, project\u003dproject,"},{"line_number":37,"context_line":"                                    service\u003dservice, host\u003dhost,"},{"line_number":38,"context_line":"                                    conf\u003dconf, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_993a8995","line":35,"range":{"start_line":34,"start_character":20,"end_line":35,"end_character":32},"updated":"2018-06-14 08:31:44.000000000","message":"You should add: \"Please specify \u0027db\u0027 in connection string instead.\"","commit_id":"d95d6a4d4316749c4cde4af3fbb8edeb1d6a95e8"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c9baae98e50224901be76f09e31312b6218b8b63","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":157,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.warning(\"\u0027db\u0027 parameter is deprecated and will be removed \""},{"line_number":160,"context_line":"                    \"in future.\")"},{"line_number":161,"context_line":"        super(RedisSentinel, self).__init__(connection_str, project\u003dproject,"},{"line_number":162,"context_line":"                                            service\u003dservice, host\u003dhost,"},{"line_number":163,"context_line":"                                            conf\u003dconf, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b950a5d6","line":160,"range":{"start_line":159,"start_character":20,"end_line":160,"end_character":32},"updated":"2018-06-14 08:31:44.000000000","message":"this is the same with above","commit_id":"d95d6a4d4316749c4cde4af3fbb8edeb1d6a95e8"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"80a189791744474af747477dfd7081f19cc0d69c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 service\u003dNone, host\u003dNone, conf\u003dcfg.CONF, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Redis driver for OSProfiler.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        LOG.warning(\"\u0027db\u0027 parameter is deprecated and will be removed \""},{"line_number":35,"context_line":"                    \"in future. Please specify \u0027db\u0027 in \u0027connection_string\u0027 \""},{"line_number":36,"context_line":"                    \"instead.\")"},{"line_number":37,"context_line":"        super(Redis, self).__init__(connection_str, project\u003dproject,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_727c5fea","line":34,"updated":"2018-06-14 14:56:11.000000000","message":"Can we use debtcollector for this instead?  As it is written, it will always dump out a warning when one of these classes is instantiated, regardless of whether the problematic arg was passed.  I believe debtcollector can emit warnings only when the arg is actually being used.\n\nSee https://docs.openstack.org/debtcollector/queens/reference/index.html#debtcollector.removals.removed_kwarg","commit_id":"7328c839957e53d01e7bc236cc016a1d175624da"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d4bee3f40e456b0981e1fcc4f85bef41910ef61a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Redis(base.Driver):"},{"line_number":28,"context_line":"    @removals.removed_kwarg(\"db\", message\u003d\"\u0027db\u0027 parameter is deprecated \""},{"line_number":29,"context_line":"                                          \"and will be removed in future. \""},{"line_number":30,"context_line":"                                          \"Please specify \u0027db\u0027 in \""},{"line_number":31,"context_line":"                                          \"\u0027connection_string\u0027 instead.\")"},{"line_number":32,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_35f21171","line":29,"range":{"start_line":28,"start_character":43,"end_line":29,"end_character":73},"updated":"2018-06-18 16:57:47.000000000","message":"I think you can remove this sentence from the message.  debtcollector always includes the fact that the parameter is deprecated, the custom message just needs to be what to do instead.\n\nSee the example in https://docs.openstack.org/debtcollector/queens/user/usage.html#removing-a-keyword-argument","commit_id":"4d769b47367bdcfed0e01ab26328895d454c5084"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"add566597ebb8c9c11c3d7ae41a91b117ab26eb5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Redis(base.Driver):"},{"line_number":28,"context_line":"    @removals.removed_kwarg(\"db\", message\u003d\"\u0027db\u0027 parameter is deprecated \""},{"line_number":29,"context_line":"                                          \"and will be removed in future. \""},{"line_number":30,"context_line":"                                          \"Please specify \u0027db\u0027 in \""},{"line_number":31,"context_line":"                                          \"\u0027connection_string\u0027 instead.\")"},{"line_number":32,"context_line":"    def __init__(self, connection_str, db\u003d0, project\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7f7931f9","line":29,"range":{"start_line":28,"start_character":43,"end_line":29,"end_character":73},"in_reply_to":"5f7c97a3_35f21171","updated":"2018-06-19 10:17:28.000000000","message":"I agree with this. However, we can make another follow-up patch.","commit_id":"4d769b47367bdcfed0e01ab26328895d454c5084"}]}