)]}'
{"osprofiler/drivers/redis_driver.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"f173fe1aaad509a2da23e979e927dda6c9aea7c9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.conf \u003d conf"},{"line_number":175,"context_line":"        socket_timeout \u003d self.conf.profiler.socket_timeout"},{"line_number":176,"context_line":"        parsed_url \u003d parser.urlparse(self.connection_str)"},{"line_number":177,"context_line":"        password \u003d parsed_url.password if parsed_url.password else None"},{"line_number":178,"context_line":"        sentinel \u003d Sentinel([(parsed_url.hostname, int(parsed_url.port))],"},{"line_number":179,"context_line":"                            password\u003dpassword,"},{"line_number":180,"context_line":"                            socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7a8d1130","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":71},"updated":"2018-08-16 16:01:40.000000000","message":"Actually, this is redundant.\n\nYou can see here: https://docs.python.org/3/library/urllib.parse.html#url-parsing","commit_id":"b1fe1adecd708b3925e5ab915a52b08415bb7a2c"},{"author":{"_account_id":25891,"name":"lipan","email":"lipan7195@fiberhome.com","username":"lipan"},"change_message_id":"365a094a9c82536a56a7d869eb75115f5d7e6322","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.conf \u003d conf"},{"line_number":175,"context_line":"        socket_timeout \u003d self.conf.profiler.socket_timeout"},{"line_number":176,"context_line":"        parsed_url \u003d parser.urlparse(self.connection_str)"},{"line_number":177,"context_line":"        password \u003d parsed_url.password if parsed_url.password else None"},{"line_number":178,"context_line":"        sentinel \u003d Sentinel([(parsed_url.hostname, int(parsed_url.port))],"},{"line_number":179,"context_line":"                            password\u003dpassword,"},{"line_number":180,"context_line":"                            socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6fed4a8a","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":71},"in_reply_to":"3f79a3b5_7a8d1130","updated":"2018-08-17 00:29:31.000000000","message":"Actually, I tested this line without password passing , It faild. Else, I followed the code, and find thid parameter is needed.\nWe can find the parameter \"connection_kwargs\" in the \"master_for\" function of sentinel.py in redis project. This value is from this line. And this value will init connection to redis.","commit_id":"b1fe1adecd708b3925e5ab915a52b08415bb7a2c"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"6179d4a4eef4676eab1b1ccd83ad4cb4c018f519","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parsed_url \u003d parser.urlparse(self.connection_str)"},{"line_number":177,"context_line":"        password \u003d parsed_url.password if parsed_url.password else None"},{"line_number":178,"context_line":"        sentinel \u003d Sentinel([(parsed_url.hostname, int(parsed_url.port))],"},{"line_number":179,"context_line":"                            password\u003dpassword,"},{"line_number":180,"context_line":"                            socket_timeout\u003dsocket_timeout)"},{"line_number":181,"context_line":"        self.db \u003d sentinel.master_for(self.conf.profiler.sentinel_service_name,"},{"line_number":182,"context_line":"                                      socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1e8ecd78","line":179,"range":{"start_line":179,"start_character":28,"end_line":179,"end_character":45},"updated":"2018-08-22 15:35:53.000000000","message":"oops, sorry for not clarifying this.\nI meant that we can pass like this:\n\n  password\u003dparsed_url.password\n\ntherefore, you do not need to check if `parsed_url.password` is present or not\nbecause `parsed_url.password` will return `None` if there is no password is specified in `connection_string`","commit_id":"b1fe1adecd708b3925e5ab915a52b08415bb7a2c"},{"author":{"_account_id":25891,"name":"lipan","email":"lipan7195@fiberhome.com","username":"lipan"},"change_message_id":"333634944cfb6fdaff1c591be144061b13e17187","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parsed_url \u003d parser.urlparse(self.connection_str)"},{"line_number":177,"context_line":"        password \u003d parsed_url.password if parsed_url.password else None"},{"line_number":178,"context_line":"        sentinel \u003d Sentinel([(parsed_url.hostname, int(parsed_url.port))],"},{"line_number":179,"context_line":"                            password\u003dpassword,"},{"line_number":180,"context_line":"                            socket_timeout\u003dsocket_timeout)"},{"line_number":181,"context_line":"        self.db \u003d sentinel.master_for(self.conf.profiler.sentinel_service_name,"},{"line_number":182,"context_line":"                                      socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7c67bfb8","line":179,"range":{"start_line":179,"start_character":28,"end_line":179,"end_character":45},"in_reply_to":"3f79a3b5_1e8ecd78","updated":"2018-08-23 00:25:09.000000000","message":"oh,you are right,thanks.I\u0027ll fixed it.","commit_id":"b1fe1adecd708b3925e5ab915a52b08415bb7a2c"}]}
