)]}'
{"osprofiler/profiler.py":[{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"343799f2e1bae34c215c39e79713445942d1e96a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            except Exception as ex:"},{"line_number":161,"context_line":"                stop_info \u003d {"},{"line_number":162,"context_line":"                    \"etype\": reflection.get_class_name(ex),"},{"line_number":163,"context_line":"                    \"message\": ex.args[0] if ex.args else None"},{"line_number":164,"context_line":"                }"},{"line_number":165,"context_line":"                raise"},{"line_number":166,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1e7c0ac6","line":163,"updated":"2018-11-29 11:45:37.000000000","message":"it is better to use str(e) to get exception message since some of exception classes have more than 1 item in `args` tuple (https://docs.python.org/3.6/library/exceptions.html#BaseException.args), if curious str(e) in CPython is implemented here https://github.com/python/cpython/blob/master/Objects/exceptions.c#L104-L115\n\nBTW, why use None for empty string? With empty string client would not need to handle it specifically (with None the client will have to check the value before usage)","commit_id":"f1655acfe51dc8acaf0dc354887896e8aadf38bd"},{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"89f15360270281c6345a4d23556879081df83988","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            except Exception as ex:"},{"line_number":161,"context_line":"                stop_info \u003d {"},{"line_number":162,"context_line":"                    \"etype\": reflection.get_class_name(ex),"},{"line_number":163,"context_line":"                    \"message\": ex.args[0] if ex.args else None"},{"line_number":164,"context_line":"                }"},{"line_number":165,"context_line":"                raise"},{"line_number":166,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1134fbd6","line":163,"in_reply_to":"3f79a3b5_1e7c0ac6","updated":"2018-11-29 11:56:46.000000000","message":"I copied from here:\nhttps://github.com/openstack/osprofiler/blob/master/osprofiler/profiler.py#L349\nBut no problem I\u0027ll change it now","commit_id":"f1655acfe51dc8acaf0dc354887896e8aadf38bd"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0ea9a32d82937147a647c8f31cef0671cc360407","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            except Exception as ex:"},{"line_number":161,"context_line":"                stop_info \u003d {"},{"line_number":162,"context_line":"                    \"etype\": reflection.get_class_name(ex),"},{"line_number":163,"context_line":"                    \"message\": str(ex)"},{"line_number":164,"context_line":"                }"},{"line_number":165,"context_line":"                raise"},{"line_number":166,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9908f4d7","line":163,"range":{"start_line":163,"start_character":31,"end_line":163,"end_character":34},"updated":"2018-12-14 15:50:51.000000000","message":"Note that if the exception message has unicode, this will fail on python 2. You may want to use six.text_type to do this conversion.","commit_id":"768b566f8a74133d53d637f4607cd85689ae5795"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"aa3384a34ff03e919c064184ce04cbe1e69b5e19","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            except Exception as ex:"},{"line_number":161,"context_line":"                stop_info \u003d {"},{"line_number":162,"context_line":"                    \"etype\": reflection.get_class_name(ex),"},{"line_number":163,"context_line":"                    \"message\": str(ex)"},{"line_number":164,"context_line":"                }"},{"line_number":165,"context_line":"                raise"},{"line_number":166,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f717a8ef","line":163,"range":{"start_line":163,"start_character":31,"end_line":163,"end_character":34},"in_reply_to":"3f79a3b5_9908f4d7","updated":"2018-12-15 02:03:35.000000000","message":"I agree with this.\n\nAlso, repr can be an option too.","commit_id":"768b566f8a74133d53d637f4607cd85689ae5795"}]}